Clean up generated comment for lister/informers #40700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids spurious diffs to all generated files when a new group/version is added
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/L
liggitt
added
release-note-none
Member
|
/approve |
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
/approve |
k8s-github-robot
added
the
approved
liggitt
force-pushed
the
lister-gen-cleanup
branch
from
3702a95 to
c4e52d3
Compare
k8s-github-robot
removed
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED Needs approval from an approver in each of these OWNERS Files: We suggest the following people: |
k8s-github-robot
removed
the
approved
Member
Author
|
bazel build update only |
liggitt
added
approved
|
Automatic merge from submit-queue (batch tested with PRs 40691, 40551, 40683, 40700, 40702) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated comment including the command line means the addition of a new group/version touches all listers/informers, not just the ones for the new group/version
@ncdc PTAL