Skip to content

kernel memcg notification enabled via experimental flag#38296

Merged
k8s-github-robot merged 2 commits intokubernetes:release-1.5from
derekwaynecarr:cherry-pick-38258
Dec 8, 2016
Merged

kernel memcg notification enabled via experimental flag#38296
k8s-github-robot merged 2 commits intokubernetes:release-1.5from
derekwaynecarr:cherry-pick-38258

Conversation

@derekwaynecarr
Copy link
Copy Markdown
Member

@derekwaynecarr derekwaynecarr commented Dec 7, 2016

Kubelet integrates with kernel memcg notification API if and only if enabled via experimental flag.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 7, 2016
@k8s-reviewable
Copy link
Copy Markdown

k8s-reviewable commented Dec 7, 2016

This change is Reviewable

@derekwaynecarr
Copy link
Copy Markdown
Member Author

derekwaynecarr commented Dec 7, 2016

This is a cherry-pick of #38258

@derekwaynecarr
Copy link
Copy Markdown
Member Author

derekwaynecarr commented Dec 7, 2016

/cc @saad-ali @thockin @vishh @dchen1107 @mtaufen @eparis @gmarek

@derekwaynecarr derekwaynecarr added release-note Denotes a PR that will be considered when it comes time to generate release notes. cherrypick-candidate labels Dec 7, 2016
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 7, 2016
@derekwaynecarr derekwaynecarr mentioned this pull request Dec 7, 2016
Closed
@derekwaynecarr derekwaynecarr added this to the v1.5 milestone Dec 7, 2016
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 7, 2016

Jenkins GCE e2e failed for commit 03ac907. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 7, 2016

Jenkins GCE etcd3 e2e failed for commit 03ac907. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@dims
Copy link
Copy Markdown
Member

dims commented Dec 7, 2016

@k8s-bot cvm gce e2e test this

@dims
Copy link
Copy Markdown
Member

dims commented Dec 7, 2016

@k8s-bot gce etcd3 e2e test this

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 7, 2016

Jenkins GCI GCE e2e failed for commit 03ac907. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@sjenning
Copy link
Copy Markdown
Contributor

sjenning commented Dec 7, 2016

@dims @derekwaynecarr all e2e tests are currently flaking (every time) on this issue #37241

@derekwaynecarr
Copy link
Copy Markdown
Member Author

derekwaynecarr commented Dec 7, 2016

@k8s-bot gce etcd3 e2e test this

1 similar comment
@derekwaynecarr
Copy link
Copy Markdown
Member Author

derekwaynecarr commented Dec 7, 2016

@k8s-bot gce etcd3 e2e test this

@derekwaynecarr
Copy link
Copy Markdown
Member Author

derekwaynecarr commented Dec 7, 2016

@k8s-bot cvm gce e2e test this

@derekwaynecarr
Copy link
Copy Markdown
Member Author

derekwaynecarr commented Dec 7, 2016

@k8s-bot gci gce e2e test this

@derekwaynecarr derekwaynecarr mentioned this pull request Dec 7, 2016
Merged
@saad-ali saad-ali added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 8, 2016
@saad-ali
Copy link
Copy Markdown
Member

saad-ali commented Dec 8, 2016

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 8, 2016

@saad-ali: you can't LGTM a PR unless you are assigned as a reviewer.

Details

In response to this comment:

/lgtm

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@saad-ali saad-ali self-assigned this Dec 8, 2016
@saad-ali
Copy link
Copy Markdown
Member

saad-ali commented Dec 8, 2016

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2016
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Dec 8, 2016

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Dec 8, 2016

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 7887cf7 into kubernetes:release-1.5 Dec 8, 2016
@k8s-cherrypick-bot
Copy link
Copy Markdown

k8s-cherrypick-bot commented Dec 8, 2016

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dchen1107 dchen1107

@saad-ali saad-ali

Labels

cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.5

Development

Successfully merging this pull request may close these issues.

9 participants

@derekwaynecarr @k8s-reviewable @k8s-ci-robot @dims @sjenning @saad-ali @k8s-github-robot @k8s-cherrypick-bot @dchen1107