Fix cross-build for memcg notification by derekwaynecarr · Pull Request #37384 · kubernetes/kubernetes

derekwaynecarr · 2016-11-23T16:02:42Z

Fix the cross-build error from #32577

Fixes #37340

Fixes #37383

This change is

derekwaynecarr · 2016-11-23T16:03:10Z

fyi @sjenning @rmmh @mikedanese @dchen1107 @ncdc

I am testing this now, will report back if successful.

derekwaynecarr · 2016-11-23T16:03:21Z

fyi @saad-ali to fix build.

derekwaynecarr · 2016-11-23T16:44:50Z

@pires -- i was able to build on windows.

$ KUBE_BUILD_PLATFORMS=windows/amd64 make WHAT=cmd/kubelet
+++ [1123 11:40:10] Generating bindata:
    /home/decarr/go/src/k8s.io/kubernetes/test/e2e/framework/gobindata_util.go
+++ [1123 11:40:11] Building the toolchain targets:
    k8s.io/kubernetes/hack/cmd/teststale
+++ [1123 11:40:11] Building go targets for windows/amd64:
    cmd/libs/go2idl/openapi-gen
+++ [1123 11:41:04] Generating bindata:
    /home/decarr/go/src/k8s.io/kubernetes/test/e2e/framework/gobindata_util.go
+++ [1123 11:41:05] Building the toolchain targets:
    k8s.io/kubernetes/hack/cmd/teststale
+++ [1123 11:41:05] Building go targets for windows/amd64:
    cmd/kubelet

pires · 2016-11-23T16:49:24Z

Thanks @derekwaynecarr!

derekwaynecarr · 2016-11-23T16:57:47Z

ok, this should go all green now that i updated the test owners file.

mikedanese · 2016-11-23T16:58:08Z

I'd like @rmmh to confirm that cross-builds were failing because of kubelet on windows and not on non amd64 linux archs. I can't find the build output anywhere or I would check.

rmmh · 2016-11-23T17:00:26Z

@mikedanese it's in #37340, here's an example failure. It's hard to determine exactly which flavor of builds were failing.

rmmh · 2016-11-23T17:02:03Z

also, you can trigger a cross-build like this:

@k8s-bot build this

ncdc · 2016-11-23T17:02:07Z

That example shows both darwin and windows failures. LGTM if everyone else is ok

derekwaynecarr · 2016-11-23T17:02:47Z

@rmmh -- thanks for the magic invocation on cross-build trigger. that should clarify things.

k8s-ci-robot · 2016-11-23T17:23:44Z

Jenkins verification failed for commit 609877e. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

derekwaynecarr · 2016-11-23T17:25:43Z

@mikedanese -- should i pull a new version of gazel?

mikedanese · 2016-11-23T17:26:47Z

        "doc.go",
        "eviction_manager.go",
        "helpers.go",
+        "threshold_notifier_unsupported.go",


I think you should drop the change to this file.

This block should only contain files used to build linux, amd64. We don't need this file.

mikedanese · 2016-11-23T17:27:29Z

@derekwaynecarr are you on mac or linux? did you get that diff by running ./hack/update-bazel.sh?

mikedanese · 2016-11-23T17:29:39Z

Every incantation of ./hack/update-bazel.sh should pull a new version of gazel. If you are calling gazel directly then yes please pull new versions fairly often.

derekwaynecarr · 2016-11-23T17:34:49Z

@mikedanese - i was on fedora 24 and got that diff.

derekwaynecarr · 2016-11-23T17:35:33Z

@rmmh @mikedanese -- it looks like cross build is happy again with this, i will try and re-run bazel update to make jenkins happy.

derekwaynecarr · 2016-11-23T17:37:21Z

pushed one last update for bazel, it's possible that diff was from an earlier commit where build tag was wrong on the file. either way, this should pass cross build per the last version i sent.

@k8s-bot build this

i am not going to be available for next few hours, but this should be good to go.

derekwaynecarr · 2016-11-23T18:14:41Z

Ok. All the things are happy.

pires · 2016-11-23T18:27:36Z

@ncdc this fixes P0 stuff so is it needed to have P0 label as well?

ncdc · 2016-11-23T18:30:14Z

@pires labeled

k8s-ci-robot · 2016-11-23T19:07:41Z

Jenkins GCE etcd3 e2e failed for commit 1ec69f6. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

ncdc · 2016-11-23T19:10:22Z

@k8s-bot gce etcd3 e2e test this

On Wed, Nov 23, 2016 at 2:08 PM k8s-ci-robot [email protected]
wrote:

Jenkins GCE etcd3 e2e failed
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/37384/pull-kubernetes-e2e-gce-etcd3/5903/
for commit 1ec69f6
1ec69f6.
Full PR test history http://pr-test.k8s.io/37384.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e
test this. Please help us cut down flakes by linking to an open flake
issue
https://github.com/kubernetes/kubernetes/issues?q=is:issue+label:kind/flake+is:open
when you hit one in your PR.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#37384 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAABYht858h1c-5S46V3-tQjXFFzVFObks5rBI8UgaJpZM4K6wqd
.

dchen1107 · 2016-11-23T21:59:14Z

LGTM and I am manually merged this one for build fix.

saad-ali · 2016-11-30T03:13:21Z

Removing cherry-pick candidate label this is already in 1.5

…ross-build" This reverts commit e968173, reversing changes made to 5190ace.

Automatic merge from submit-queue (batch tested with PRs 51666, 49829, 51058, 51004, 50938) Fix threshold notifier build tags **What this PR does / why we need it**: Cross building from darwin is currently broken on the following error: ``` # k8s.io/kubernetes/pkg/kubelet/eviction pkg/kubelet/eviction/threshold_notifier_unsupported.go:25: NewMemCGThresholdNotifier redeclared in this block previous declaration at pkg/kubelet/eviction/threshold_notifier_linux.go:38 ``` It looks like #49300 broke the build tags introduced in #38630 and #37384. This fixes the build tag on `threshold_notifier_unsupported.go` as the cgo requirement was removed from `threshold_notifier_linux.go`. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #50935 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 23, 2016

derekwaynecarr added this to the v1.6 milestone Nov 23, 2016

derekwaynecarr force-pushed the fix-cross-build branch from eb65e36 to b14b0b5 Compare November 23, 2016 16:04

derekwaynecarr modified the milestones: v1.5, v1.6 Nov 23, 2016

dims mentioned this pull request Nov 23, 2016

Can't compile kubelet for Windows #37383

Closed

k8s-github-robot assigned vishh Nov 23, 2016

k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Nov 23, 2016

derekwaynecarr force-pushed the fix-cross-build branch from b14b0b5 to da127e7 Compare November 23, 2016 16:14

derekwaynecarr added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Nov 23, 2016

derekwaynecarr force-pushed the fix-cross-build branch from da127e7 to 609877e Compare November 23, 2016 16:56

derekwaynecarr assigned ncdc and dchen1107 Nov 23, 2016

mikedanese reviewed Nov 23, 2016

View reviewed changes

Fix cross-build for memcg notification

1ec69f6

derekwaynecarr force-pushed the fix-cross-build branch from 609877e to 1ec69f6 Compare November 23, 2016 17:36

derekwaynecarr added the cherrypick-candidate label Nov 23, 2016

ncdc added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2016

ncdc added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 23, 2016

smarterclayton mentioned this pull request Nov 23, 2016

Unable to compile on Mac #37400

Closed

dchen1107 merged commit e968173 into kubernetes:master Nov 23, 2016

saad-ali removed the cherrypick-candidate label Nov 30, 2016

gmarek added a commit to gmarek/kubernetes that referenced this pull request Dec 7, 2016

Revert "Merge pull request kubernetes#37384 from derekwaynecarr/fix-c…

d8b0732

…ross-build" This reverts commit e968173, reversing changes made to 5190ace.

cblecker mentioned this pull request Aug 18, 2017

Fix threshold notifier build tags #50938

Merged

Conversation

derekwaynecarr commented Nov 23, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

derekwaynecarr commented Nov 23, 2016

Uh oh!

derekwaynecarr commented Nov 23, 2016

Uh oh!

derekwaynecarr commented Nov 23, 2016

Uh oh!

pires commented Nov 23, 2016

Uh oh!

derekwaynecarr commented Nov 23, 2016

Uh oh!

mikedanese commented Nov 23, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rmmh commented Nov 23, 2016

Uh oh!

rmmh commented Nov 23, 2016

Uh oh!

ncdc commented Nov 23, 2016

Uh oh!

derekwaynecarr commented Nov 23, 2016

Uh oh!

k8s-ci-robot commented Nov 23, 2016

Uh oh!

derekwaynecarr commented Nov 23, 2016

Uh oh!

mikedanese Nov 23, 2016

Choose a reason for hiding this comment

Uh oh!

mikedanese Nov 23, 2016

Choose a reason for hiding this comment

Uh oh!

mikedanese commented Nov 23, 2016

Uh oh!

mikedanese commented Nov 23, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

derekwaynecarr commented Nov 23, 2016

Uh oh!

derekwaynecarr commented Nov 23, 2016

Uh oh!

derekwaynecarr commented Nov 23, 2016

Uh oh!

derekwaynecarr commented Nov 23, 2016

Uh oh!

pires commented Nov 23, 2016

Uh oh!

ncdc commented Nov 23, 2016

Uh oh!

k8s-ci-robot commented Nov 23, 2016

Uh oh!

ncdc commented Nov 23, 2016

Uh oh!

dchen1107 commented Nov 23, 2016

Uh oh!

saad-ali commented Nov 30, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

derekwaynecarr commented Nov 23, 2016 •

edited

Loading

mikedanese commented Nov 23, 2016 •

edited

Loading

mikedanese commented Nov 23, 2016 •

edited

Loading