Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@fraenkel Hey, nice to bump into you here :) fyi, there's an existing PR for DNS 1123 #28005

ok to test

LGTM, thanks!

Tests failed:

expose_test.go:407: truncate-name: Unexpected output! Expected
service "a-name-that-is-toooo-big-for-a-service-because-it-can-only-handle-63-characters" exposed
got
service "a-name-that-is-toooo-big-for-a-service-because-it-can-only-hand" exposed

The other seems to be a flake

Seems we truncate somewhere but tends to work locally. I can fix the test to match.

The truncation looks correct, not sure why it is not working.

Ping me when ready for next review.

On Fri, Jul 29, 2016 at 12:34 PM, Michael Fraenkel <[email protected]

wrote:

Seems we truncate somewhere but tends to work locally. I can fix the test
to match.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#29523 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVEamU6ov1OIi4W7p1XvxPTLAp_a2ks5qalW9gaJpZM4JTn7m
.

I know the problem. I have been struggling to get a clean run locally. But I will continue to try.

@thockin Tests now pass.

GCE e2e build/test passed for commit b1e7e6c.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

Thanks!!

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

GCE e2e build/test passed for commit b1e7e6c.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

Automatic merge from submit-queue