Proposal: Kubelet OCI runtime integration by mrunalp · Pull Request #26788 · kubernetes/kubernetes

mrunalp · 2016-06-03T17:36:13Z

* Use the release-note-* labels to set the release note state 
* Clear this block to use the PR title as the release note 
-OR-
* Enter your extended release note here

Signed-off-by: Mrunal Patel [email protected]
Signed-off-by: Vishnu Kannan [email protected]

This change is

googlebot · 2016-06-03T17:36:15Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

k8s-bot · 2016-06-03T17:36:32Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

mrunalp · 2016-06-03T17:36:50Z

@vishh @derekwaynecarr @rhatdan @dchen1107 PTAL

k8s-bot · 2016-06-03T17:37:13Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-06-03T17:38:13Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

mrunalp · 2016-06-03T18:27:40Z

@googlebot I signed it

vishh · 2016-06-03T20:03:45Z

cc @mtaufen

haiyanmeng · 2016-06-06T14:39:32Z

The uppercase used in this sentence (Rotate, Prioritize, Delete) seems a little wield.

vishh · 2016-06-07T00:50:41Z

cc @matchstick

resouer · 2016-06-08T06:41:12Z

cc @feiskyer @resouer

derekwaynecarr · 2016-06-08T17:30:59Z

@mrunalp @vishh LGTM, nice write-up

derekwaynecarr · 2016-06-08T17:32:00Z

/cc @kubernetes/sig-node @kubernetes/rh-cluster-infra

feiskyer · 2016-06-12T04:22:10Z

Is it possible not to depend on docker-engine? e.g., standalone implementation of docker registry client.

BTW, rkt could pull docker images without docker-engine.

👍 for not depending on docker-engine for pulling. Skopeo might be able to fit this use-case, or some other OCI tooling (cc @dgonyeo)

Maybe not useful here but going to mention it anyway, I recently created a tool for fetching OCI images to disk: https://github.com/containers/oci-fetch

We will create a separate proposal for image management using skopeo.

@runcom @rhatdan

On Jun 15, 2016, at 1:56 PM, Euan Kemp [email protected] wrote:

In docs/proposals/kubelet-oci-runtime.md:

+runtime options to enable additional features. It should be possible to support pods using runc as it has all the
+primitives to support pods. In addition to runc, compatibility with OCI Specification will let kubernetes support other
+OCI compliant runtimes as well.
+
+## Design aspects
+The following subsections will discuss the various design aspects of the runc integration with kubelet. For the purposes
+of this doc, the kubelet runtime that will provide support for OCI compliant container runtimes will be referred to as
+oci-runtime.
+
+### Runtime API
+The implementation will make use of the kubelet runtime API (#25899). The
+kubelet will implement the client API and the container runtimes including the one for OCI will implement the server
+API. The separation of client/server allows for faster iteration on the runtime integration development.
+
+### Image management
+For the first release, oci-runtime will continue to use docker-engine for managing images. The image management
👍 for not depending on docker-engine for pulling. Skopeo might be able to fit this use-case, or some other OCI tooling (cc @dgonyeo)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Right, that's eventually what we would like to see here and skopeo already does support pulling images w/o any docker dependencies. Skopeo aims at handling all image formats out there and we've recently been adding support for OCI as well.

To me, image sharing and indexing shoukd be build on top of skopeo in image managers. Agree we should focus on this though.

Something like graphc (or something built for clusters would fit also on top of skopeo)

@runcom I have yet to see a graphc demo although it has been brought up in lots of discussions. My understanding is that graphc is for handling the filesystems like overlayfs, btrfs, etc. I am discussing a content-addressable store that is shared similar to the rkt CAS store. Which, if needed, we are happy to pull out into a library.

The eventual goal is to make image pulls and storage pluggable in oci-runtime. As part of a MVP we decided to use the docker daemon. If there is a better or easier and stable solution, then we can use that too I guess. WDYT @mrunalp ?

It depends on what we want to do with layer sharing. If we are fine with vfs for rootfs in first cut then skopeo could handle pulling images.

dims · 2016-11-11T00:13:19Z

@k8s-bot test this issue

dims · 2016-11-11T01:11:42Z

@mrunalp looks like verify failed

I1110 16:37:18.869] FAILED   hack/make-rules/../../hack/verify-munge-docs.sh    17s

dims · 2016-11-14T21:17:44Z

@saad-ali : this seems to be just a proposal, does it need to merge? ( cc @vishh @mrunalp @dchen1107 )

saad-ali · 2016-11-15T05:18:55Z

@saad-ali : this seems to be just a proposal, does it need to merge? ( cc @vishh @mrunalp @dchen1107 )

Proposals can wait until post-code freeze to merge.

k8s-github-robot · 2016-12-15T05:26:50Z

This PR hasn't been active in 30 days. It will be closed in 59 days (Feb 13, 2017).

cc @dchen1107 @mrunalp @vishh

You can add 'keep-open' label to prevent this from happening, or add a comment to keep it open another 90 days

k8s-github-robot · 2017-01-23T22:05:40Z

[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files:

docs/OWNERS

We suggest the following people:
cc @thockin
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

calebamiles · 2017-03-02T07:06:39Z

@k8s-bot test this

k8s-ci-robot · 2017-03-02T08:06:10Z

@mrunalp: The following test(s) failed:

Test name	Commit	Details	Rerun command
Jenkins GKE smoke e2e	`dce95c8`	link	`@k8s-bot cvm gke e2e test this`
Jenkins GCE etcd3 e2e	`dce95c8`	link	`@k8s-bot gce etcd3 e2e test this`
Jenkins GCI GKE smoke e2e	`dce95c8`	link	`@k8s-bot gci gke e2e test this`
Jenkins Kubemark GCE e2e	`dce95c8`	link	`@k8s-bot kubemark e2e test this`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ncdc · 2017-03-14T18:54:25Z

Removing from v1.6

falenn · 2017-03-14T18:59:57Z

This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: [email protected] Domain imwiz.com has exceeded the max emails per hour (166/150 (110%)) allowed. Message will be reattempted later

…

------- This is a copy of the message, including all the headers. ------ Received: from github-smtp2-ext7.iad.github.net ([192.30.252.198]:60498 helo=github-smtp2a-ext-cp1-prd.iad.github.net) by box969.bluehost.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from <[email protected]>) id 1cnrao-0003tZ-SO for [email protected]; Tue, 14 Mar 2017 12:54:52 -0600 Date: Tue, 14 Mar 2017 11:54:33 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1489517673; bh=wTwlzzJhPE6HcA2f6QyucRoTXVbTy+w6mciUOiAAAc0=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=AW+C1gK7ibCrswID4pkLr5sLX3Z5LMNhay8m8OY2jF/gcYhaHg/YChbdt/QrN7SyR OCFgmgYPRLMLXIBHxS2E5+u1S0hWofpMnYUxHXvS/i49pKThER52C4iXhxB0w14CwZ S8EzL2PtWMk8PRyoe/NeEcEk9cCIArHkukqJwdEo= From: Andy Goldstein <[email protected]> Reply-To: kubernetes/kubernetes <[email protected]> To: kubernetes/kubernetes <[email protected]> Cc: Subscribed <[email protected]> Message-ID: <kubernetes/kubernetes/pull/26788/[email protected]> In-Reply-To: <kubernetes/kubernetes/pull/[email protected]> References: <kubernetes/kubernetes/pull/[email protected]> Subject: Re: [kubernetes/kubernetes] Proposal: Kubelet OCI runtime integration (#26788) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_58c83c69a495_e723fef9d605c30670c3"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: ncdc X-GitHub-Recipient: falenn X-GitHub-Reason: subscribed List-ID: kubernetes/kubernetes <kubernetes.kubernetes.github.com> List-Archive: https://github.com/kubernetes/kubernetes List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:unsub+000ab60a68d3a3e4ed8b2079a10737fd36357e266071ef1292cf0000000114dffe6992a169ce0971401a@reply.github.com>, <https://github.com/notifications/unsubscribe/AAq2CgfDcf-05NLuJ5IuNgt6RpffNXlBks5rluJpgaJpZM4Itvu7> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [email protected] X-Spam-Status: No, score=0.1 X-Spam-Score: 1 X-Spam-Bar: / X-Ham-Report: Spam detection software, running on the system "box969.bluehost.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see root\@localhost for details. Content preview: Removing from v1.6 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #26788 (comment) [...] Content analysis details: (0.1 points, 4.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.7 HTML_IMAGE_ONLY_20 BODY: HTML: images with 1600-2000 bytes of words 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.5 AWL AWL: Adjusted score from AWL reputation of From: address X-Spam-Flag: NO

----==_mimepart_58c83c69a495_e723fef9d605c30670c3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Removing from v1.6

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #26788 (comment) ----==_mimepart_58c83c69a495_e723fef9d605c30670c3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <p>Removing from v1.6</p> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#26788 (comment)">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAq2Cq_7CJgI7NVuqTlLsKW2Wn9KAXIuks5rluJpgaJpZM4Itvu7">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AAq2Cl98cpaKUap5bW0NCdxOv-x0TGncks5rluJpgaJpZM4Itvu7.gif" width="1" /></p> <div itemscope itemtype="http://schema.org/EmailMessage"> <div itemprop="action" itemscope itemtype="http://schema.org/ViewAction"> <link itemprop="url" href="#26788 (comment)"></link> <meta itemprop="name" content="View Pull Request"></meta> </div> <meta itemprop="description" content="View this Pull Request on GitHub"></meta> </div> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kubernetes/kubernetes","title":"kubernetes/kubernetes","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kubernetes/kubernetes"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ncdc in #26788: Removing from v1.6"}],"action":{"name":"View Pull Request","url":"#26788 (comment)"}}}</script> ----==_mimepart_58c83c69a495_e723fef9d605c30670c3--

cblecker · 2018-02-10T17:08:22Z

Design docs now live here: https://git.k8s.io/community/contributors/design-proposals
As this will never be merged into k/k, I'm going to close this. If this is still alive in some aspect, a new PR should be opened against the correct repo.

/remove-lifecycle frozen
/close

googlebot added the cla: no label Jun 3, 2016

k8s-github-robot assigned thockin Jun 3, 2016

k8s-github-robot added kind/design Categorizes issue or PR as related to design. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Jun 3, 2016

vishh assigned bgrant0607 and dchen1107 Jun 3, 2016

mrunalp force-pushed the oci-proposal branch 2 times, most recently from aff4c1b to c95e34c Compare June 3, 2016 18:25

vishh added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 3, 2016

haiyanmeng reviewed Jun 6, 2016
View reviewed changes

vishh unassigned thockin Jun 7, 2016

derekwaynecarr added cla: human-approved and removed cla: no labels Jun 8, 2016

feiskyer reviewed Jun 12, 2016
View reviewed changes

saad-ali modified the milestones: v1.6, v1.5 Nov 15, 2016

k8s-github-robot added kind/design Categorizes issue or PR as related to design. kind/old-docs do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Dec 1, 2016

mtaufen added the keep-open label Dec 19, 2016

k8s-github-robot assigned brendandburns and unassigned vishh and dchen1107 Jan 30, 2017

apelisse assigned vishh and dchen1107 Jan 31, 2017

k8s-github-robot assigned smarterclayton Jan 31, 2017

calebamiles removed the cla: no label Mar 2, 2017

ncdc removed this from the v1.6 milestone Mar 14, 2017

k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed keep-open labels Dec 15, 2017

k8s-ci-robot assigned cblecker Feb 10, 2018

k8s-ci-robot closed this Feb 10, 2018

k8s-ci-robot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Feb 10, 2018

Uh oh!

Conversation

mrunalp commented Jun 3, 2016 • edited by k8s-oncall Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Jun 3, 2016

Uh oh!

k8s-bot commented Jun 3, 2016

Uh oh!

mrunalp commented Jun 3, 2016

Uh oh!

k8s-bot commented Jun 3, 2016

Uh oh!

k8s-bot commented Jun 3, 2016

Uh oh!

mrunalp commented Jun 3, 2016

Uh oh!

vishh commented Jun 3, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vishh commented Jun 7, 2016

Uh oh!

resouer commented Jun 8, 2016

Uh oh!

derekwaynecarr commented Jun 8, 2016

Uh oh!

derekwaynecarr commented Jun 8, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dims commented Nov 11, 2016

Uh oh!

dims commented Nov 11, 2016

Uh oh!

dims commented Nov 14, 2016

Uh oh!

saad-ali commented Nov 15, 2016

Uh oh!

k8s-github-robot commented Dec 15, 2016

Uh oh!

k8s-github-robot commented Jan 23, 2017

Uh oh!

calebamiles commented Mar 2, 2017

Uh oh!

k8s-ci-robot commented Mar 2, 2017

Uh oh!

ncdc commented Mar 14, 2017

Uh oh!

falenn commented Mar 14, 2017 via email

Uh oh!

cblecker commented Feb 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

mrunalp commented Jun 3, 2016 •

edited by k8s-oncall

Loading