Skip to content

Fix Quantity OpenAPI description formatting - #140135

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
Dricmoy:issue-125020-commonmark-quantity-doc
Sep 10, 2026
Merged

kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
Dricmoy:issue-125020-commonmark-quantity-doc

Conversation

@Dricmoy

@Dricmoy Dricmoy commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind cleanup
/kind documentation

What this PR does / why we need it:

Updates the Quantity doc comment so the generated OpenAPI description is useful CommonMark.

The serialization grammar now renders as a Markdown list with inline code, and the canonical-form and examples sections render as separate list items instead of collapsed text.

Generated OpenAPI/protobuf/testdata outputs were refreshed.

Which issue(s) this PR is related to:

Fixes #125020

Special notes for your reviewer:

Verified the generated Kubernetes website API reference renders the Quantity grammar as a <ul> list with inline <code> spans.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@kubernetes-prow kubernetes-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. labels Jul 1, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 1, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: Dricmoy / name: Dricmoy (c1528b6)

@kubernetes-prow kubernetes-prow Bot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 1, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @Dricmoy!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 1, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @Dricmoy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation area/kubectl kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 1, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG CLI Jul 1, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from aojea and apelisse July 1, 2026 06:36
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 1, 2026
@k8s-triage-robot

Copy link
Copy Markdown

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@Dricmoy

Dricmoy commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

This PR does not change Kubernetes API semantics, wire format, validation, defaulting, versioned types, fields, flags, or behavior. It only updates the Quantity doc comment and refreshed generated OpenAPI/protobuf/testdata descriptions so the existing OpenAPI description renders as valid CommonMark.

The kind/api-change label seems to have been added because generated OpenAPI files changed. Could a reviewer confirm whether API review is actually required here? If not, could a member remove kind/api-change and proceed with triage / ok-to-test?

@peterzdhuang

peterzdhuang commented Jul 6, 2026 •

Copy link
Copy Markdown

This reads way nicer than the old code block

small nit: the old <...> made it obvious which words pointed to other rules vs. which were literals. Now everything's backticked the same, so in `suffix`: `binarySI | decimalExponent | decimalSI` it's not clear that binarySI is the rule below and not a literal. Maybe a quick note on the convention? Not a blocker.

@kubernetes-prow kubernetes-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 28, 2026
@jpbetz

jpbetz commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

I believe the prerequisites for this have no merged. This is ready to be rebased.

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 2, 2026
@jpbetz

jpbetz commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Checking in again, @Dricmoy would you rebase this PR? We can merge after.

@Dricmoy
Dricmoy force-pushed the issue-125020-commonmark-quantity-doc branch from c1528b6 to 1f33856 Compare September 9, 2026 20:37
@kubernetes-prow kubernetes-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2026
@jpbetz

jpbetz commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Thanks!

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 28f020163b33303451620fc2cf43a144fb755162

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Dricmoy, jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2026
@Dricmoy

Dricmoy commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

@jpbetz hey thanks for tagging and reminding, rebased!

@Dricmoy

Dricmoy commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

/retest-required

@kubernetes-prow
kubernetes-prow Bot merged commit b625429 into kubernetes:master Sep 10, 2026
22 checks passed
@kubernetes-prow kubernetes-prow Bot added this to the v1.38 milestone Sep 10, 2026
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in SIG CLI Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Comments that end up in OpenAPI descriptions should be CommonMark

4 participants