Repository navigation
Fix Quantity OpenAPI description formatting - #140135
kubernetes-prow[bot] merged 1 commit into
Conversation
|
|
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @Dricmoy! |
|
Hi @Dricmoy. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
|
This PR does not change Kubernetes API semantics, wire format, validation, defaulting, versioned types, fields, flags, or behavior. It only updates the Quantity doc comment and refreshed generated OpenAPI/protobuf/testdata descriptions so the existing OpenAPI The |
|
This reads way nicer than the old code block small nit: the old |
|
/ok-to-test I believe the prerequisites for this have no merged. This is ready to be rebased. |
|
Checking in again, @Dricmoy would you rebase this PR? We can merge after. |
c1528b6 to
1f33856
Compare
|
Thanks! /lgtm |
|
LGTM label has been added. DetailsGit tree hash: 28f020163b33303451620fc2cf43a144fb755162 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Dricmoy, jpbetz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jpbetz hey thanks for tagging and reminding, rebased! |
|
/retest-required |
What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
Updates the
Quantitydoc comment so the generated OpenAPI description is useful CommonMark.The serialization grammar now renders as a Markdown list with inline code, and the canonical-form and examples sections render as separate list items instead of collapsed text.
Generated OpenAPI/protobuf/testdata outputs were refreshed.
Which issue(s) this PR is related to:
Fixes #125020
Special notes for your reviewer:
Verified the generated Kubernetes website API reference renders the Quantity grammar as a
<ul>list with inline<code>spans.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: