Skip to content

tests for the same socket in Device Plugin - #139338

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
SergeyKanzhelev:same-device-same-port-f963cbb0
Oct 30, 2026
Merged

kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
SergeyKanzhelev:same-device-same-port-f963cbb0

Conversation

@SergeyKanzhelev

Copy link
Copy Markdown
Member

What type of PR is this?

/kind cleanup
/area test
/sig node
/cc @ffromani
/cc @zxqlxy

What this PR does / why we need it:

This is another follow up from #135437 that ensures we are not breaking behavior for same socket take over scenarios. It highlights the race conditions that are possible when socket is being reused. But neither are a new problems.

Special notes for your reviewer:

Some AI was used.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label May 28, 2026
@k8s-ci-robot
k8s-ci-robot requested a review from ffromani May 28, 2026 00:47
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@SergeyKanzhelev: GitHub didn't allow me to request PR reviews from the following users: zxqlxy.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

What type of PR is this?

/kind cleanup
/area test
/sig node
/cc @ffromani
/cc @zxqlxy

What this PR does / why we need it:

This is another follow up from #135437 that ensures we are not breaking behavior for same socket take over scenarios. It highlights the race conditions that are possible when socket is being reused. But neither are a new problems.

Special notes for your reviewer:

Some AI was used.

Does this PR introduce a user-facing change?

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. labels May 28, 2026
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 28, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet labels May 28, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2026
@SergeyKanzhelev
SergeyKanzhelev force-pushed the same-device-same-port-f963cbb0 branch from 951f820 to f5961b8 Compare May 28, 2026 21:03
@SergeyKanzhelev

Copy link
Copy Markdown
Member Author

/test pull-kubernetes-node-kubelet-serial-containerd
/retest

@SergeyKanzhelev
SergeyKanzhelev force-pushed the same-device-same-port-f963cbb0 branch 2 times, most recently from 5ed67f3 to 2bb72ee Compare June 1, 2026 16:44
@k8s-ci-robot

k8s-ci-robot commented Jun 1, 2026 •

Copy link
Copy Markdown
Contributor

@SergeyKanzhelev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-unit-windows-master 2bb72ee link false /test pull-kubernetes-unit-windows-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@harche harche moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board Jun 3, 2026
@SergeyKanzhelev

Copy link
Copy Markdown
Member Author

/retest-required

@zxqlxy

zxqlxy commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Thanks @SergeyKanzhelev for the detailed tests and comments. I have run the tests locally and confirmed it works. The comments are very detailed and noted that the same socket registration is the unsupported case here. We could make it more obvious somewhere if possible.

@SergeyKanzhelev

Copy link
Copy Markdown
Member Author

@ffromani are you OK to merge these code comments? Can you please review/lgtm?

@SergeyKanzhelev
SergeyKanzhelev force-pushed the same-device-same-port-f963cbb0 branch from 2bb72ee to b6b122e Compare June 23, 2026 00:20
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 11, 2026
@SergeyKanzhelev
SergeyKanzhelev force-pushed the same-device-same-port-f963cbb0 branch from 0a4d135 to 84aa688 Compare July 11, 2026 15:16
@kubernetes-prow kubernetes-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2026
@SergeyKanzhelev
SergeyKanzhelev force-pushed the same-device-same-port-f963cbb0 branch from 84aa688 to 9b01da6 Compare July 21, 2026 23:33
@SergeyKanzhelev

Copy link
Copy Markdown
Member Author

/retest

@harche

harche commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

@SergeyKanzhelev ping on the /hold from 7/02 — @haircommander said the nits/test idea are non-blocking and to unhold whenever you want. Still want anything before unhold?

@SergeyKanzhelev

Copy link
Copy Markdown
Member Author

/unhold

@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2026
@SergeyKanzhelev
SergeyKanzhelev force-pushed the same-device-same-port-f963cbb0 branch from 9b01da6 to d0da39c Compare October 1, 2026 06:35
@SergeyKanzhelev

Copy link
Copy Markdown
Member Author

/retest

@harche

harche commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

@ffromani could you take another look? The author has moved since your last review.

@dims

dims commented Oct 30, 2026

Copy link
Copy Markdown
Member

/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: f6474cb5eae9f4876802c271dcdd27edec94f754

@kubernetes-prow
kubernetes-prow Bot merged commit 5fb637e into kubernetes:master Oct 30, 2026
14 checks passed
@kubernetes-prow kubernetes-prow Bot added this to the v1.38 milestone Oct 30, 2026
@github-project-automation github-project-automation Bot moved this from PRs - Needs Reviewer to Done in SIG Node CI/Test Board Oct 30, 2026
@SergeyKanzhelev
SergeyKanzhelev deleted the same-device-same-port-f963cbb0 branch October 30, 2026 16:14
EItanya pushed a commit to kagent-dev/substrate that referenced this pull request Nov 3, 2026
…ubstrate#3486)

Follow-up to agent-substrate#3323, as @SergeyKanzhelev suggested there. kubelet expects
a device plugin to switch to a new socket when it re-registers. Since
1.37 it rejects a Register for a socket it still has connected, and two
overlapping Registers for one socket can wedge the resource as "already
connected" until kubelet restarts:
kubernetes/kubernetes#139338

- the device plugin listens on a new `ate.dev-kvm-<random>.sock` for
each registration, and removes sockets left over from earlier atelets
- the device plugin stays up until atelet exits again. agent-substrate#3323 stopped it
on SIGTERM to avoid overlapping with the replacement pod, but the
DaemonSet only starts the replacement once the old pod is gone, so that
just left `ate.dev/kvm` unhealthy for the whole drain

<!-- e.g. "AI-assisted, I reviewed and tested it." No AI co-author
trailers. -->
AI use: I used Claude to draft this and reviewed it.

<!-- Breaking change? Describe what users must do on upgrade and ask for
the `breaking-change` label. -->

- [x] Tests pass
- [x] Docs updated

---------

Signed-off-by: Benjamin Elder <[email protected]>
(cherry picked from commit 38e9ef6)
Signed-off-by: Eitan Yarmush <[email protected]>
yufan-su pushed a commit to yufan-su/substrate that referenced this pull request Nov 3, 2026
…ubstrate#3486)

Follow-up to agent-substrate#3323, as @SergeyKanzhelev suggested there. kubelet expects
a device plugin to switch to a new socket when it re-registers. Since
1.37 it rejects a Register for a socket it still has connected, and two
overlapping Registers for one socket can wedge the resource as "already
connected" until kubelet restarts:
kubernetes/kubernetes#139338

- the device plugin listens on a new `ate.dev-kvm-<random>.sock` for
each registration, and removes sockets left over from earlier atelets
- the device plugin stays up until atelet exits again. agent-substrate#3323 stopped it
on SIGTERM to avoid overlapping with the replacement pod, but the
DaemonSet only starts the replacement once the old pod is gone, so that
just left `ate.dev/kvm` unhealthy for the whole drain

<!-- e.g. "AI-assisted, I reviewed and tested it." No AI co-author
trailers. -->
AI use: I used Claude to draft this and reviewed it.

<!-- Breaking change? Describe what users must do on upgrade and ask for
the `breaking-change` label. -->

- [x] Tests pass
- [x] Docs updated

---------

Signed-off-by: Benjamin Elder <[email protected]>
dberkov pushed a commit to agent-substrate/substrate that referenced this pull request Nov 3, 2026
Follow-up to #3323, as @SergeyKanzhelev suggested there. kubelet expects
a device plugin to switch to a new socket when it re-registers. Since
1.37 it rejects a Register for a socket it still has connected, and two
overlapping Registers for one socket can wedge the resource as "already
connected" until kubelet restarts:
kubernetes/kubernetes#139338

- the device plugin listens on a new `ate.dev-kvm-<random>.sock` for
each registration, and removes sockets left over from earlier atelets
- the device plugin stays up until atelet exits again. #3323 stopped it
on SIGTERM to avoid overlapping with the replacement pod, but the
DaemonSet only starts the replacement once the old pod is gone, so that
just left `ate.dev/kvm` unhealthy for the whole drain

<!-- e.g. "AI-assisted, I reviewed and tested it." No AI co-author
trailers. -->
AI use: I used Claude to draft this and reviewed it.

<!-- Breaking change? Describe what users must do on upgrade and ask for
the `breaking-change` label. -->

- [x] Tests pass
- [x] Docs updated

---------

Signed-off-by: Benjamin Elder <[email protected]>
(cherry picked from commit 38e9ef6)
Signed-off-by: Eitan Yarmush <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Development

Successfully merging this pull request may close these issues.

7 participants