Skip to content

Rename feature gate EnableWorkloadWithJob to WorkloadWithJob#138210

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
Mujib-Ahasan:featuregate-WorkloadWithJob
Apr 9, 2026
Merged

Rename feature gate EnableWorkloadWithJob to WorkloadWithJob#138210
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
Mujib-Ahasan:featuregate-WorkloadWithJob

Conversation

@Mujib-Ahasan
Copy link
Copy Markdown
Contributor

@Mujib-Ahasan Mujib-Ahasan commented Apr 4, 2026

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Feature-gate name EnableWorkloadWithJob changed to WorkloadWithJob. It sounds very awkward when saying "disable EnableWorkloadWithJob" or "if you enable EnableWorkloadWithJob, then …" ( comment)

Which issue(s) this PR is related to: #138204

Fixes: #138204

Special notes for your reviewer:

This change renames the feature gate to align with our soft naming conventions. Feature gates are inherently enable/disable switches, so including terms like Enable in the name is redundant

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. area/apiserver area/test labels Apr 4, 2026
@k8s-ci-robot k8s-ci-robot requested review from dashpole and deads2k April 4, 2026 07:35
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 4, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 4, 2026

Hi @Mujib-Ahasan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Apps Apr 4, 2026
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 4, 2026
@Mujib-Ahasan Mujib-Ahasan changed the title remove accidently commited file Rename feature gate EnableWorkloadWithJob to WorkloadWithJob Apr 4, 2026
@lmktfy
Copy link
Copy Markdown
Member

lmktfy commented Apr 4, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 4, 2026
@Mujib-Ahasan
Copy link
Copy Markdown
Contributor Author

Mujib-Ahasan commented Apr 4, 2026

Got some error. I'll update this PR shortly.

@enj enj moved this to Needs Triage in SIG Auth Apr 4, 2026
@Mujib-Ahasan
lint small fix
bfe8f6b 
Signed-off-by: Mujib Ahasan <[email protected]>
@Mujib-Ahasan
Copy link
Copy Markdown
Contributor Author

Mujib-Ahasan commented Apr 4, 2026

This time I am not sure about the failed check!

@lmktfy
Copy link
Copy Markdown
Member

lmktfy commented Apr 5, 2026

/retest

@lmktfy
Copy link
Copy Markdown
Member

lmktfy commented Apr 5, 2026

/release-note-none

on the grounds that this is a fixup.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 5, 2026
@lmktfy
Copy link
Copy Markdown
Member

lmktfy commented Apr 5, 2026

I also suggest marking this PR as important-soon.

@Mujib-Ahasan
Copy link
Copy Markdown
Contributor Author

Mujib-Ahasan commented Apr 5, 2026

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 5, 2026
soltysh
soltysh approved these changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@github-project-automation github-project-automation Bot moved this from Needs Triage to In Review in SIG Auth Apr 7, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 7, 2026

LGTM label has been added.

DetailsGit tree hash: 38d3ef3a56d37c931a3cb01ce4e92dee4cfb4771

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Apr 7, 2026

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 7, 2026
@soltysh soltysh moved this from Needs Triage to Done in SIG Apps Apr 7, 2026
@soltysh soltysh mentioned this pull request Apr 7, 2026
Merged
@dims
Copy link
Copy Markdown
Member

dims commented Apr 7, 2026

/approve
/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, Mujib-Ahasan, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2026
@rytswd
Copy link
Copy Markdown
Member

rytswd commented Apr 9, 2026

LGTM from my end as a quick bug fix.

Ref: kubernetes/enhancements#5547

CC @Prajyot-Parab @sreeram-venkitesh

/milestone v1.36

@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Apr 9, 2026
@k8s-ci-robot k8s-ci-robot merged commit 40007b6 into kubernetes:master Apr 9, 2026
19 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Closed / Done in SIG Auth Apr 9, 2026
@carlory carlory mentioned this pull request Apr 21, 2026
Merged
@soltysh soltysh mentioned this pull request Apr 22, 2026
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh soltysh approved these changes

@dashpole dashpole Awaiting requested review from dashpole

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@dims dims

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG Apps
Status: Done
SIG Auth
Status: Closed / Done

Milestone

v1.36

Development

Successfully merging this pull request may close these issues.

Unhelpful feature gate name EnableWorkloadWithJob

8 participants

@Mujib-Ahasan @k8s-ci-robot @lmktfy @soltysh @dims @rytswd @benjaminapetersen @enj