Skip to content

revert adding PullImageResponse.image_id to CRI API#137574

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
SergeyKanzhelev:revertImageID
Mar 9, 2026
Merged

revert adding PullImageResponse.image_id to CRI API#137574
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
SergeyKanzhelev:revertImageID

Conversation

@SergeyKanzhelev

@SergeyKanzhelev SergeyKanzhelev commented Mar 9, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

/kind feature
/kind cleanup

revert of #137217, while keeping a stronger meaning of a field.

What this PR does / why we need it:

Containerd was compliant, CRI-O is updated. We do not want all runtimes to return two identical fields to make cri-dockerd compatible, it is best if cri-dockerd will be fixed.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

REVERT: CRI API: A new field is added to the PullImageResponse message - `image_id`. This field serves as a unique identifier for the image on the node as returned by the container runtimes.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 9, 2026
@k8s-ci-robot

k8s-ci-robot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 9, 2026
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Mar 9, 2026
Merged
@k8s-ci-robot

k8s-ci-robot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 9, 2026
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. labels Mar 9, 2026
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 9, 2026
@SergeyKanzhelev

SergeyKanzhelev commented Mar 9, 2026

Copy link
Copy Markdown
Member Author

/cc @mikebrow @samuelkarp @saschagrunert @haircommander @stlaz

@haircommander

haircommander commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

LGTM, I agree let's enforce with critest

@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Mar 9, 2026
Merged
@SergeyKanzhelev

SergeyKanzhelev commented Mar 9, 2026

Copy link
Copy Markdown
Member Author

this is how it looks for containerd: kubernetes-sigs/cri-tools#2004

CI will run it on CRI-O to check what we see there

@samuelkarp

samuelkarp commented Mar 9, 2026

Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2026
@k8s-ci-robot

k8s-ci-robot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 297f3eb34943e4d34c8ca40075a241c5bd84efd1

@samuelkarp samuelkarp mentioned this pull request Mar 9, 2026
Open
@k8s-ci-robot

k8s-ci-robot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

@SergeyKanzhelev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce 9f73dfc link unknown /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@SergeyKanzhelev

SergeyKanzhelev commented Mar 9, 2026

Copy link
Copy Markdown
Member Author

/retest-required

@k8s-ci-robot
k8s-ci-robot merged commit 5ceb6df into kubernetes:master Mar 9, 2026
12 of 13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Mar 9, 2026
@SergeyKanzhelev
SergeyKanzhelev deleted the revertImageID branch March 10, 2026 15:58
mhan8796 pushed a commit to mhan8796/kubernetes that referenced this pull request Jun 27, 2026
@k8s-ci-robot
Merge pull request kubernetes#137574 from SergeyKanzhelev/revertImageID
c468bcf 
revert adding PullImageResponse.image_id to CRI API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims Awaiting requested review from dims
@natasha41575 natasha41575 Awaiting requested review from natasha41575
@haircommander haircommander Awaiting requested review from haircommander
@mikebrow mikebrow Awaiting requested review from mikebrow
@samuelkarp samuelkarp Awaiting requested review from samuelkarp
@saschagrunert saschagrunert Awaiting requested review from saschagrunert
@stlaz stlaz Awaiting requested review from stlaz

Assignees

@samuelkarp samuelkarp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

SIG Node: code and documentation PRs
Archived in project

Milestone

v1.36

Development

Successfully merging this pull request may close these issues.

5 participants

@SergeyKanzhelev @k8s-ci-robot @haircommander @samuelkarp @benjaminapetersen