Skip to content

Adjust pod group scheduling cycle code#137216

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
macsko:podgroup_cycle_cleanup
Mar 3, 2026
Merged

Adjust pod group scheduling cycle code#137216
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
macsko:podgroup_cycle_cleanup

Conversation

@macsko
Copy link
Copy Markdown
Member

@macsko macsko commented Feb 24, 2026

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR applies pending comments from pod group cycle implementation: #136618

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 24, 2026
@macsko
Copy link
Copy Markdown
Member Author

macsko commented Feb 24, 2026

/cc @sanposhiho

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 24, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 24, 2026

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 24, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Scheduling Feb 24, 2026
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2026
@macsko macsko mentioned this pull request Feb 24, 2026
Merged
@sanposhiho
Copy link
Copy Markdown
Member

sanposhiho commented Feb 24, 2026

/assign

@sanposhiho
Copy link
Copy Markdown
Member

sanposhiho commented Feb 24, 2026

/hold

not to get merged with lgtm

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2026
utam0k
utam0k approved these changes Feb 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but waiting for sanposhi's review

@sanposhiho
Copy link
Copy Markdown
Member

sanposhiho commented Feb 24, 2026

I still don't like about RunPermitPlugins and RunPermitPluginsWithoutWaiting:
#136618 (comment)

@helayoty
Copy link
Copy Markdown
Member

helayoty commented Feb 27, 2026

/area workload-aware

@k8s-ci-robot k8s-ci-robot added the area/workload-aware Categorizes an issue or PR as relevant to Workload-aware and Topology-aware scheduling subprojects. label Feb 27, 2026
@helayoty helayoty moved this from Needs Triage to Needs Review in SIG Scheduling Feb 27, 2026
@helayoty helayoty moved this from Backlog to Needs Review in Workload-aware & Topology-aware Workstream Feb 27, 2026
@macsko macsko force-pushed the podgroup_cycle_cleanup branch from c63849b to 912bf9c Compare March 2, 2026 15:14
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 2, 2026
@macsko
Copy link
Copy Markdown
Member Author

macsko commented Mar 2, 2026 •
edited
Loading

I still don't like about RunPermitPlugins and RunPermitPluginsWithoutWaiting: #136618 (comment)

Applied that in the last commit. We have a single RunPermitPlugins now and the caller is expected to act on the Wait status.

@sanposhiho
Copy link
Copy Markdown
Member

sanposhiho commented Mar 3, 2026

/lgtm
/approve

thx!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 3, 2026

LGTM label has been added.

DetailsGit tree hash: 4464c574c564e7c063b3765a69dba930a020090c

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: macsko, sanposhiho, utam0k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@macsko
Copy link
Copy Markdown
Member Author

macsko commented Mar 3, 2026

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2026
@k8s-ci-robot k8s-ci-robot merged commit 8064801 into kubernetes:master Mar 3, 2026
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Mar 3, 2026
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in SIG Scheduling Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

@dom4ha dom4ha Awaiting requested review from dom4ha

1 more reviewer

@utam0k utam0k utam0k approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sanposhiho sanposhiho

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/workload-aware Categorizes an issue or PR as relevant to Workload-aware and Topology-aware scheduling subprojects. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG Scheduling
Archived in project
Workload-aware & Topology-aware Workstream
Status: Done

Milestone

v1.36

Development

Successfully merging this pull request may close these issues.

6 participants

@macsko @k8s-ci-robot @sanposhiho @helayoty @utam0k @mbrow137