Skip to content

KEP-4671: Add DelayedPreemption feature gate#137203

Closed
tosi3k wants to merge 1 commit intokubernetes:masterfrom
tosi3k:delayed-preemption
Closed

KEP-4671: Add DelayedPreemption feature gate#137203
tosi3k wants to merge 1 commit intokubernetes:masterfrom
tosi3k:delayed-preemption

Conversation

@tosi3k
Copy link
Copy Markdown
Member

@tosi3k tosi3k commented Feb 23, 2026

What type of PR is this?

/kind feature

What this PR does / why we need it:

The feature gate is needed for implementation of delayed preemption described in kubernetes/enhancements#4671.

Which issue(s) this PR is related to:

KEP: kubernetes/enhancements#4671

Special notes for your reviewer:

/sig scheduling
/area workload-aware

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. area/workload-aware Categorizes an issue or PR as relevant to Workload-aware and Topology-aware scheduling subprojects. labels Feb 23, 2026
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 23, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Scheduling Feb 23, 2026
@tosi3k
Copy link
Copy Markdown
Member Author

tosi3k commented Feb 23, 2026

/assign @macsko

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 23, 2026

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 23, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tosi3k
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tosi3k
Copy link
Copy Markdown
Member Author

tosi3k commented Feb 23, 2026

/retest

@helayoty helayoty moved this from Needs Triage to Needs Review in SIG Scheduling Feb 23, 2026
@tosi3k
Copy link
Copy Markdown
Member Author

tosi3k commented Feb 23, 2026

/retest

@helayoty helayoty moved this from Backlog to Needs Review in Workload-aware & Topology-aware Workstream Feb 23, 2026
macsko
macsko reviewed Feb 24, 2026
View reviewed changes
Comment thread pkg/features/kube_features.go
},

DelayedPreemption: {
{Version: version.MustParse("1.36"), Default: true, PreRelease: featuregate.Beta},
Copy link
Copy Markdown
Member

@macsko macsko Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{Version: version.MustParse("1.36"), Default: true, PreRelease: featuregate.Beta},
{Version: version.MustParse("1.36"), Default: false, PreRelease: featuregate.Alpha},

Copy link
Copy Markdown
Member Author

@tosi3k tosi3k Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate why?

Copy link
Copy Markdown
Member

@macsko macsko Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature gates should follow (with small exceptions) the KEP stage, which is alpha in v1.36. Having only the delayed preemption in beta and enabled by default won't bring us any added value, because it would be only used by the pod group cycle.

@lasomethingsomething lasomethingsomething mentioned this pull request Mar 10, 2026
Open
24 tasks
@tosi3k
Copy link
Copy Markdown
Member Author

tosi3k commented Mar 12, 2026

/close

We're dropping delayed preemption - at least for the scope of 1.36 release.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 12, 2026

@tosi3k: Closed this PR.

Details

In response to this:

/close

We're dropping delayed preemption - at least for the scope of 1.36 release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation Bot moved this from Needs Review to Closed in SIG Scheduling Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thockin thockin Awaiting requested review from thockin

@towca towca Awaiting requested review from towca

1 more reviewer

@macsko macsko macsko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@macsko macsko

Labels

area/workload-aware Categorizes an issue or PR as relevant to Workload-aware and Topology-aware scheduling subprojects. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

SIG Scheduling
Archived in project
Workload-aware & Topology-aware Workstream
Status: Closed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tosi3k @k8s-ci-robot @macsko @helayoty