Skip to content

Fix nil pointer dereference in submitPodGroupAlgorithmResult#137194

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
macsko:fix_nil_pointer_dereference_in_submit
Feb 23, 2026
Merged

Fix nil pointer dereference in submitPodGroupAlgorithmResult#137194
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
macsko:fix_nil_pointer_dereference_in_submit

Conversation

@macsko
Copy link
Copy Markdown
Member

@macsko macsko commented Feb 23, 2026 •
edited
Loading

What type of PR is this?

/kind bug
/kind flake

What this PR does / why we need it:

Fixes nil pointer dereference when PostFilter plugins return no nominating info. In that case it can be set to nil, what wasn't checked in the submitPodGroupAlgorithmResult.

Which issue(s) this PR is related to:

#137178

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/flake Categorizes issue or PR as related to a flaky test. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 23, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 23, 2026

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 23, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Scheduling Feb 23, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: macsko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 23, 2026
@macsko macsko mentioned this pull request Feb 23, 2026
Open
@mm4tt
Copy link
Copy Markdown
Contributor

mm4tt commented Feb 23, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 23, 2026

LGTM label has been added.

DetailsGit tree hash: 9e003da34a81d7fbef56506ebff4388de172a2d5

@k8s-ci-robot k8s-ci-robot merged commit 0cf70d1 into kubernetes:master Feb 23, 2026
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Feb 23, 2026
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in SIG Scheduling Feb 23, 2026
@macsko macsko mentioned this pull request Feb 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ania-borowiec ania-borowiec Awaiting requested review from ania-borowiec

@dom4ha dom4ha Awaiting requested review from dom4ha

Assignees

@mm4tt mm4tt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

SIG Scheduling
Archived in project

Milestone

v1.36

Development

Successfully merging this pull request may close these issues.

3 participants

@macsko @k8s-ci-robot @mm4tt