Skip to content

Introduce support of DRA for Node Allocatable Resources#136725

Merged
k8s-ci-robot merged 17 commits intokubernetes:masterfrom
pravk03:native-dra-2
Mar 18, 2026
Merged

Introduce support of DRA for Node Allocatable Resources#136725
k8s-ci-robot merged 17 commits intokubernetes:masterfrom
pravk03:native-dra-2

Conversation

@pravk03
Copy link
Copy Markdown
Contributor

@pravk03 pravk03 commented Feb 3, 2026 •
edited
Loading

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

This PR introduces API changes and validation to support mapping Dynamic Resource Allocation (DRA) devices to native Kubernetes resources like CPU and memory, as proposed in KEP-5517.

Which issue(s) this PR is related to:

kubernetes/enhancements#5517

Special notes for your reviewer:

Does this PR introduce a user-facing change?

 This change adds a new alpha feature DRANodeAllocatableResources, which includes:
 - A new ResourceSlice.Spec.Devices[*].NodeAllocatableResourceMappings field for DRA drivers to declare how device resources map to node allocatable Kubernetes resources (e.g., cpu, memory).
 - Changes in the DynamicResources plugin and the scheduler framework to correctly account for node allocatable resources requested through resource claims.
 - Kubelet's admission handler validates if the node can fulfill node allocatable DRA requests along with standard requests in the pod spec.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]:  https://github.com/kubernetes/enhancements/pull/5517

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 3, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 3, 2026
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 3, 2026
@k8s-ci-robot k8s-ci-robot added the wg/device-management Categorizes an issue or PR as relevant to WG Device Management. label Feb 3, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Apps Feb 3, 2026
@pravk03 pravk03 mentioned this pull request Feb 4, 2026
Merged
@pohly pohly moved this from 🆕 New to 🏗 In progress in Dynamic Resource Allocation Feb 4, 2026
@ffromani
Copy link
Copy Markdown
Contributor

ffromani commented Feb 4, 2026

/cc
/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot requested a review from ffromani February 4, 2026 09:04
@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Feb 4, 2026
pravk03 added 2 commits March 18, 2026 14:33
@pravk03
Add a linter exception for using maps.
ab5335d
@pravk03
Account for node allocatable claims in PodRequests
0f815fd 
This commit updates the PodRequests and AggregateContainerRequests functions to include resources from node allocatable claims when calculating the total resource requests for a pod.
@dom4ha
Copy link
Copy Markdown
Member

dom4ha commented Mar 18, 2026

/approve

@pravk03
Copy link
Copy Markdown
Contributor Author

pravk03 commented Mar 18, 2026

/retest

@pravk03
Copy link
Copy Markdown
Contributor Author

pravk03 commented Mar 18, 2026

@macsko @dom4ha Could I also get an lgtm if the changes look good.

tallclair
tallclair reviewed Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@tallclair tallclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

For test/e2e/node

pravk03 added 11 commits March 18, 2026 19:17
@pravk03
Implement changes in DRA Plugin to handle node-allocatable claims
af186d3 
* Filter: Calculate the pod's total resource footprint by combining spec requests and DRA allocations, respecting accounting policies. Perform node resource fit checks. Cache the resulting NodeAllocatableResourceClaimStatus in CycleState.
* PreBind: Retrieve result from CycleState and patch it into Pod.Status.
@pravk03
Update scheduler cache interface to pass node-allocatable resource al…
0c25bdf 
…locations to NodeInfo.
@pravk03
Account for node-allocatable claims in NodeInfo cache
7c4f9ac
@pravk03
Include node-allocatable claims in kubelet admission check
9e22d7b
@pravk03
Add validation to disable in-place resize for pods with node-allocata…
2ce83e6 
…ble resource claims
@pravk03
Add validation check to disallow node-allocatable resource claim shar…
6283652 
…ing.
@pravk03
Validate Pod resources cover container and DRA requests.
a84f938
@pravk03
Add pod Status and ResourceSlice API validation
6b83eef
@pravk03
Add integration tests.
cdcfc4e
@pravk03
Cleanup NodeAllocatableDRAClaimStatus in Unreserve
11c8bf1
@pravk03
Verify that assumed pod NodeAllocatableResourceClaimStatuses matches …
3cd22dc 
…the status to patch.
@macsko
Copy link
Copy Markdown
Member

macsko commented Mar 18, 2026

@macsko @dom4ha Could I also get an lgtm if the changes look good.

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 18, 2026

LGTM label has been added.

DetailsGit tree hash: b3f54283840d18942e9d5335face64c6a6574a1d

@pravk03
Copy link
Copy Markdown
Contributor Author

pravk03 commented Mar 18, 2026

/retest

@pravk03
Copy link
Copy Markdown
Contributor Author

pravk03 commented Mar 18, 2026

@liggitt - for the final approvals if everything looks good.

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Mar 18, 2026

/approve
for API bits

leaning on scheduler / DRA reviewers and approvers for implementation bits

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dom4ha, johnbelamaric, liggitt, pravk03, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pravk03
Copy link
Copy Markdown
Contributor Author

pravk03 commented Mar 18, 2026

/retest

@pravk03 pravk03 mentioned this pull request Mar 26, 2026
Merged
@pravk03
Copy link
Copy Markdown
Contributor Author

pravk03 commented Apr 23, 2026

/retitle Introduce support of DRA for Node Allocatable Resources

@pravk03
Copy link
Copy Markdown
Contributor Author

pravk03 commented Apr 23, 2026

/edit-release-note

 This change adds a new alpha feature DRANodeAllocatableResources, which includes:
 - A new ResourceSlice.Spec.Devices[*].NodeAllocatableResourceMappings field for DRA drivers to declare how device resources map to native Kubernetes resources (e.g., cpu, memory).
 - Changes in the DynamicResources plugin and the scheduler framework to correctly account for native resources requested through resource claims.
 - Kubelet's admission handler validates if the node can fulfill native resource DRA requests along with standard requests in the pod spec

@pravk03 pravk03 mentioned this pull request Apr 23, 2026
Merged
@pohly
Copy link
Copy Markdown
Contributor

pohly commented Apr 24, 2026

@pravk03: It's a bit late to change the release note... The old one is already included in https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.36.md#api-change.

@pravk03
Copy link
Copy Markdown
Contributor Author

pravk03 commented Apr 24, 2026

@pohly I missed updating the PR's release notes after the field changes. Trying to fix it with #138554.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt liggitt left review comments

@AxeZhan AxeZhan Awaiting requested review from AxeZhan

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@mortent mortent Awaiting requested review from mortent

@pohly pohly Awaiting requested review from pohly

@ajaysundark ajaysundark Awaiting requested review from ajaysundark

+7 more reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@bart0sh bart0sh bart0sh requested changes

@ffromani ffromani ffromani left review comments

@tallclair tallclair tallclair left review comments

@macsko macsko macsko left review comments

@dom4ha dom4ha dom4ha left review comments

@johnbelamaric johnbelamaric johnbelamaric approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pohly pohly

@liggitt liggitt

@johnbelamaric johnbelamaric

@tallclair tallclair

@macsko macsko

@dom4ha dom4ha

Labels

api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.

Projects

API Reviews
Status: API review completed, 1.36
Dynamic Resource Allocation
Status: ✅ Done
SIG Apps
Archived in project
SIG Node CI/Test Board
Status: Done
SIG Node: code and documentation PRs
Status: Done
SIG Scheduling
Archived in project

Milestone

v1.36

Development

Successfully merging this pull request may close these issues.