Skip to content

[KEP 4205] GA the KubeletPSI FeatureGate#136548

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
mariafromano-25:psi-ga-update
Mar 18, 2026
Merged

[KEP 4205] GA the KubeletPSI FeatureGate#136548
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
mariafromano-25:psi-ga-update

Conversation

@mariafromano-25
Copy link
Copy Markdown
Contributor

@mariafromano-25 mariafromano-25 commented Jan 26, 2026 •
edited
Loading

What type of PR is this?

/kind feature
/sig node

What this PR does / why we need it:

GA the KubeletPSI feature gate for 1.36

Which issue(s) this PR is related to:

kubernetes/enhancements#4205

Special notes for your reviewer:

The KubeletPSI feature has graduated to General Availability (GA) and continues to be enabled by default. This feature allows the Kubelet to expose Linux cgroup Pressure Stall Information (PSI) metrics, providing deeper visibility into system and pod-level resource contention (CPU, Memory, and I/O) via the Kubelet Summary API.

cc: @roycaihw @ndixita

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jan 26, 2026
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 26, 2026
@ffromani
Copy link
Copy Markdown
Contributor

ffromani commented Jan 26, 2026

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 26, 2026
@pacoxu pacoxu mentioned this pull request Jan 27, 2026
Closed
34 tasks
@ngopalak-redhat ngopalak-redhat mentioned this pull request Jan 30, 2026
Closed
@kannon92
Copy link
Copy Markdown
Contributor

kannon92 commented Feb 9, 2026

Commented on the KEP issue but didn't get any response.

Should this issue be blocking GA? We usually don't promote a feature with open issues against it.
#136642

haircommander
haircommander reviewed Mar 11, 2026
View reviewed changes
Comment thread pkg/features/kube_features.go
@mariafromano-25
Copy link
Copy Markdown
Contributor Author

mariafromano-25 commented Mar 11, 2026

/retest

@SergeyKanzhelev
Copy link
Copy Markdown
Member

SergeyKanzhelev commented Mar 12, 2026

Commented on the KEP issue but didn't get any response.

Should this issue be blocking GA? We usually don't promote a feature with open issues against it. #136642

Explicit hold to answer this question from @kannon92

There is also this bug: #136333 - same question on whether it is blocking

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 12, 2026
@mariafromano-25
Copy link
Copy Markdown
Contributor Author

mariafromano-25 commented Mar 16, 2026 •
edited
Loading

Commented on the KEP issue but didn't get any response.
Should this issue be blocking GA? We usually don't promote a feature with open issues against it. #136642

Explicit hold to answer this question from @kannon92

The final comment in that Issue explained that it would close in favor of the other KEP which aims to enhance CRI implementations to be able to fulfill all the stats needs of Kubernetes. If more consideration to configure the metrics fine-grained when that KEP is done, it would reopen. Can we consider this non-blocking then? @kannon92

There is also this bug: #136333 - same question on whether it is blocking

Looks like there is PR #137326 for that fix of emitting metrics despite PSI disabled at OS level. Do you think it can get merged by codefreeze?

@mariafromano-25 mariafromano-25 mentioned this pull request Mar 16, 2026
Open
@kannon92
Copy link
Copy Markdown
Contributor

kannon92 commented Mar 17, 2026

The issue is closed so I don't think it should be blocking.

@SergeyKanzhelev
Copy link
Copy Markdown
Member

SergeyKanzhelev commented Mar 17, 2026

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2026
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 18, 2026
@mariafromano-25
Copy link
Copy Markdown
Contributor Author

mariafromano-25 commented Mar 18, 2026

/test pull-kubernetes-node-e2e-containerd
/test pull-kubernetes-e2e-gce

@roycaihw
Copy link
Copy Markdown
Member

roycaihw commented Mar 18, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 18, 2026

LGTM label has been added.

DetailsGit tree hash: 3a9c7636f71096956656bfd1b4af6ebe0ca9f886

SergeyKanzhelev
SergeyKanzhelev approved these changes Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mariafromano-25, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2026
@k8s-ci-robot k8s-ci-robot merged commit 76a3d53 into kubernetes:master Mar 18, 2026
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Mar 18, 2026
@tengqm tengqm mentioned this pull request Apr 8, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

2 more reviewers

@haircommander haircommander haircommander left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@roycaihw roycaihw

@SergeyKanzhelev SergeyKanzhelev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG Node: code and documentation PRs
Status: Done

Milestone

v1.36

Development

Successfully merging this pull request may close these issues.

7 participants

@mariafromano-25 @ffromani @kannon92 @SergeyKanzhelev @roycaihw @k8s-ci-robot @haircommander