Skip to content

rename scaleReplicaSetAndRecordEvent to scaleReplicaSetWithLazyAnnotationUpdate#135234

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
atiratree:renameScaleReplicaSetAndRecordEvent
Jan 8, 2026
Merged

rename scaleReplicaSetAndRecordEvent to scaleReplicaSetWithLazyAnnotationUpdate#135234
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
atiratree:renameScaleReplicaSetAndRecordEvent

Conversation

@atiratree
Copy link
Copy Markdown
Member

@atiratree atiratree commented Nov 8, 2025

What type of PR is this?

/kind cleanup

/kind flake
/kind regression

What this PR does / why we need it:

#134840 introduced a regression that caused the [sig-apps] Deployment iterative rollouts should eventually progress test to flake . This regression might have been caused by improper naming and documentation of the scaleReplicaSetAndRecordEvent. Simple rename should prevent future mishaps.

Which issue(s) this PR is related to:

fixes #135222

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/flake Categorizes issue or PR as related to a flaky test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 8, 2025
@atiratree
Copy link
Copy Markdown
Member Author

atiratree commented Nov 8, 2025

/assign @soltysh

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Nov 8, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 8, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Apps Nov 8, 2025
This was referenced Nov 8, 2025
Closed
Merged
@atiratree
Copy link
Copy Markdown
Member Author

atiratree commented Nov 8, 2025

cc @ahmetb

@atiratree atiratree force-pushed the renameScaleReplicaSetAndRecordEvent branch from 376ca7e to e6641cd Compare November 8, 2025 15:18
@atiratree atiratree mentioned this pull request Nov 17, 2025
Open
8 tasks
soltysh
soltysh approved these changes Jan 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Jan 8, 2026

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 8, 2026

LGTM label has been added.

DetailsGit tree hash: f8498d962480523b3cc038d86c193b6df001212b

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jan 8, 2026
@k8s-ci-robot k8s-ci-robot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 8, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 8, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 8, 2026

@atiratree: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-integration e6641cd link unknown /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Jan 8, 2026

Known flake #133861

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit c9994c5 into kubernetes:master Jan 8, 2026
12 of 13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Jan 8, 2026
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in SIG Apps Jan 8, 2026
@pacoxu pacoxu mentioned this pull request Jan 9, 2026
Closed
@soltysh soltysh mentioned this pull request Jan 15, 2026
Merged
@atiratree atiratree mentioned this pull request Feb 3, 2026
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh soltysh approved these changes

@krmayankk krmayankk Awaiting requested review from krmayankk

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/flake Categorizes issue or PR as related to a flaky test. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG Apps
Archived in project

Milestone

v1.36

Development

Successfully merging this pull request may close these issues.

Deployment scaleReplicaSetAndRecordEvent vs scaleReplicaSet duplication cleanup is problematic

3 participants

@atiratree @soltysh @k8s-ci-robot