Skip to content

Revert "controller: duplicate utility method cleanup"#135154

Merged
k8s-ci-robot merged 1 commit intomasterfrom
revert-134840-ahmet/mini-cleanup
Nov 6, 2025
Merged

Revert "controller: duplicate utility method cleanup"#135154
k8s-ci-robot merged 1 commit intomasterfrom
revert-134840-ahmet/mini-cleanup

Conversation

@soltysh
Copy link
Copy Markdown
Contributor

@soltysh soltysh commented Nov 5, 2025

Reverts #134840

This can potentially fix #135150 b/c it seems that the increased failure rates correlate with when this merged.

/cc @ahmetb

@k8s-ci-robot k8s-ci-robot requested a review from ahmetb November 5, 2025 20:07
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 5, 2025
@soltysh
Copy link
Copy Markdown
Contributor Author

soltysh commented Nov 5, 2025

/hold
for testing

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 5, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Apps Nov 5, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2025
@soltysh soltysh mentioned this pull request Nov 5, 2025
Closed
@soltysh
Copy link
Copy Markdown
Contributor Author

soltysh commented Nov 5, 2025

/sig apps
/triage accepted
/priority critical-urgent
/kind flake

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. kind/flake Categorizes issue or PR as related to a flaky test. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 5, 2025
@soltysh
Copy link
Copy Markdown
Contributor Author

soltysh commented Nov 5, 2025

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 5, 2025
@ahmetb
Copy link
Copy Markdown
Member

ahmetb commented Nov 5, 2025

I can't put my finger on why would this cause a failure. Go ahead please if you need.

@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Nov 5, 2025

/test all

@pacoxu
Copy link
Copy Markdown
Member

pacoxu commented Nov 6, 2025

flake rate is so high that the merging pool is influenced

/unhold
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 6, 2025

LGTM label has been added.

DetailsGit tree hash: 6a4c5bf0d385ddbe1d98e709c66a66f66c96e2e5

@pacoxu
Copy link
Copy Markdown
Member

pacoxu commented Nov 6, 2025 •
edited
Loading

/test pull-kubernetes-node-e2e-containerd
this is another almost-blocking flaking failure as well.

@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Nov 6, 2025

Retesting failed PR that otherwise appears ready for merge.

Please help us fix flaky tests by following our Flaky Tests Guide.

Prevent this bot from retesting with /lgtm cancel or /hold.
For this robot's configuration, see here.

/retest-required

@k8s-ci-robot k8s-ci-robot merged commit 6723bea into master Nov 6, 2025
12 of 13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Nov 6, 2025
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in SIG Apps Nov 6, 2025
@huww98 huww98 mentioned this pull request Nov 6, 2025
Merged
@soltysh
Copy link
Copy Markdown
Contributor Author

soltysh commented Nov 6, 2025

I can't put my finger on why would this cause a failure. Go ahead please if you need.

I've looked at it for quite some time wondering about it too 😓 I'll return to this probably after KubeCon and see what might be causing it.

@soltysh soltysh deleted the revert-134840-ahmet/mini-cleanup branch November 6, 2025 10:37
@soltysh soltysh mentioned this pull request Nov 7, 2025
Closed
@atiratree
Copy link
Copy Markdown
Member

atiratree commented Nov 8, 2025

please see #135222 (comment) and #135234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahmetb ahmetb Awaiting requested review from ahmetb

Assignees

@pacoxu pacoxu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG Apps
Archived in project

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

Failure cluster [10314e1b...]: Deployment iterative rollouts should eventually progress

7 participants

@soltysh @k8s-ci-robot @ahmetb @BenTheElder @pacoxu @k8s-triage-robot @atiratree