Skip to content

KEP-5278 Promote NominatedNodeNameForExpectation and ClearingNominatedNodeNameAfterBinding feature gates to beta #135103

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ania-borowiec:nnn_flag
Nov 7, 2025
Merged

KEP-5278 Promote NominatedNodeNameForExpectation and ClearingNominatedNodeNameAfterBinding feature gates to beta #135103
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ania-borowiec:nnn_flag

Conversation

@ania-borowiec
Copy link
Copy Markdown
Contributor

@ania-borowiec ania-borowiec commented Nov 4, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Promote NominatedNodeNameForExpectation and ClearingNominatedNodeNameAfterBinding feature gates to beta, making them enabled by default.

Which issue(s) this PR is related to:

#132381
KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/5278-nominated-node-name-for-expectation

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Features: NominatedNodeNameForExpectation in kube-scheduler and CleaeringNominatedNodeNameAfterBinding in kube-apiserver are now enabled by default.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/5278-nominated-node-name-for-expectation

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 4, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 4, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver area/cloudprovider area/code-generation area/conformance Issues or PRs related to kubernetes conformance tests area/dependency Issues or PRs related to dependency changes area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kube-proxy area/kubeadm area/kubectl area/kubelet area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 4, 2025
@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. labels Nov 4, 2025
@ania-borowiec
Copy link
Copy Markdown
Contributor Author

ania-borowiec commented Nov 4, 2025

/test all

@enj enj moved this to Needs Triage in SIG Auth Nov 5, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 5, 2025
@ania-borowiec ania-borowiec marked this pull request as ready for review November 5, 2025 18:03
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2025
@ania-borowiec
Copy link
Copy Markdown
Contributor Author

ania-borowiec commented Nov 5, 2025

/cc @dom4ha @macsko @sanposhiho

@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Nov 5, 2025

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

macsko
macsko reviewed Nov 6, 2025
View reviewed changes
Comment thread pkg/features/kube_features.go Outdated

ClearingNominatedNodeNameAfterBinding: {
{Version: version.MustParse("1.34"), Default: false, PreRelease: featuregate.Alpha},
{Version: version.MustParse("1.35"), Default: false, PreRelease: featuregate.Beta},
Copy link
Copy Markdown
Member

@macsko macsko Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

Suggested change
{Version: version.MustParse("1.35"), Default: false, PreRelease: featuregate.Beta},
{Version: version.MustParse("1.35"), Default: true, PreRelease: featuregate.Beta},

Copy link
Copy Markdown
Contributor Author

@ania-borowiec ania-borowiec Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops 😃

macsko
macsko reviewed Nov 6, 2025
View reviewed changes
Comment thread test/compatibility_lifecycle/reference/versioned_feature_list.yaml
@ania-borowiec
Copy link
Copy Markdown
Contributor Author

ania-borowiec commented Nov 6, 2025

/test pull-kubernetes-e2e-kind-alpha-beta-features

@ania-borowiec
Copy link
Copy Markdown
Contributor Author

ania-borowiec commented Nov 7, 2025

/test pull-kubernetes-node-e2e-restartallcontainers

@dom4ha
Copy link
Copy Markdown
Member

dom4ha commented Nov 7, 2025

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 7, 2025

LGTM label has been added.

DetailsGit tree hash: 2f42149f4ae7ebfe0753796418326f5f2909872c

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ania-borowiec, dom4ha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dom4ha
Copy link
Copy Markdown
Member

dom4ha commented Nov 7, 2025

/hold

@ania-borowiec
Copy link
Copy Markdown
Contributor Author

ania-borowiec commented Nov 7, 2025

/retest

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 7, 2025

@ania-borowiec: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-e2e-restartallcontainers e6d95a7 link false /test pull-kubernetes-node-e2e-restartallcontainers

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jmickey jmickey mentioned this pull request Nov 7, 2025
Open
10 tasks
@macsko
Copy link
Copy Markdown
Member

macsko commented Nov 7, 2025

/skip
Flaky test

@macsko
Copy link
Copy Markdown
Member

macsko commented Nov 7, 2025

#135149 was merged
/unhold
/milestone v1.35
Since the PR got the approval on time

@renovate renovate Bot mentioned this pull request Mar 17, 2026
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrianmoisey adrianmoisey Awaiting requested review from adrianmoisey

@alexzielenski alexzielenski Awaiting requested review from alexzielenski

@luxas luxas Awaiting requested review from luxas

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@dom4ha dom4ha Awaiting requested review from dom4ha

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

1 more reviewer

@macsko macsko macsko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dom4ha dom4ha

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/conformance Issues or PRs related to kubernetes conformance tests area/dependency Issues or PRs related to dependency changes area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kube-proxy area/kubeadm area/kubectl area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.

Projects

Dynamic Resource Allocation
Archived in project
SIG Apps
Archived in project
SIG Auth
Archived in project
SIG CLI
Archived in project
SIG Instrumentation
Archived in project
SIG Node CI/Test Board
Status: Done
SIG Node: code and documentation PRs
Archived in project
SIG Scheduling
Archived in project

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

7 participants

@ania-borowiec @k8s-ci-robot @k8s-triage-robot @dom4ha @macsko @benjaminapetersen @enj