statusz: move componentName into registry#135091
Open
richabanker wants to merge 1 commit intokubernetes:masterfrom
Open
statusz: move componentName into registry#135091richabanker wants to merge 1 commit intokubernetes:masterfrom
richabanker wants to merge 1 commit intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/apiserver
area/kube-proxy
area/kubelet
sig/api-machinery
k8s-ci-robot
added
the
sig/node
k8s-ci-robot
added
the
sig/scheduling
github-project-automation
Bot
added this to
SIG Node: code and documentation PRs and SIG Scheduling
github-project-automation
Bot
moved this to Triage
in SIG Node: code and documentation PRs
richabanker
force-pushed
the
statusz-structured
branch
from
b53bbe6 to
9c3802a
Compare
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: 8c0d67f28403780605d44f024ca699763dfbce9a |
Contributor
|
/remove-sig api-machinery |
k8s-ci-robot
removed
the
sig/api-machinery
Member
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dgrisonnet, richabanker The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-rebase
haircommander
moved this from Triage
to other-sig (sig-node-approved)
in SIG Node: code and documentation PRs
haircommander
moved this from other-sig (sig-node-approved)
to Not Sig Node
in SIG Node: code and documentation PRs
dims
added
the
lifecycle/rotten
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Moves componentName into statusz registry. Previously, componentName was passed separately to statusz handler's Install(). This establishes a cleaner pattern where the registry is the single source of truth for all statusz metadata
Which issue(s) this PR is related to:
kubernetes/enhancements#4827
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: