Skip to content

controller: duplicate utility method cleanup#134840

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ahmetb:ahmet/mini-cleanup
Nov 5, 2025
Merged

controller: duplicate utility method cleanup#134840
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ahmetb:ahmet/mini-cleanup

Conversation

@ahmetb
Copy link
Copy Markdown
Member

@ahmetb ahmetb commented Oct 24, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

It appears one of these methods in deployment controller is redundant now that we always emit Events during scaling.

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

/sig apps

@ahmetb
controller: duplicate utility method cleanup
5f083e3 
It appears one of these methods in deployment controller is redundant now that
we always emit Events during scaling.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Oct 24, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 24, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Apps Oct 24, 2025
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 24, 2025
@ahmetb
Copy link
Copy Markdown
Member Author

ahmetb commented Nov 3, 2025

/retest

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Nov 5, 2025

/triage accepted
/priority important-longter

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Nov 5, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 5, 2025

@soltysh: The label(s) priority/important-longter cannot be applied, because the repository doesn't have them.

Details

In response to this:

/triage accepted
/priority important-longter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 5, 2025
@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Nov 5, 2025

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 5, 2025
soltysh
soltysh approved these changes Nov 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - thank you!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 5, 2025

LGTM label has been added.

DetailsGit tree hash: 2ce86bad2657054ca039a3a84701403ddbcfa5ed

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9ef1a14 into kubernetes:master Nov 5, 2025
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Nov 5, 2025
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in SIG Apps Nov 5, 2025
@soltysh soltysh mentioned this pull request Nov 5, 2025
Closed
This was referenced Nov 5, 2025
Merged
Closed
@atiratree atiratree mentioned this pull request Nov 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh soltysh approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG Apps
Archived in project

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

3 participants

@ahmetb @soltysh @k8s-ci-robot