SVM: bump the API to beta, remove unused fields by michaelasp · Pull Request #134784 · kubernetes/kubernetes

michaelasp · 2025-10-22T17:22:52Z

What type of PR is this?

/kind feature /kind api-change

What this PR does / why we need it:

This PR bumps the SVM API to beta and removes the StorageVersionMigration object's fields as discussed in kubernetes/enhancements#5597, follow up to #134480

Which issue(s) this PR is related to:

KEP: kubernetes/enhancements#4192

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add StorageVersionMigration v1beta1 api and remove the v1alpha API. 

Action required: Any use of the v1alpha1 api is no longer supported and 
users must remove any v1alpha1 resources prior to upgrade.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

KEP: KEP: https://github.com/kubernetes/enhancements/issues/4192

k8s-ci-robot · 2025-10-22T17:22:57Z

@michaelasp: The label(s) kind//kind cannot be applied, because the repository doesn't have them.

Details

In response to this:

What type of PR is this?

/kind feature /kind api-change

What this PR does / why we need it:

This PR bumps the SVM API to beta and removes the StorageVersionMigration object's fields as discussed in kubernetes/enhancements#5597, follow up to #134480

Which issue(s) this PR is related to:

KEP: kubernetes/enhancements#4192

Special notes for your reviewer:

Does this PR introduce a user-facing change?
Add StorageVersionMigration v1beta1 api
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
KEP: KEP: https://github.com/kubernetes/enhancements/issues/4192

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-10-22T17:23:02Z

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

michaelasp · 2025-10-22T17:23:18Z

/sig api-machinery

k8s-triage-robot · 2025-10-22T19:11:56Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

michaelasp · 2025-10-22T21:21:12Z

/cc @enj
/cc @jpbetz

enj

Second pass.

enj · 2025-10-29T14:00:32Z

 		for monitorGVR, m := range gb.monitors {
-			if monitorGVR.Group == resource.Group && monitorGVR.Resource == resource.Resource {
+			if monitorGVR.Group == resource.Group &&
+				monitorGVR.Resource == resource.Resource &&
+				monitorGVR.Version == resource.Version {
 				monitor = m
 				break
 			}
 		}
 	}

 	if monitor == nil {
-		return nil, fmt.Errorf("no monitor found for resource %s", resource.String())
+		return nil, false, fmt.Errorf("no monitor found for resource %s", resource.String())
 	}


Delete the var and loop altogether:

monitor, ok := gb.monitors[resource] if !ok { return nil, false, fmt.Errorf("no monitor found for resource %s", resource.String()) }

Ah yeah, missed that. At this point we know the exact gvr.

enj · 2025-10-29T14:01:44Z

 		// returning monitor to allow the caller to decide whether to retry as it can be synced later
-		return resourceMonitor, fmt.Errorf("dependency graph for resource %s is not synced", resource.String())
+		return resourceMonitor, false, nil


Just return nil, false, nil here and drop the comment.

Good catch.

enj · 2025-10-29T14:13:15Z

+	if err != nil || cmp != 0 {
 		allErrs = append(allErrs, field.Invalid(fldPath.Child("resourceVersion"), newSVMBundle.Status.ResourceVersion, err.Error()))


This will now panic if err == nil

Ah yeah, this is a weird error, create an error if one doesn't exist.

enj

Last thing.

enj · 2025-10-29T18:48:00Z

-		allErrs = append(allErrs, field.Invalid(field.NewPath("resource"), newSVMBundle.Spec.Resource.Resource, "field is immutable"))
-	}
+	// prevent changes to the spec
+	allErrs = append(allErrs, apivalidation.ValidateImmutableField(oldSVMBundle.Spec, newSVMBundle.Spec, field.NewPath("spec"))...)


So the error message returned is correct:

Suggested change

allErrs = append(allErrs, apivalidation.ValidateImmutableField(oldSVMBundle.Spec, newSVMBundle.Spec, field.NewPath("spec"))...)

allErrs = append(allErrs, apivalidation.ValidateImmutableField(newSVMBundle.Spec, oldSVMBundle.Spec, field.NewPath("spec"))...)

linux-foundation-easycla · 2025-10-29T19:10:23Z

The committers listed above are authorized under a signed CLA.

✅ login: michaelasp / name: Michael Aspinwall (3b72759)

Co-authored-by: Stanislav Láznička <[email protected]>

k8s-ci-robot · 2025-10-29T19:39:12Z

@michaelasp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-apidiff-client-go	`3b72759`	link	false	`/test pull-kubernetes-apidiff-client-go`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

enj · 2025-10-29T19:57:03Z

/lgtm
/approve

k8s-ci-robot · 2025-10-29T19:57:11Z

LGTM label has been added.

Details

Git tree hash: fd7f132701bf987b60a405f3f8879ceff3e0162e

liggitt · 2025-10-29T20:55:24Z

/lgtm
/approve

k8s-ci-robot · 2025-10-29T20:55:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, liggitt, michaelasp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~api/OWNERS~~ [liggitt]
~~cmd/kube-controller-manager/OWNERS~~ [liggitt]
~~hack/OWNERS~~ [enj,liggitt]
~~pkg/apis/OWNERS~~ [liggitt]
~~pkg/controller/garbagecollector/OWNERS~~ [liggitt]
~~pkg/controller/storageversionmigrator/OWNERS~~ [enj,liggitt]
~~pkg/controlplane/OWNERS~~ [liggitt]
~~pkg/features/OWNERS~~ [enj,liggitt]
~~pkg/generated/openapi/OWNERS~~ [liggitt]
~~pkg/kubeapiserver/OWNERS~~ [liggitt]
~~pkg/printers/OWNERS~~ [liggitt]
~~pkg/registry/OWNERS~~ [liggitt]
~~plugin/pkg/auth/authorizer/OWNERS~~ [liggitt]
~~staging/src/k8s.io/api/OWNERS~~ [liggitt]
~~staging/src/k8s.io/client-go/OWNERS~~ [liggitt]
~~test/OWNERS~~ [enj,liggitt]
~~test/compatibility_lifecycle/reference/OWNERS~~ [enj,liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 22, 2025

k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 22, 2025

k8s-ci-robot requested review from aojea and apelisse October 22, 2025 17:23

github-project-automation Bot added this to SIG Apps Oct 22, 2025

github-project-automation Bot moved this to Needs Triage in SIG Apps Oct 22, 2025

michaelasp force-pushed the svm_beta2 branch 2 times, most recently from 563a796 to daf0351 Compare October 22, 2025 18:10

michaelasp force-pushed the svm_beta2 branch 2 times, most recently from d15fca7 to 1211458 Compare October 22, 2025 21:17

k8s-ci-robot requested a review from enj October 22, 2025 21:21

liggitt reviewed Oct 28, 2025

View reviewed changes

Comment thread pkg/printers/internalversion/printers.go Outdated

liggitt reviewed Oct 28, 2025

View reviewed changes

Comment thread pkg/printers/internalversion/printers.go Outdated

Comment thread pkg/controller/garbagecollector/graph_builder.go Outdated

Comment thread pkg/apis/storagemigration/types.go

michaelasp force-pushed the svm_beta2 branch from 0c8f3ba to 1771611 Compare October 28, 2025 21:31

liggitt reviewed Oct 28, 2025

View reviewed changes

Comment thread pkg/printers/internalversion/printers.go Outdated

Comment thread pkg/printers/internalversion/printers.go Outdated

michaelasp force-pushed the svm_beta2 branch from 1771611 to 3163826 Compare October 28, 2025 21:53

enj suggested changes Oct 29, 2025

View reviewed changes

michaelasp force-pushed the svm_beta2 branch 4 times, most recently from ddaf542 to e66dd9d Compare October 29, 2025 18:52

enj suggested changes Oct 29, 2025

View reviewed changes

michaelasp force-pushed the svm_beta2 branch 3 times, most recently from 1b55e97 to 218635f Compare October 29, 2025 19:10

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 29, 2025

michaelasp force-pushed the svm_beta2 branch from 218635f to 89a4e25 Compare October 29, 2025 19:35

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 29, 2025

Update SVM to Beta

3b72759

Co-authored-by: Stanislav Láznička <[email protected]>

michaelasp force-pushed the svm_beta2 branch from 89a4e25 to 3b72759 Compare October 29, 2025 19:36

k8s-ci-robot assigned enj Oct 29, 2025

enj mentioned this pull request Nov 7, 2025

Move Storage Version Migrator in-tree kubernetes/enhancements#4192

Open

28 tasks

DmitriyLewen mentioned this pull request Jan 19, 2026

chore(deps): bump the common group across 1 directory with 19 updates aquasecurity/trivy#10050

Closed

		if err != nil \|\| cmp != 0 {
		allErrs = append(allErrs, field.Invalid(fldPath.Child("resourceVersion"), newSVMBundle.Status.ResourceVersion, err.Error()))

	allErrs = append(allErrs, apivalidation.ValidateImmutableField(oldSVMBundle.Spec, newSVMBundle.Spec, field.NewPath("spec"))...)
	allErrs = append(allErrs, apivalidation.ValidateImmutableField(newSVMBundle.Spec, oldSVMBundle.Spec, field.NewPath("spec"))...)

Conversation

michaelasp commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Oct 22, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Oct 22, 2025

Uh oh!

michaelasp commented Oct 22, 2025

Uh oh!

k8s-triage-robot commented Oct 22, 2025

Uh oh!

michaelasp commented Oct 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

enj left a comment

Choose a reason for hiding this comment

Uh oh!

enj Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

michaelasp Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

enj Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

michaelasp Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

enj Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

michaelasp Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

enj left a comment

Choose a reason for hiding this comment

Uh oh!

enj Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

linux-foundation-easycla Bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

enj commented Oct 29, 2025

Uh oh!

k8s-ci-robot commented Oct 29, 2025

Uh oh!

liggitt commented Oct 29, 2025

Uh oh!

k8s-ci-robot commented Oct 29, 2025

Uh oh!

Reviewers

michaelasp commented Oct 22, 2025 •

edited

Loading

linux-foundation-easycla Bot commented Oct 29, 2025 •

edited

Loading

k8s-ci-robot commented Oct 29, 2025 •

edited

Loading