KEP-5471: Extend tolerations operators by helayoty · Pull Request #134665 · kubernetes/kubernetes

helayoty · 2025-10-16T21:17:19Z

What type of PR is this?

Extend tolerations operators by adding Gt and Lt

/kind feature
/sig scheduling
/stage alpha

What this PR does / why we need it:

Implementation Details

New Operators:
- TolerationOpGt: Pod tolerates taint if taint value > toleration value (Gt)
- TolerationOpLt: Pod tolerates taint if taint value < toleration value (Lt)
Value Validation:
- Toleration values must be valid decimal integers, no leading zero.
- A new IsDecimalInteger content validation function (staging/src/k8s.io/apimachinery/pkg/api/validate/content/decimal_int.go) enforces strict canonical form:
  - Rejects leading zeros (e.g., "0700", "01") to avoid octal notation confusion
  - Rejects plus signs (e.g., "+123")
  - Rejects floating point numbers, whitespace, and non-numeric characters
  - Stricter than strconv.ParseInt to ensure human-readable canonical representation
- Invalid values is logged as errors in the toleration not matching
Feature Gate:
- TaintTolerationComparisonOperators
Function Signature Changes:
- Logger parameter added to ToleratesTaint
- Updated across all call sites: scheduler plugin, taint eviction controller, daemon controller, admission controllers, and test utilities.
Testing:
- Integration tests
  - TestTaintTolerationGtLtIntegration
  - Add new test cases for Filter tests
- e2e tests
  - Updated test/e2e/framework/node/resource.go to support logger parameter in helper functions. For Alpha, the feature gate will be passed to ToleratesTaint as false in the e2e.

Which issue(s) this PR is related to:

Fixes #118669
KEP: kubernetes/enhancements#5471

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Extend `core/v1 Toleration` to support numeric comparison operators (`Gt`, `Lt`).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

helayoty · 2025-10-16T21:18:38Z

/assign @sanposhiho @macsko @dom4ha

k8s-triage-robot · 2025-10-16T23:20:03Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

macsko

Initial pass

sanposhiho · 2025-11-10T19:35:24Z

/milestone v1.35

Signed-off-by: Heba Elayoty <[email protected]>

Signed-off-by: helayoty <[email protected]>

Signed-off-by: Heba Elayoty <[email protected]> Signed-off-by: helayoty <[email protected]>

Signed-off-by: helayoty <[email protected]>

helayoty · 2025-11-10T19:48:02Z

/label tide/merge-method-squash

sanposhiho · 2025-11-10T19:53:34Z

/lgtm
/approve

just rebase

k8s-ci-robot · 2025-11-10T19:53:41Z

LGTM label has been added.

Details

Git tree hash: 1e752e44f48bad8174c7cba97cda6652b9465d01

k8s-ci-robot · 2025-11-10T19:53:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: helayoty, sanposhiho, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~api/OWNERS~~ [thockin]
~~pkg/OWNERS~~ [thockin]
~~pkg/api/OWNERS~~ [thockin]
~~pkg/apis/OWNERS~~ [thockin]
~~plugin/pkg/admission/OWNERS~~ [thockin]
~~staging/src/k8s.io/api/OWNERS~~ [thockin]
~~staging/src/k8s.io/apimachinery/pkg/OWNERS~~ [thockin]
~~staging/src/k8s.io/client-go/applyconfigurations/OWNERS~~ [thockin]
~~staging/src/k8s.io/component-helpers/scheduling/OWNERS~~ [sanposhiho,thockin]
~~test/compatibility_lifecycle/reference/OWNERS~~ [sanposhiho,thockin]
~~test/e2e/common/OWNERS~~ [thockin]
~~test/e2e/framework/OWNERS~~ [thockin]
~~test/e2e/windows/OWNERS~~ [thockin]
~~test/e2e_node/OWNERS~~ [thockin]
~~test/integration/scheduler/OWNERS~~ [sanposhiho,thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

RainbowMango · 2026-01-29T07:06:54Z

+//     between toleration.value and taint.value.
+//  5. If enableComparisonOperators is false and the toleration uses 'Lt' or 'Gt'
+//     operators, the toleration does not match (returns false).
+func (t *Toleration) ToleratesTaint(logger klog.Logger, taint *Taint, enableComparisonOperators bool) bool {


Though this PR is merged, I'd like to raise a concern about the logger parameter.

As an API helper method in core/v1, ToleratesTaint() should return errors and let callers decide how to handle them, rather than logging internally. This approach pollutes the API layer with logging dependencies and prevents callers from handling validation errors appropriately.

In addition, many projects in the CNCF ecosystem consume Kubernetes APIs but may use different logging frameworks or error handling strategies.

@helayoty Great, thanks for your effort on this feature. I read the KEP, and it makes a lot of sense.

Also, cc @thockin, love to hear your thoughts.

github-project-automation Bot added this to SIG Scheduling Oct 16, 2025

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 16, 2025

helayoty moved this to Needs Review in SIG Scheduling Oct 16, 2025

k8s-ci-robot added area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Oct 16, 2025

github-project-automation Bot added this to SIG Apps Oct 16, 2025

github-project-automation Bot moved this to Needs Triage in SIG Apps Oct 16, 2025

k8s-ci-robot requested review from damemi and dims October 16, 2025 21:17

k8s-ci-robot assigned dom4ha, macsko and sanposhiho Oct 16, 2025

helayoty force-pushed the helayoty/5471-extend-tolerations branch from f266a32 to b30feec Compare October 16, 2025 21:24

k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Oct 16, 2025

helayoty mentioned this pull request Oct 16, 2025

Extended Toleration Operators for Threshold-Based Placement kubernetes/enhancements#5471

Open

7 tasks

helayoty force-pushed the helayoty/5471-extend-tolerations branch 2 times, most recently from e22e188 to f7f3bd1 Compare October 16, 2025 22:21

helayoty force-pushed the helayoty/5471-extend-tolerations branch from f7f3bd1 to cc1217b Compare October 17, 2025 00:08

helayoty moved this from Needs Triage to Backlog in SIG Apps Oct 17, 2025

macsko reviewed Oct 17, 2025

View reviewed changes

Comment thread staging/src/k8s.io/api/core/v1/toleration.go

Comment thread pkg/apis/core/types.go

Comment thread pkg/features/kube_features.go Outdated

Comment thread staging/src/k8s.io/api/core/v1/toleration.go

helayoty mentioned this pull request Nov 10, 2025

[KEP-5471]: Return errors for filter plugin and ignore it for score #135243

Open

helayoty added 17 commits November 10, 2025 19:45

Add numeric operations to tolerations

1d97fff

Signed-off-by: Heba Elayoty <[email protected]>

code review feedback

8a83ddb

Signed-off-by: Heba Elayoty <[email protected]>

add default feature gate

d26d539

Signed-off-by: Heba Elayoty <[email protected]>

Add integration tests

48647e4

Signed-off-by: Heba Elayoty <[email protected]>

Add toleration value validation

7eea8c4

Signed-off-by: Heba Elayoty <[email protected]>

Add validate options for new operators

d810ce2

Signed-off-by: helayoty <[email protected]>

Remove log

26d8a7b

Signed-off-by: helayoty <[email protected]>

Update feature gate check

d294e57

Signed-off-by: helayoty <[email protected]>

emove IsValidNumericString func

7704009

Signed-off-by: helayoty <[email protected]>

Implement IsDecimalInteger

f3e7f45

Signed-off-by: helayoty <[email protected]>

code review feedback

616a044

Signed-off-by: helayoty <[email protected]>

Add logs to v1/toleration

19c6083

Signed-off-by: Heba Elayoty <[email protected]> Signed-off-by: helayoty <[email protected]>

Update integration tests and address code review feedback

70c1def

Signed-off-by: helayoty <[email protected]>

Add feature gate to the scheduler framework

7d6a59c

Signed-off-by: helayoty <[email protected]>

Remove extra test

186a491

Signed-off-by: helayoty <[email protected]>

Fix integration test

63db177

Signed-off-by: helayoty <[email protected]>

pass feature gate via TolerationsTolerateTaint

ba5762e

Signed-off-by: helayoty <[email protected]>

sbueringer mentioned this pull request Nov 21, 2025

Taints Propagation Proposal implementation kubernetes-sigs/cluster-api#12908

Open

22 tasks

RainbowMango mentioned this pull request Jan 29, 2026

[Umbrella] Bump Kubernetes dependency from v1.34 to v1.35 karmada-io/karmada#7140

Open

19 tasks

RainbowMango reviewed Jan 29, 2026

View reviewed changes

renovate Bot mentioned this pull request Mar 17, 2026

Update all dependencies MaibornWolff/hybrid-cloud-object-storage-operator#28

Merged

1 task

renovate Bot mentioned this pull request Mar 27, 2026

fix(deps): update python dependencies (major) canonical/mongodb-k8s-operator#483

Open

1 task

hypershift-jira-solve-ci Bot mentioned this pull request Apr 17, 2026

build(deps): bump the k8s-dependencies group across 1 directory with 13 updates openshift/hypershift#7950

Closed

coderabbitai Bot mentioned this pull request Apr 20, 2026

Bumping deps to avoid CVE (19/04/2026) noobaa/noobaa-operator#1882

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KEP-5471: Extend tolerations operators#134665

KEP-5471: Extend tolerations operators#134665
k8s-ci-robot merged 17 commits intokubernetes:masterfrom
helayoty:helayoty/5471-extend-tolerations

helayoty commented Oct 16, 2025 •

edited

Loading

Uh oh!

helayoty commented Oct 16, 2025 •

edited

Loading

Uh oh!

k8s-triage-robot commented Oct 16, 2025

Uh oh!

macsko left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sanposhiho commented Nov 10, 2025

Uh oh!

helayoty commented Nov 10, 2025

Uh oh!

sanposhiho commented Nov 10, 2025

Uh oh!

k8s-ci-robot commented Nov 10, 2025

Uh oh!

k8s-ci-robot commented Nov 10, 2025

Uh oh!

RainbowMango Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Conversation

helayoty commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

helayoty commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-triage-robot commented Oct 16, 2025

Uh oh!

macsko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sanposhiho commented Nov 10, 2025

Uh oh!

helayoty commented Nov 10, 2025

Uh oh!

sanposhiho commented Nov 10, 2025

Uh oh!

k8s-ci-robot commented Nov 10, 2025

Uh oh!

k8s-ci-robot commented Nov 10, 2025

Uh oh!

RainbowMango Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

helayoty commented Oct 16, 2025 •

edited

Loading

helayoty commented Oct 16, 2025 •

edited

Loading