Skip to content

SVM: bump the API to beta, remove unused fields#134480

Closed
stlaz wants to merge 4 commits intokubernetes:masterfrom
stlaz:svm_beta
Closed

SVM: bump the API to beta, remove unused fields#134480
stlaz wants to merge 4 commits intokubernetes:masterfrom
stlaz:svm_beta

Conversation

@stlaz
Copy link
Copy Markdown
Member

@stlaz stlaz commented Oct 8, 2025

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

This PR bumps the SVM API to beta and removes the StorageVersionMigration object's fields as discussed in kubernetes/enhancements#5597

Which issue(s) this PR is related to:

Related-to: kubernetes/enhancements#4192

Special notes for your reviewer:

Does this PR introduce a user-facing change?

TBD

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: github.com/kubernetes/enhancements/issues/4192

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 8, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 8, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 8, 2025
@k8s-ci-robot k8s-ci-robot requested review from cici37 and enj October 8, 2025 14:45
@k8s-ci-robot k8s-ci-robot added area/apiserver area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 8, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Apps Oct 8, 2025
@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Oct 8, 2025

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@michaelasp
Copy link
Copy Markdown
Contributor

michaelasp commented Oct 8, 2025

/cc @michaelasp

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 9, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stlaz
Once this PR has been reviewed and has the lgtm label, please assign deads2k, soltysh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stlaz stlaz force-pushed the svm_beta branch 2 times, most recently from ef3a785 to d73a7ea Compare October 9, 2025 12:28
stlaz added 2 commits October 9, 2025 14:33
@stlaz
svm: copy the SVM API to v1beta1
5f21106 
Signed-off-by: Stanislav Láznička <[email protected]>
@stlaz
SVM: use the beta API
1b61b42 
Signed-off-by: Stanislav Láznička <[email protected]>
stlaz added 2 commits October 9, 2025 14:33
@stlaz
storagemigration: remove unnecessary fields from the SVM API
a6d088d 
Signed-off-by: Stanislav Láznička <[email protected]>
@stlaz
make update
998e461 
Signed-off-by: Stanislav Láznička <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 9, 2025

@stlaz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-apidiff-client-go 998e461 link false /test pull-kubernetes-apidiff-client-go
pull-kubernetes-integration 998e461 link true /test pull-kubernetes-integration
pull-kubernetes-verify 998e461 link true /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

This was referenced Oct 22, 2025
Merged
Closed
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 25, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stlaz
Copy link
Copy Markdown
Member Author

stlaz commented Oct 27, 2025

/close
superseded by #134784

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 27, 2025

@stlaz: Closed this PR.

Details

In response to this:

/close
superseded by #134784

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation Bot moved this from Needs Triage to Closed in SIG Apps Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cici37 cici37 Awaiting requested review from cici37

@enj enj Awaiting requested review from enj

@michaelasp michaelasp Awaiting requested review from michaelasp

Assignees

No one assigned

Labels

area/apiserver area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

SIG Apps
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stlaz @k8s-ci-robot @k8s-triage-robot @michaelasp @benjaminapetersen