Skip to content

gogo protobuf interface cleanup#134228

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
liggitt:proto-gogo-poc
Sep 23, 2025
Merged

gogo protobuf interface cleanup#134228
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
liggitt:proto-gogo-poc

Conversation

@liggitt
Copy link
Copy Markdown
Member

@liggitt liggitt commented Sep 23, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

Starts cleaning up and isolating references to gogo protobuf packages.

This redefines the narrow subset of methods we rely on in local interfaces, and removes all references to gogo packages outside generated code.

Which issue(s) this PR is related to:

#96564

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Sep 23, 2025
@liggitt liggitt changed the title WIP - gogo protobuf WIP - gogo protobuf cleanup Sep 23, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 23, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 23, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 23, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2025
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Sep 23, 2025
@liggitt liggitt changed the title WIP - gogo protobuf cleanup gogo protobuf dependency cleanup Sep 23, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2025
@dims
Copy link
Copy Markdown
Member

dims commented Sep 23, 2025

/approve
/lgtm

/hold if you need additional reviewers! please remove hold when ready.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 23, 2025

LGTM label has been added.

DetailsGit tree hash: 94c97810e99594ab7f7ff023388793295726d05c

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Sep 23, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1a04a95 into kubernetes:master Sep 23, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Sep 23, 2025
@liggitt liggitt mentioned this pull request Sep 25, 2025
Merged
@liggitt liggitt changed the title gogo protobuf dependency cleanup gogo protobuf interface cleanup Sep 29, 2025
@liggitt liggitt mentioned this pull request Sep 30, 2025
Open
16 tasks
@liggitt liggitt deleted the proto-gogo-poc branch March 11, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apelisse apelisse Awaiting requested review from apelisse

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@dims dims

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

[sig-architecture] Dependency management
Status: Done

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

4 participants

@liggitt @k8s-ci-robot @dims @benjaminapetersen