Skip to content

Updates to DRA Partitionable Devices feature#134189

Merged
k8s-ci-robot merged 8 commits intokubernetes:masterfrom
mortent:NewUpdatePartitionableDevices
Nov 7, 2025
Merged

Updates to DRA Partitionable Devices feature#134189
k8s-ci-robot merged 8 commits intokubernetes:masterfrom
mortent:NewUpdatePartitionableDevices

Conversation

@mortent
Copy link
Copy Markdown
Member

@mortent mortent commented Sep 21, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR updates the Partitionable Devices feature according to the changes described in kubernetes/enhancements#5515

Which issue(s) this PR is related to:

Related-to: kubernetes/enhancements#4815

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Updates to the Partitionable Devices feature which allows for referencing counter sets across different ResourceSlices within the same resource pool.

Devices from incomplete pools are no longer considered for allocation.

This contains backwards incompatible changes to the Partitionable Devices alpha feature, so any ResourceSlices that uses the feature should be removed prior to upgrading or downgrading between 1.34 and 1.35.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 21, 2025
@pohly pohly moved this from 🆕 New to 🏗 In progress in Dynamic Resource Allocation Sep 22, 2025
@mortent mortent force-pushed the NewUpdatePartitionableDevices branch from d3f24a4 to 6822f6c Compare September 23, 2025 01:39
@haircommander haircommander moved this from Triage to Archive-it in SIG Node CI/Test Board Sep 24, 2025
@mortent mortent force-pushed the NewUpdatePartitionableDevices branch from 6822f6c to b890ff0 Compare September 28, 2025 21:48
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2025
@mortent mortent force-pushed the NewUpdatePartitionableDevices branch from b890ff0 to e953585 Compare October 4, 2025 21:39
aaron-prindle
aaron-prindle reviewed Nov 6, 2025
View reviewed changes
Comment thread pkg/apis/resource/validation/validation.go Outdated
aaron-prindle
aaron-prindle reviewed Nov 6, 2025
View reviewed changes
Comment thread pkg/apis/resource/validation/validation.go Outdated
aaron-prindle
aaron-prindle reviewed Nov 6, 2025
View reviewed changes
Comment thread pkg/apis/resource/validation/validation_resourceslice_test.go Outdated
aaron-prindle
aaron-prindle reviewed Nov 6, 2025
View reviewed changes
Comment thread pkg/apis/resource/validation/validation_resourceslice_test.go Outdated
@mortent
Copy link
Copy Markdown
Member Author

mortent commented Nov 6, 2025

/test pull-kubernetes-unit

@mortent
Copy link
Copy Markdown
Member Author

mortent commented Nov 6, 2025

/test pull-kubernetes-node-e2e-containerd
/test pull-kubernetes-e2e-kind

pohly
pohly approved these changes Nov 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DRA parts look good to me, doc comment needs one minor update.

/approve

Comment thread pkg/apis/resource/types.go
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Nov 6, 2025

lgtm as well, will let @aaron-prindle check off the updates from his last review and get the doc comment tweaked, then can tag for merge

@mortent
Copy link
Copy Markdown
Member Author

mortent commented Nov 6, 2025

I have fixed the doc comment so I think we only need @aaron-prindle to check the DV fixes.

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Nov 6, 2025

/lgtm
/approve
/hold for @aaron-prindle ack

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 6, 2025

LGTM label has been added.

DetailsGit tree hash: d5fccee5c3e6ee8ddd55a816f1bc1ca3a4100a64

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mortent, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aaron-prindle
Copy link
Copy Markdown
Contributor

aaron-prindle commented Nov 6, 2025

DV changes LGTM
/lgtm

@mortent
Copy link
Copy Markdown
Member Author

mortent commented Nov 6, 2025

/test pull-kubernetes-kind-dra-all

Flake reported in #135177

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Nov 6, 2025

/hold cancel

@mortent
Copy link
Copy Markdown
Member Author

mortent commented Nov 6, 2025

/test pull-kubernetes-kind-dra-all
Same flake as before

@mortent
Copy link
Copy Markdown
Member Author

mortent commented Nov 6, 2025

/test pull-kubernetes-kind-dra-all

#135182 has merged.

@mortent
Copy link
Copy Markdown
Member Author

mortent commented Nov 6, 2025

@pohly @liggitt There was a conflict, so I had to rebase. Can one of you re-add the lgtm?

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Nov 6, 2025

looks like typecheck still needs fixup

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Nov 6, 2025

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 6, 2025

LGTM label has been added.

DetailsGit tree hash: 54bd15c88eaa7c5f5420a1668a633e1f988c0738

@lalitc375 lalitc375 mentioned this pull request Jan 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bart0sh bart0sh Awaiting requested review from bart0sh

@klueska klueska Awaiting requested review from klueska

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@aaron-prindle aaron-prindle Awaiting requested review from aaron-prindle

@liggitt liggitt Awaiting requested review from liggitt

@pohly pohly Awaiting requested review from pohly

Assignees

@pohly pohly

@liggitt liggitt

@aaron-prindle aaron-prindle

@johnbelamaric johnbelamaric

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.

Projects

API Reviews
Status: API review completed, 1.35
Dynamic Resource Allocation
Status: ✅ Done
SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project
SIG Scheduling
Archived in project

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.