Skip to content

[KEP-4330] add min-compatibility-version to control plane.#133980

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
siyuanfoundation:min-compat
Oct 30, 2025
Merged

[KEP-4330] add min-compatibility-version to control plane.#133980
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
siyuanfoundation:min-compat

Conversation

@siyuanfoundation
Copy link
Copy Markdown
Contributor

@siyuanfoundation siyuanfoundation commented Sep 9, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adding the --min-compatibility-version part of KEP-4330

The biggest change is adding MinCompatibilityVersion field in feature spec, which allows setting the feature at different stages based on the server --min-compatibility-version. The usage of MinCompatibilityVersion for CEL and storage version is already in place.

This PR also exposes the --min-compatibility-version flag in apiserver, kcm and scheduler.

The MinCompatibilityVersion feature unlocks the option to accelerate the adoption of some features that can be accelerated if there is no backward compatibility concerns.

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added a new `--min-compatibility-version` command line setting for kube-apiserver, kube-controller-manager and kube-scheduler.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/4330

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 9, 2025
@k8s-ci-robot k8s-ci-robot added area/apiserver area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 9, 2025
@siyuanfoundation
Copy link
Copy Markdown
Contributor Author

siyuanfoundation commented Sep 9, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 9, 2025
@siyuanfoundation siyuanfoundation force-pushed the min-compat branch 3 times, most recently from feb91e9 to a8ba894 Compare September 24, 2025 15:37
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Sep 24, 2025
@siyuanfoundation siyuanfoundation force-pushed the min-compat branch 3 times, most recently from 64143b9 to ff3b786 Compare September 25, 2025 17:28
@siyuanfoundation
Copy link
Copy Markdown
Contributor Author

siyuanfoundation commented Oct 23, 2025

/cc @jpbetz @Jefftree

@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Oct 23, 2025

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@siyuanfoundation
Copy link
Copy Markdown
Contributor Author

siyuanfoundation commented Oct 23, 2025

/cc @liggitt @deads2k

@k8s-ci-robot k8s-ci-robot requested a review from liggitt October 23, 2025 19:25
@aaron-prindle
Copy link
Copy Markdown
Contributor

aaron-prindle commented Oct 23, 2025

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 23, 2025
@siyuanfoundation
Copy link
Copy Markdown
Contributor Author

siyuanfoundation commented Oct 23, 2025

/remove-sig etcd

@k8s-ci-robot k8s-ci-robot removed the sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. label Oct 23, 2025
@siyuanfoundation
Copy link
Copy Markdown
Contributor Author

siyuanfoundation commented Oct 23, 2025

/remove-kind api-change
/remove-sig scheduling

@k8s-ci-robot k8s-ci-robot removed kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Oct 23, 2025
@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Oct 24, 2025
liggitt
liggitt reviewed Oct 29, 2025
View reviewed changes
Comment thread staging/src/k8s.io/component-base/featuregate/feature_gate.go Outdated
Comment thread staging/src/k8s.io/component-base/featuregate/feature_gate.go
liggitt
liggitt reviewed Oct 30, 2025
View reviewed changes
Comment thread staging/src/k8s.io/component-base/featuregate/feature_gate.go
Comment thread staging/src/k8s.io/component-base/featuregate/feature_gate.go Outdated
Comment thread staging/src/k8s.io/component-base/featuregate/feature_gate.go Outdated
Comment thread staging/src/k8s.io/component-base/featuregate/feature_gate.go Outdated
Comment thread staging/src/k8s.io/component-base/featuregate/feature_gate.go Outdated
Comment thread staging/src/k8s.io/component-base/featuregate/feature_gate.go Outdated
liggitt
liggitt reviewed Oct 30, 2025
View reviewed changes
Comment thread staging/src/k8s.io/component-base/featuregate/feature_gate.go Outdated
liggitt
liggitt reviewed Oct 30, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

one doc suggestion, lgtm otherwise

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@siyuanfoundation
Add --min-compatibility flag.
6714302 
Signed-off-by: Siyuan Zhang <[email protected]>
@siyuanfoundation
Copy link
Copy Markdown
Contributor Author

siyuanfoundation commented Oct 30, 2025

/cc @sttts

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Oct 30, 2025

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 30, 2025

LGTM label has been added.

DetailsGit tree hash: 7a00c3a119eee72d1a787749c0a14912401e9c5b

@liggitt liggitt mentioned this pull request Oct 30, 2025
Merged
@lmktfy
Copy link
Copy Markdown
Member

lmktfy commented Nov 22, 2025

Changelog tweak (suggested)

-new `--min-compatibility-version` flag for apiserver, kcm and kube schedule
+Added a new `--min-compatibility-version` command line setting for kube-apiserver, kube-controller-manager and kube-scheduler.

@siyuanfoundation
Copy link
Copy Markdown
Contributor Author

siyuanfoundation commented Nov 24, 2025

Changelog tweak (suggested)

-new `--min-compatibility-version` flag for apiserver, kcm and kube schedule
+Added a new `--min-compatibility-version` command line setting for kube-apiserver, kube-controller-manager and kube-scheduler.

Updated PR description. Thanks for the suggestion!

This was referenced Mar 25, 2026
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt liggitt left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@deads2k deads2k Awaiting requested review from deads2k

@cici37 cici37 Awaiting requested review from cici37

@damemi damemi Awaiting requested review from damemi

@Jefftree Jefftree Awaiting requested review from Jefftree

@jpbetz jpbetz Awaiting requested review from jpbetz

@sttts sttts Awaiting requested review from sttts

Assignees

@liggitt liggitt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG Scheduling
Archived in project

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

7 participants

@siyuanfoundation @k8s-ci-robot @k8s-triage-robot @aaron-prindle @liggitt @lmktfy @benjaminapetersen