Skip to content

Remove deprecated pod-infra-container-image flag#133779

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
carlory:kubelet-cleanup-pod-infra-container-image
Oct 31, 2025
Merged

Remove deprecated pod-infra-container-image flag#133779
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
carlory:kubelet-cleanup-pod-infra-container-image

Conversation

@carlory
Copy link
Copy Markdown
Member

@carlory carlory commented Aug 29, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

A follow up of #133108

Which issue(s) this PR is related to:

Fixes #106893

Special notes for your reviewer:

Does this PR introduce a user-facing change?

ACTION REQUIRED:

Removed the `--pod-infra-container-image` flag from kubelet's command line. For non-kubeadm clusters, users must manually remove this flag from their kubelet configuration to prevent startup failures before they upgrade kubelet. For kubeadm clusters, If user passes through extra arguments to the kubelet like `--pod-infra-container-image`, it will be written to the kubelet env file during the init phase. kubeadm won't remove it in the init/join phase, so users need to remove it manually from extraArgs in the kubelet configuration file.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 29, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 29, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 29, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 29, 2025
@carlory carlory mentioned this pull request Aug 29, 2025
Closed
@carlory
Copy link
Copy Markdown
Member Author

carlory commented Aug 29, 2025

/cc @HirazawaUi @pacoxu @neolit123

@bart0sh bart0sh moved this from Triage to Work in progress in SIG Node: code and documentation PRs Sep 2, 2025
@SergeyKanzhelev
Copy link
Copy Markdown
Member

SergeyKanzhelev commented Sep 2, 2025

is it still WIP because of kubeadm work needed?

@carlory
Copy link
Copy Markdown
Member Author

carlory commented Sep 11, 2025

is it still WIP because of kubeadm work needed?

Yes.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2025
@carlory carlory force-pushed the kubelet-cleanup-pod-infra-container-image branch from e1bce0a to e6b0226 Compare October 11, 2025 02:41
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2025
@carlory carlory force-pushed the kubelet-cleanup-pod-infra-container-image branch from e6b0226 to dc686f2 Compare October 11, 2025 02:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2025
@k8s-ci-robot k8s-ci-robot requested a review from kannon92 October 11, 2025 02:58
@carlory
Copy link
Copy Markdown
Member Author

carlory commented Oct 11, 2025

/test pull-kubernetes-e2e-kind

@hakman hakman mentioned this pull request Oct 11, 2025
Merged
@yankay yankay mentioned this pull request Oct 13, 2025
Closed
@zylxjtu zylxjtu mentioned this pull request Oct 13, 2025
Closed
@mboersma mboersma mentioned this pull request Oct 14, 2025
Merged
@HirazawaUi
Copy link
Copy Markdown
Contributor

HirazawaUi commented Oct 14, 2025

I see that some projects are still referencing this parameter (maintainers of other projects have already cited the link to this PR in issues or pull requests). Can we safely remove it in v1.35? If we remove it now, could it cause their services to become unavailable?

@hakman
Copy link
Copy Markdown
Member

hakman commented Oct 14, 2025

I see that some projects are still referencing this parameter (maintainers of other projects have already cited the link to this PR in issues or pull requests). Can we safely remove it in v1.35? If we remove it now, could it cause their services to become unavailable?

My guess is that people test before new project releases.
Sure, a project release made for K8s 1.34 may not work with K8s 1.35, nothing new. The next project release will support K8s 1.35 and remove the flag.
Removing the flag sooner rather than later in the cycle may also help.

@carlory
Copy link
Copy Markdown
Member Author

carlory commented Oct 15, 2025

I see that some projects are still referencing this parameter (maintainers of other projects have already cited the link to this PR in issues or pull requests). Can we safely remove it in v1.35?

I have sent a message via Slack to maintainers of the related project. https://cs.k8s.io/?q=--pod-infra-container-image&i=nope&literal=nope&files=&excludeFiles

@sriramandev sriramandev mentioned this pull request Oct 17, 2025
Closed
@carlory
Copy link
Copy Markdown
Member Author

carlory commented Oct 31, 2025

/cc @SergeyKanzhelev
It is ready for review.

SergeyKanzhelev
SergeyKanzhelev approved these changes Oct 31, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 31, 2025

LGTM label has been added.

DetailsGit tree hash: 32fea959cc8c9ecf5e2eefff796fa5413c9825e3

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2025
@k8s-ci-robot k8s-ci-robot merged commit f66d1a9 into kubernetes:master Oct 31, 2025
13 checks passed
@github-project-automation github-project-automation Bot moved this from Work in progress to Done in SIG Node: code and documentation PRs Oct 31, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Oct 31, 2025
@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Oct 31, 2025

Sure, a project release made for K8s 1.34 may not work with K8s 1.35, nothing new. The next project release will support K8s 1.35 and remove the flag.

Generally yes, but we have some tools we use that must work even with unreleased kubernetes, we should take special care for what we're using for release-blocking signal, whenever possible.

In this case I think we're already fine.

@carlory carlory deleted the kubelet-cleanup-pod-infra-container-image branch November 1, 2025 00:59
This was referenced Nov 3, 2025
Merged
Closed
@Jefftree Jefftree mentioned this pull request Nov 24, 2025
Merged
@nojnhuh nojnhuh mentioned this pull request Dec 1, 2025
Merged
comtalyst added a commit to Azure/karpenter-provider-azure that referenced this pull request Mar 19, 2026
@comtalyst @claude
fix: remove --pod-infra-container-image kubelet flag for K8s >= 1.35
51aecd9 
The --pod-infra-container-image flag was removed from kubelet in
Kubernetes 1.35 (kubernetes/kubernetes#133779). Nodes provisioned
with this flag on 1.35+ fail to start kubelet:

  failed to parse kubelet flag: unknown flag: --pod-infra-container-image

Remove it from the base kubelet flags for K8s minor version >= 35,
following the same pattern used for --cloud-config (>= 1.34) and
--keep-terminated-pod-volumes (< 1.31).

Fixes #1516

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@comtalyst comtalyst mentioned this pull request Mar 19, 2026
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odinuge odinuge Awaiting requested review from odinuge

@sjenning sjenning Awaiting requested review from sjenning

@HirazawaUi HirazawaUi Awaiting requested review from HirazawaUi

@neolit123 neolit123 Awaiting requested review from neolit123

@pacoxu pacoxu Awaiting requested review from pacoxu

@kannon92 kannon92 Awaiting requested review from kannon92

1 more reviewer

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SergeyKanzhelev SergeyKanzhelev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

SIG Node: code and documentation PRs
Archived in project

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

Clean up dockershim flags in the kubelet

7 participants

@carlory @k8s-ci-robot @SergeyKanzhelev @HirazawaUi @hakman @BenTheElder @bart0sh