Skip to content

Revert "fix: handle corner cases in the async preemption"#133203

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
pacoxu:revert-133167-preemption-conor-case
Jul 25, 2025
Merged

Revert "fix: handle corner cases in the async preemption"#133203
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
pacoxu:revert-133167-preemption-conor-case

Conversation

@pacoxu
Copy link
Copy Markdown
Member

@pacoxu pacoxu commented Jul 25, 2025 •
edited
Loading

Reverts #133167

None

Just try to revert the previous PR to fix #133201.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 25, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 25, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 25, 2025
@k8s-ci-robot k8s-ci-robot requested review from damemi and kerthcet July 25, 2025 02:39
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 25, 2025
@sanposhiho
Copy link
Copy Markdown
Member

sanposhiho commented Jul 25, 2025

/kind bug
/lgtm
/approve

I'll take a look at the failure and resubmit the PR

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 25, 2025
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 25, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 25, 2025

LGTM label has been added.

DetailsGit tree hash: 13c6e1b4c284c46d15f2a579514a8756337f3235

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacoxu, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2025
@sanposhiho
Copy link
Copy Markdown
Member

sanposhiho commented Jul 25, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2025
@sanposhiho
Copy link
Copy Markdown
Member

sanposhiho commented Jul 25, 2025

Maybe I found the cause. Can I try seeing that would solve the issue first

@sanposhiho
Copy link
Copy Markdown
Member

sanposhiho commented Jul 25, 2025

#133204

@pacoxu
Copy link
Copy Markdown
Member Author

pacoxu commented Jul 25, 2025

Maybe I found the cause. Can I try seeing that would solve the issue first

Of course.

@sanposhiho
Copy link
Copy Markdown
Member

sanposhiho commented Jul 25, 2025

@pacoxu If you find my patch doesn't solve the failure later, feel free to just /unhold this PR. I can take more time later today.

@Vyom-Yadav
Copy link
Copy Markdown
Member

Vyom-Yadav commented Jul 25, 2025

This is currently blocking the CI and delaying the code freeze. If this bug fix is crucial, an exception for this can be made after the code freeze with stable tests.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2025
@Vyom-Yadav
Copy link
Copy Markdown
Member

Vyom-Yadav commented Jul 25, 2025

/milestone v1.34

@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jul 25, 2025
This was referenced Jul 25, 2025
Merged
Merged
@k8s-ci-robot k8s-ci-robot merged commit 1e04b17 into kubernetes:master Jul 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damemi damemi Awaiting requested review from damemi

@kerthcet kerthcet Awaiting requested review from kerthcet

Assignees

@sanposhiho sanposhiho

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

[sig-release] Bug Triage
Archived in project

Milestone

v1.34

Development

Successfully merging this pull request may close these issues.

[Failing Test][Integration] TestNominatedNodeCleanUp

5 participants

@pacoxu @k8s-ci-robot @sanposhiho @Vyom-Yadav @k8s-infra-ci-robot