Skip to content

[FG:PodObservedGenerationTracking] Graduate PodObservedGenerationTracking to beta#132912

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
natasha41575:obsgen-beta
Jul 21, 2025
Merged

[FG:PodObservedGenerationTracking] Graduate PodObservedGenerationTracking to beta#132912
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
natasha41575:obsgen-beta

Conversation

@natasha41575
Copy link
Copy Markdown
Contributor

@natasha41575 natasha41575 commented Jul 12, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Graduate PodObservedGenerationTracking feature to beta / on by default.

Special notes for your reviewer:

PRs that we wanted for this for 1.34:

A couple are still under review though they should be close. Not sure if the convention is to wait for everything to merge before flipping the switch?

Does this PR introduce a user-facing change?

Graduate `PodObservedGenerationTracking` feature to beta and have it on by default. This feature means that the top level `status.observedGeneration` and `status.conditions[].observedGeneration` fields in pods will now be populated to reflect the `metadata.generation` of the podspec at the time that the status or condition is being reported.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://kep.k8s.io/5067

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 12, 2025
@k8s-ci-robot k8s-ci-robot requested review from cici37 and dims July 12, 2025 23:47
@natasha41575
Copy link
Copy Markdown
Contributor Author

natasha41575 commented Jul 12, 2025

/sig node
/priority important-soon
/triage accepted
/hold

/assign @tallclair @SergeyKanzhelev

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2025
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 12, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 12, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 12, 2025
@SergeyKanzhelev
Copy link
Copy Markdown
Member

SergeyKanzhelev commented Jul 15, 2025

please fix tests before reviews

toVersus
toVersus reviewed Jul 16, 2025
View reviewed changes
Comment thread test/compatibility_lifecycle/reference/versioned_feature_list.yaml Outdated
@natasha41575
Copy link
Copy Markdown
Contributor Author

natasha41575 commented Jul 18, 2025

/unassign @tallclair

(I'm probably going to fix this up next week while you're out, so taking it off your list)

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2025
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Jul 18, 2025
@natasha41575 natasha41575 mentioned this pull request Jul 20, 2025
Closed
12 tasks
@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Jul 21, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Apps Jul 21, 2025
@natasha41575
Copy link
Copy Markdown
Contributor Author

natasha41575 commented Jul 21, 2025

all tests are passing, ready for your review @SergeyKanzhelev!

/assign @liggitt
as the API reviewer

@natasha41575 natasha41575 moved this from Triage to Needs Reviewer in SIG Node: code and documentation PRs Jul 21, 2025
@natasha41575 natasha41575 requested a review from toVersus July 21, 2025 19:11
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Jul 21, 2025

/approve

API bits lgtm, will let @SergeyKanzhelev lgtm and unhold

@liggitt liggitt moved this to API review completed, 1.34 in API Reviews Jul 21, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2025
SergeyKanzhelev
SergeyKanzhelev approved these changes Jul 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since mirror pod tests are almost in, this is also lgtm

/lgtm
/approve
/unhold

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 21, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 21, 2025

LGTM label has been added.

DetailsGit tree hash: c678f5625fbfe8b68f35f60b6e75a1c8289effa6

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, natasha41575, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e0f20a3 into kubernetes:master Jul 21, 2025
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jul 21, 2025
@github-project-automation github-project-automation Bot moved this from Needs Reviewer to Done in SIG Node: code and documentation PRs Jul 21, 2025
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in SIG Apps Jul 21, 2025
@github-project-automation github-project-automation Bot moved this from Archive-it to Done in SIG Node CI/Test Board Jul 21, 2025
@natasha41575 natasha41575 deleted the obsgen-beta branch July 21, 2025 21:15
@zhangzujian zhangzujian mentioned this pull request Sep 3, 2025
Closed
@natasha41575 natasha41575 changed the title Graduate PodObservedGenerationTracking to beta [FG:PodObservedGenerationTracking] Graduate PodObservedGenerationTracking to beta Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cici37 cici37 Awaiting requested review from cici37

@dims dims Awaiting requested review from dims

@toVersus toVersus Awaiting requested review from toVersus

1 more reviewer

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@liggitt liggitt

@SergeyKanzhelev SergeyKanzhelev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

API Reviews
Status: API review completed, 1.34
SIG Apps
Archived in project
SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project

Milestone

v1.34

Development

Successfully merging this pull request may close these issues.

7 participants

@natasha41575 @SergeyKanzhelev @liggitt @k8s-ci-robot @toVersus @benjaminapetersen @tallclair