Skip to content

Extend E2E test coverage for PSI metrics under pressure#132824

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
roycaihw:psi-pressure-test
Jul 25, 2025
Merged

Extend E2E test coverage for PSI metrics under pressure#132824
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
roycaihw:psi-pressure-test

Conversation

@roycaihw
Copy link
Copy Markdown
Member

@roycaihw roycaihw commented Jul 8, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Validate that PSI metrics are correctly reported under various resource pressure scenarios.

Which issue(s) this PR is related to:

Ref: #132822

Does this PR introduce a user-facing change?

NONE

/sig node
/priority important-soon

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jul 8, 2025
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 8, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 8, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 8, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 8, 2025
@roycaihw roycaihw mentioned this pull request Jul 8, 2025
Merged
14 tasks
@haircommander haircommander moved this from Triage to PRs Waiting on Author in SIG Node CI/Test Board Jul 9, 2025
@haircommander
Copy link
Copy Markdown
Contributor

haircommander commented Jul 9, 2025

/assign

@roycaihw roycaihw force-pushed the psi-pressure-test branch 8 times, most recently from 10f6011 to 7f76c95 Compare July 16, 2025 23:16
@roycaihw roycaihw force-pushed the psi-pressure-test branch from 73f9edd to a55f1ea Compare July 24, 2025 16:09
@roycaihw roycaihw force-pushed the psi-pressure-test branch from a55f1ea to 6c156db Compare July 24, 2025 16:16
@roycaihw
Copy link
Copy Markdown
Member Author

roycaihw commented Jul 24, 2025

It took me a long time to realize that the error is only happening to the ubuntu tests, but not COS :(

From the naming, it looks like we are using cgroup v1 with Ubuntu in our tests...

Ran 4 of 869 Specs in 126.642 seconds
SUCCESS! -- 4 Passed | 0 Failed | 0 Pending | 865 Skipped


Ginkgo ran 1 suite in 2m7.95504552s
Test Suite Passed

Success Finished Test Suite on Host tmp-node-e2e-3e9145dd-cos-beta-121-18867-90-97. Refer to artifacts directory for ginkgo log for this host.

Ran 4 of 866 Specs in 209.530 seconds
FAIL! -- 1 Passed | 3 Failed | 0 Pending | 862 Skipped


Ginkgo ran 1 suite in 3m31.729908806s

Test Suite Failed

Failure Finished Test Suite on Host tmp-node-e2e-3e9145dd-ubuntu-gke-2204-1-29-v20250724-cgroupsv1. Refer to artifacts directory for ginkgo log for this host.

@roycaihw
Copy link
Copy Markdown
Member Author

roycaihw commented Jul 24, 2025

In comparison, previously we were using "non cgroup v1" ubuntu images when the tests passed

Ran 4 of 837 Specs in 130.003 seconds
SUCCESS! -- 4 Passed | 0 Failed | 0 Pending | 833 Skipped


Ginkgo ran 1 suite in 2m11.460096014s
Test Suite Passed

Success Finished Test Suite on Host tmp-node-e2e-3e57bb03-cos-beta-121-18867-90-85. Refer to artifacts directory for ginkgo log for this host.

Ran 4 of 837 Specs in 140.846 seconds
SUCCESS! -- 4 Passed | 0 Failed | 0 Pending | 833 Skipped


Ginkgo ran 1 suite in 2m22.411871514s
Test Suite Passed

Success Finished Test Suite on Host tmp-node-e2e-3e57bb03-ubuntu-gke-2204-1-29-v20250721. Refer to artifacts directory for ginkgo log for this host.

@roycaihw
Copy link
Copy Markdown
Member Author

roycaihw commented Jul 24, 2025

The test log suggests the image is from family "pipeline-1-29" in project "ubuntu-os-gke-cloud"

@roycaihw roycaihw force-pushed the psi-pressure-test branch from f385b4e to 252513a Compare July 24, 2025 21:40
@roycaihw
Copy link
Copy Markdown
Member Author

roycaihw commented Jul 24, 2025

/test pull-kubernetes-node-e2e-containerd-kubelet-psi

@roycaihw
Copy link
Copy Markdown
Member Author

roycaihw commented Jul 24, 2025 •
edited
Loading

Since we don't have control over what's behind family "pipeline-1-29" in project "ubuntu-os-gke-cloud" (whether it's cgroupv1 or cgroupv2 image), I added a check in the test to skip if cgroupv1 is detected.

Open comments are addressed and the test has passed. This PR is ready for review.
/assign @haircommander @SergeyKanzhelev

Filed a test-infra issue kubernetes/test-infra#35211

@roycaihw roycaihw mentioned this pull request Jul 24, 2025
Closed
@roycaihw
Copy link
Copy Markdown
Member Author

roycaihw commented Jul 24, 2025

Integration test failure unrelated
/retest

SergeyKanzhelev
SergeyKanzhelev approved these changes Jul 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 25, 2025

LGTM label has been added.

DetailsGit tree hash: afc079b6c263acf77aa689d728f65c1ee194709d

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2025
@Vyom-Yadav
Copy link
Copy Markdown
Member

Vyom-Yadav commented Jul 25, 2025

/retest

@pacoxu
Copy link
Copy Markdown
Member

pacoxu commented Jul 25, 2025

/milestone v1.34
since this was approved before code freeze.

@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jul 25, 2025
@pacoxu
Copy link
Copy Markdown
Member

pacoxu commented Jul 25, 2025

/test pull-kubernetes-e2e-gce

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 25, 2025 •
edited
Loading

@roycaihw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-unit-windows-master 511437d link false /test pull-kubernetes-unit-windows-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Vyom-Yadav
Copy link
Copy Markdown
Member

Vyom-Yadav commented Jul 25, 2025

I'll trigger the retest after the revert is merged: #133203

@Vyom-Yadav
Copy link
Copy Markdown
Member

Vyom-Yadav commented Jul 25, 2025

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6d4ca96 into kubernetes:master Jul 25, 2025
15 checks passed
@github-project-automation github-project-automation Bot moved this from PRs Waiting on Author to Done in SIG Node CI/Test Board Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@rphillips rphillips Awaiting requested review from rphillips

@feiskyer feiskyer Awaiting requested review from feiskyer

@matthyx matthyx Awaiting requested review from matthyx

2 more reviewers

@haircommander haircommander haircommander left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@haircommander haircommander

@SergeyKanzhelev SergeyKanzhelev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project
[sig-release] Bug Triage
Archived in project

Milestone

v1.34

Development

Successfully merging this pull request may close these issues.

7 participants

@roycaihw @k8s-ci-robot @haircommander @Vyom-Yadav @pacoxu @SergeyKanzhelev @k8s-infra-ci-robot