Skip to content

Promote PSI metrics feature to beta#132822

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
roycaihw:psi-metrics-beta
Jul 25, 2025
Merged

Promote PSI metrics feature to beta#132822
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
roycaihw:psi-metrics-beta

Conversation

@roycaihw
Copy link
Copy Markdown
Member

@roycaihw roycaihw commented Jul 8, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Promote the KubeletPSI feature gate to beta.

Which issue(s) this PR is related to:

KEP: kubernetes/enhancements#4205

Special notes for your reviewer:

Beta graduation requirements:

Does this PR introduce a user-facing change?

Promoted Linux node pressure stall information (PSI) metrics to beta.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/4205-psi-metric
- [Usage]: https://kubernetes.io/docs/reference/instrumentation/node-metrics/#psi

/sig node
/priority important-soon

@roycaihw
Promote PSI metrics feature to beta
e0cc07a 
Promote the KubeletPSI feature gate to beta
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 8, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 8, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 8, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 8, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@roycaihw roycaihw mentioned this pull request Jul 8, 2025
Merged
@roycaihw
Copy link
Copy Markdown
Member Author

roycaihw commented Jul 8, 2025

/test pull-kubernetes-node-e2e-containerd-kubelet-psi

@rayandas rayandas mentioned this pull request Jul 10, 2025
Closed
34 tasks
@roycaihw roycaihw marked this pull request as ready for review July 21, 2025 15:02
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2025
@k8s-ci-robot k8s-ci-robot requested review from thockin and wojtek-t July 21, 2025 15:02
@roycaihw
Copy link
Copy Markdown
Member Author

roycaihw commented Jul 21, 2025

/cc @haircommander
/assign @haircommander

@haircommander
Copy link
Copy Markdown
Contributor

haircommander commented Jul 21, 2025

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 21, 2025

LGTM label has been added.

DetailsGit tree hash: 125801ae2bd9a76b345fc200b9d1d59774ee73a3

@roycaihw
Copy link
Copy Markdown
Member Author

roycaihw commented Jul 22, 2025

/retest
/assign sergeykanzhelev

@roycaihw
Copy link
Copy Markdown
Member Author

roycaihw commented Jul 23, 2025

/assign @mrunalp

@SergeyKanzhelev
Copy link
Copy Markdown
Member

SergeyKanzhelev commented Jul 23, 2025

/assign sergeykanzhelev

The e2e test PR #132824 is still failing

@lmktfy
Copy link
Copy Markdown
Member

lmktfy commented Jul 23, 2025

Changelog nit

-Promote node Pressure Stall Information (PSI) metrics to beta.
+Promoted Linux node pressure stall information (PSI) metrics to beta.

@roycaihw
Copy link
Copy Markdown
Member Author

roycaihw commented Jul 24, 2025

#132822 (comment) E2E test is now passing. PTAL

SergeyKanzhelev
SergeyKanzhelev approved these changes Jul 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit fdefb8a into kubernetes:master Jul 25, 2025
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@xing-yang xing-yang Awaiting requested review from xing-yang

@thockin thockin Awaiting requested review from thockin

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@haircommander haircommander Awaiting requested review from haircommander

1 more reviewer

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mrunalp mrunalp

@haircommander haircommander

@SergeyKanzhelev SergeyKanzhelev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

SIG Node: code and documentation PRs
Archived in project

Milestone

v1.34

Development

Successfully merging this pull request may close these issues.

6 participants

@roycaihw @k8s-ci-robot @haircommander @SergeyKanzhelev @lmktfy @mrunalp