Improve ignore-not-found behavior by gemmahou · Pull Request #132542 · kubernetes/kubernetes

gemmahou · 2025-06-25T23:23:51Z

What type of PR is this?

Improve help message of ignore-not-found flag

before:

--ignore-not-found=false:
	If the requested object does not exist the command will return exit code 0.

after:

--ignore-not-found=false:
    If set to true, suppresses NotFound error for object(s) that do not exist and returns exit code 0. Using this flag with commands that query for collections of resources has no effect on the exit code.

Check ignore-not-found flag in watch operation as well; when it's set to true, ignore errors
Improve test coverage

/kind bug

What this PR does / why we need it:

Which issue(s) this PR is related to:

kubernetes/kubectl#1596

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Yes

     Clarify help message of --ignore-not-found flag. Support --ignore-not-found in `watch` operation.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2025-06-25T23:24:00Z

Hi @gemmahou. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

gemmahou · 2025-06-25T23:40:54Z

/assign @seans3

seans3 · 2025-06-26T17:17:45Z

/ok-to-test

seans3 · 2025-06-26T17:22:14Z

/triage accepted
/priority backlog

seans3

This looks good, and thanks for the tests. But if I understood the conversation in this issue correctly, I believe there should also be a warning if the --ignore-not-found flag is set when not getting a specific resource. In other words, it doesn't make sense to set the flag unless also retrieving a specific resource. Please let me know what you think.

brianpursley · 2025-07-02T02:11:57Z

/hold
for further discussion regarding the warning.

gemmahou · 2025-07-02T16:55:41Z

/hold for further discussion regarding the warning.

Thanks @brianpursley for your review! I got some clarifications to your comments, and I agree that if the warning is confusing for us as developers, it will likely further confuse our users. I agree we should hold off on implementing the warning message for now, unless we can find a clearer way to present it to users.

Regarding your 2nd option: Only print the warning when you are NOT attempting to get a specific resource by name, and the warning would basically be "warning: --ignore-not-found has no effect".

I believe @seans3 suggested the same earlier and I replied in this comment why I did not implement that way, I appreciate your thoughts/comments on this.

Update: I reverted the warning commit in this PR and cherry-picked it to draft PR: #132690 for visibility and further discussion.

brianpursley

Looks good. Thanks!

/unhold
/lgtm
/approve

k8s-ci-robot · 2025-07-02T23:31:55Z

LGTM label has been added.

Details

Git tree hash: 3377cb6e49bd13ecfadd895f526bb02880bc9d28

k8s-ci-robot · 2025-07-02T23:32:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianpursley, gemmahou, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~staging/src/k8s.io/kubectl/OWNERS~~ [brianpursley,seans3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

brianpursley · 2025-07-02T23:33:17Z

/label tide/merge-method-squash

brianpursley · 2025-07-03T00:48:48Z

/retest

* Improve ignore-not-found behavior * ignore lint errcheck

k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Jun 25, 2025

github-project-automation Bot added this to SIG CLI Jun 25, 2025

github-project-automation Bot moved this to Needs Triage in SIG CLI Jun 25, 2025

k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 25, 2025

k8s-ci-robot requested review from brianpursley and mpuckett159 June 25, 2025 23:24

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 25, 2025

gemmahou force-pushed the ignorenotfound branch from 8a17639 to a15b398 Compare June 25, 2025 23:40

k8s-ci-robot assigned seans3 Jun 25, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 26, 2025

seans3 suggested changes Jun 26, 2025

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2025

gemmahou force-pushed the ignorenotfound branch from 59689d2 to 4b21720 Compare July 2, 2025 18:15

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2025

k8s-ci-robot requested a review from seans3 July 2, 2025 18:15

gemmahou mentioned this pull request Jul 2, 2025

WIP: add warning message for --ignore-not-found flag #132690

Closed

gemmahou added 2 commits July 2, 2025 20:44

Improve ignore-not-found behavior

59194f1

ignore lint errcheck

4fca07e

gemmahou force-pushed the ignorenotfound branch from 4b21720 to 4fca07e Compare July 2, 2025 20:45

brianpursley approved these changes Jul 2, 2025

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2025

k8s-ci-robot assigned brianpursley Jul 2, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2025

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 2, 2025

k8s-ci-robot merged commit a7e8a50 into kubernetes:master Jul 3, 2025

k8s-ci-robot added this to the v1.34 milestone Jul 3, 2025

github-project-automation Bot moved this from In Progress to Done in SIG CLI Jul 3, 2025

drjackild pushed a commit to drjackild/kubernetes that referenced this pull request Jul 11, 2025

Improve ignore-not-found behavior (kubernetes#132542)

aa352f9

* Improve ignore-not-found behavior * ignore lint errcheck

mhan8796 pushed a commit to mhan8796/kubernetes that referenced this pull request Jun 27, 2026

Improve ignore-not-found behavior (kubernetes#132542)

0849b5f

* Improve ignore-not-found behavior * ignore lint errcheck

coderabbitai Bot mentioned this pull request Aug 19, 2026

ensure clients deleted on ginkgo retries jumpstarter-dev/jumpstarter#1010

Merged

coderabbitai Bot mentioned this pull request Aug 26, 2026

feat: declarative environment manifests EduIDE/EduIDE-deployment#113

Merged

Navigation Menu

Repository navigation

Improve ignore-not-found behavior - #132542

Improve ignore-not-found behavior#132542
k8s-ci-robot merged 2 commits into
kubernetes:masterfrom
gemmahou:ignorenotfound

gemmahou commented Jun 25, 2025 •

edited

Loading

Uh oh!

k8s-ci-robot commented Jun 25, 2025

Uh oh!

gemmahou commented Jun 25, 2025

Uh oh!

seans3 commented Jun 26, 2025

Uh oh!

seans3 commented Jun 26, 2025

Uh oh!

seans3 left a comment

Uh oh!

brianpursley commented Jul 2, 2025

Uh oh!

gemmahou commented Jul 2, 2025 •

edited

Loading

Uh oh!

brianpursley left a comment

Uh oh!

k8s-ci-robot commented Jul 2, 2025

Uh oh!

k8s-ci-robot commented Jul 2, 2025

Uh oh!

brianpursley commented Jul 2, 2025

Uh oh!

brianpursley commented Jul 3, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

gemmahou commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Jun 25, 2025

Uh oh!

gemmahou commented Jun 25, 2025

Uh oh!

seans3 commented Jun 26, 2025

Uh oh!

seans3 commented Jun 26, 2025

Uh oh!

seans3 left a comment

Choose a reason for hiding this comment

Uh oh!

brianpursley commented Jul 2, 2025

Uh oh!

gemmahou commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brianpursley left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Jul 2, 2025

Uh oh!

k8s-ci-robot commented Jul 2, 2025

Uh oh!

brianpursley commented Jul 2, 2025

Uh oh!

brianpursley commented Jul 3, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gemmahou commented Jun 25, 2025 •

edited

Loading

gemmahou commented Jul 2, 2025 •

edited

Loading