Skip to content

[FG:PodObservedGenerationTracking] scheduler sets observedGeneration on pod conditions#130649

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
natasha41575:pod-conditions-scheduler
Mar 19, 2025
Merged

[FG:PodObservedGenerationTracking] scheduler sets observedGeneration on pod conditions#130649
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
natasha41575:pod-conditions-scheduler

Conversation

@natasha41575
Copy link
Copy Markdown
Contributor

@natasha41575 natasha41575 commented Mar 7, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR has the scheduler set the condition's observedGeneration field as discussed in https://kep.k8s.io/5067.

Which issue(s) this PR fixes:

Pod generation KEP: https://kep.k8s.io/5067

Does this PR introduce a user-facing change?

The kube-scheduler will set the `observedGeneration` field on pod conditions when the `PodObservedGenerationTracking` feature gate is set.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://kep.k8s.io/5067

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 7, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 7, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 7, 2025
@k8s-ci-robot k8s-ci-robot added area/code-generation area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubelet area/test labels Mar 7, 2025
@natasha41575
Copy link
Copy Markdown
Contributor Author

natasha41575 commented Mar 7, 2025

/sig scheduling
/sig node
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Mar 7, 2025
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 7, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Apps Mar 7, 2025
@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Mar 7, 2025
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 7, 2025
@k8s-ci-robot k8s-ci-robot requested review from dom4ha and macsko March 12, 2025 15:43
@haircommander haircommander moved this from Triage to Archive-it in SIG Node CI/Test Board Mar 12, 2025
macsko
macsko reviewed Mar 13, 2025
View reviewed changes
Comment thread pkg/scheduler/framework/preemption/preemption.go Outdated
@natasha41575 natasha41575 requested a review from macsko March 13, 2025 18:00
@natasha41575 natasha41575 force-pushed the pod-conditions-scheduler branch from 42423ab to 0424297 Compare March 17, 2025 12:43
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2025
@k8s-ci-robot k8s-ci-robot requested a review from tallclair March 17, 2025 12:43
sanposhiho
sanposhiho reviewed Mar 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

For the sig-scheduling area. You need another approval for test/e2e/node.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 18, 2025

LGTM label has been added.

DetailsGit tree hash: a7e67b47d219ed1231fea18af2c4cf82d577002e

@macsko
Copy link
Copy Markdown
Member

macsko commented Mar 18, 2025

/lgtm

@natasha41575 natasha41575 force-pushed the pod-conditions-scheduler branch from 0424297 to 1889e0c Compare March 19, 2025 15:45
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sanposhiho March 19, 2025 15:45
@natasha41575
Copy link
Copy Markdown
Contributor Author

natasha41575 commented Mar 19, 2025

@tallclair need your approval for test/e2e/node, and another lgtm after rebase

@natasha41575
Copy link
Copy Markdown
Contributor Author

natasha41575 commented Mar 19, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2025
@tallclair
Copy link
Copy Markdown
Member

tallclair commented Mar 19, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 19, 2025

LGTM label has been added.

DetailsGit tree hash: 09ba56e7af36cacc5166cedc4dcec3d3206b1529

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5c4071c into kubernetes:master Mar 19, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Mar 19, 2025
@natasha41575 natasha41575 mentioned this pull request Mar 29, 2025
Merged
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hashim21223445, natasha41575, sanposhiho, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apelisse apelisse Awaiting requested review from apelisse

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@denkensk denkensk Awaiting requested review from denkensk

@dom4ha dom4ha Awaiting requested review from dom4ha

@macsko macsko Awaiting requested review from macsko

@tallclair tallclair Awaiting requested review from tallclair

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

1 more reviewer

@hashim21223445 hashim21223445 hashim21223445 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tallclair tallclair

@sanposhiho sanposhiho

@macsko macsko

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

SIG Apps
Archived in project
SIG Node CI/Test Board
Archived in project

Milestone

v1.33

Development

Successfully merging this pull request may close these issues.

8 participants

@natasha41575 @k8s-ci-robot @k8s-triage-robot @tallclair @sanposhiho @macsko @hashim21223445 @haircommander