Skip to content

Add dom4ha to SIG Scheduling reviewers #129781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jan 26, 2025
Merged

Add dom4ha to SIG Scheduling reviewers #129781

k8s-ci-robot merged 1 commit into from
Jan 26, 2025

Conversation

@dom4ha
Copy link
Member

@dom4ha dom4ha commented Jan 23, 2025

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Hi everyone, I would like to self-nominate to become a SIG Scheduling reviewer:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 23, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 23, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 23, 2025
@dom4ha
Copy link
Member Author

dom4ha commented Jan 23, 2025

/sig scheduling
/cc @sanposhiho @alculquicondor

I'd be grateful if you were willing to sponsor my nomination

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 23, 2025
sanposhiho
sanposhiho reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the contributions so far, and looking forward to having more collaboration!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 23, 2025

LGTM label has been added.

DetailsGit tree hash: 13bed0b9bfc9d88f08b67fc87b3cdf91cad576dd

@alculquicondor
Copy link
Member

alculquicondor commented Jan 23, 2025

Welcome!

/lgtm
/approve

@alculquicondor
Copy link
Member

alculquicondor commented Jan 23, 2025

/assign @dims

dom4ha
dom4ha commented Jan 23, 2025
View reviewed changes
Copy link
Member Author

@dom4ha dom4ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Huang-Wei
Copy link
Member

Huang-Wei commented Jan 24, 2025

/approve

Welcome @dom4ha !

@Huang-Wei
Copy link
Member

Huang-Wei commented Jan 24, 2025

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 24, 2025
@dims
Copy link
Member

dims commented Jan 26, 2025

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, dims, dom4ha, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7140b49 into kubernetes:master Jan 26, 2025
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 26, 2025
@utam0k utam0k mentioned this pull request Aug 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims Awaiting requested review from dims

@logicalhan logicalhan Awaiting requested review from logicalhan

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

1 more reviewer

@sanposhiho sanposhiho sanposhiho left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dims dims

@alculquicondor alculquicondor

@sanposhiho sanposhiho

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.33

Development

Successfully merging this pull request may close these issues.

6 participants

@dom4ha @k8s-ci-robot @alculquicondor @Huang-Wei @dims @sanposhiho