Add statusz endpoint for kube-controller-manager by Henrywu573 · Pull Request #128991 · kubernetes/kubernetes

Henrywu573 · 2024-11-27T00:51:02Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Added a /statusz endpoint to kube-controller-manager

Which issue(s) this PR fixes:

Fixes #128750 and kubernetes/enhancements#4828

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added a `/statusz` endpoint for kube-controller-manager

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP] : https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/4828-component-flagz/README.md

Example request:
root@kind-control-plane:/etc/kubernetes/manifests# curl -k --cert /etc/kubernetes/pki/apiserver-kubelet-client.crt --key /etc/kubernetes/pki/apiserver-kubelet-client.key https://localhost:10257/statusz

Example response
controller-manager statusz
Warning: This endpoint is not meant to be machine parseable, has no formatting compatibility guarantees and is for debugging purposes only.

Started:  Wed Nov 27 22:09:26 UTC 2024
Up:  0 hr 01 min 50 sec
Go version:  go1.23.3
Binary version:  1.32.0-beta.0.529&#43;ee503d2e89a129-dirty
Emulation version:  1.32.0-beta.0.529

k8s-ci-robot · 2024-11-27T00:51:06Z

Please note that we're already in Test Freeze for the release-1.32 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.32.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Tue Nov 26 22:37:32 UTC 2024.

k8s-ci-robot · 2024-11-27T00:51:12Z

Hi @Henrywu573. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Henrywu573 · 2024-11-27T00:51:39Z

/sig instrumentation
cc @richabanker

Henrywu573 · 2024-11-27T01:01:54Z

/kind feature

richabanker · 2024-11-28T03:18:38Z

/triage accepted
/ok-to-test

Henrywu573 · 2024-11-28T08:11:29Z

/retest-required

richabanker · 2024-11-29T10:52:34Z

 	configz.InstallHandler(mux)
 	mux.Handle("/metrics", legacyregistry.Handler())
+	if utilfeature.DefaultFeatureGate.Enabled(zpagesfeatures.ComponentStatusz) {
+		statusz.Install(mux, "controller-manager", statusz.NewRegistry())


Nit: "kube-controller-manager" ?

richabanker · 2024-11-29T10:53:20Z

/lgtm
Would be great of we could have some tests for this too.

yongruilin · 2024-12-06T04:11:10Z


 	cmd := &cobra.Command{
-		Use: "kube-controller-manager",
+		Use: kubeControllerManager,


It should be better to display the string explicitly here to demonstrate the command usage.

k8s-ci-robot · 2024-12-06T19:27:14Z

@Henrywu573: GitHub didn't allow me to assign the following users: for, testing, directory, approval.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @aojea for testing directory approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Henrywu573 · 2024-12-06T19:33:36Z

add @aojea or @liggitt since for testing directory approval since andrewsykim@ no longer does Kubernetes reviews anymore

Henrywu573 · 2024-12-06T19:39:23Z

/assign @liggitt

sftim · 2024-12-10T12:10:46Z

/release-note-edit

Added a `/statusz` endpoint for kube-controller-manager

k8s-ci-robot · 2024-12-10T12:10:49Z

@sftim: /release-note-edit must be used with a release note block.

Details

In response to this:

/release-note-edit

Added a `/statusz` endpoint for kube-controller-manager

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sftim · 2024-12-10T12:11:16Z

/release-note-edit

Added a `/statusz` endpoint for kube-controller-manager

richabanker · 2025-01-27T21:29:47Z

/retest

richabanker · 2025-01-27T21:32:40Z

/ok-to-test

Co-authored-by: Antonio Ojea <[email protected]>

Henrywu573 · 2025-02-05T17:49:08Z

/retest-required

aojea · 2025-02-05T21:09:51Z

/lgtm
/approve

Thanks

k8s-ci-robot · 2025-02-05T21:09:58Z

LGTM label has been added.

Details

Git tree hash: f6e9887106ec23c3470bdb28b406c7883501f8b1

k8s-ci-robot · 2025-02-05T21:10:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, Henrywu573, jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~cmd/kube-controller-manager/OWNERS~~ [jpbetz]
~~test/OWNERS~~ [aojea]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 27, 2024

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 27, 2024

k8s-ci-robot requested review from andrewsykim and jpbetz November 27, 2024 00:51

k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 27, 2024

k8s-ci-robot added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Nov 27, 2024

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 27, 2024

thisisharrsh reviewed Nov 27, 2024

View reviewed changes

Comment thread staging/src/k8s.io/controller-manager/app/serve.go Outdated

Henrywu573 force-pushed the cm-statuz branch from ee503d2 to bd94399 Compare November 27, 2024 22:26

richabanker reviewed Nov 29, 2024

View reviewed changes

Add statusz endpoint for kube-controller-manager

5a8d77a

Henrywu573 force-pushed the cm-statuz branch from a2b15e9 to 5a8d77a Compare December 5, 2024 23:49

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2024

k8s-ci-robot requested a review from richabanker December 5, 2024 23:49

yongruilin reviewed Dec 6, 2024

View reviewed changes

k8s-ci-robot assigned aojea Dec 6, 2024

k8s-ci-robot assigned liggitt Dec 6, 2024

richabanker mentioned this pull request Jan 16, 2025

Statusz for Kubernetes Components kubernetes/enhancements#4827

Open

30 tasks

aojea reviewed Feb 5, 2025

View reviewed changes

Comment thread test/integration/serving/serving_test.go Outdated

aojea reviewed Feb 5, 2025

View reviewed changes

Comment thread test/integration/serving/serving_test.go Outdated

Update test/integration/serving/serving_test.go

8bd4e1b

Co-authored-by: Antonio Ojea <[email protected]>

Henrywu573 force-pushed the cm-statuz branch from 81736d3 to 8bd4e1b Compare February 5, 2025 17:48

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2025

k8s-ci-robot merged commit 22f25ef into kubernetes:master Feb 5, 2025

k8s-ci-robot added this to the v1.33 milestone Feb 5, 2025

Henrywu573 deleted the cm-statuz branch February 5, 2025 23:55

Henrywu573 mentioned this pull request Mar 11, 2025

REQUEST: New membership for Henrywu573 kubernetes/org#5460

Closed

11 tasks

Conversation

Henrywu573 commented Nov 27, 2024 • edited by k8s-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Nov 27, 2024

Uh oh!

k8s-ci-robot commented Nov 27, 2024

Uh oh!

Henrywu573 commented Nov 27, 2024

Uh oh!

Henrywu573 commented Nov 27, 2024

Uh oh!

Uh oh!

richabanker commented Nov 28, 2024

Uh oh!

Henrywu573 commented Nov 28, 2024

Uh oh!

richabanker Nov 29, 2024

Choose a reason for hiding this comment

Uh oh!

Henrywu573 Dec 2, 2024

Choose a reason for hiding this comment

Uh oh!

richabanker commented Nov 29, 2024

Uh oh!

yongruilin Dec 6, 2024

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Dec 6, 2024

Uh oh!

Henrywu573 commented Dec 6, 2024

Uh oh!

Henrywu573 commented Dec 6, 2024

Uh oh!

sftim commented Dec 10, 2024

Uh oh!

k8s-ci-robot commented Dec 10, 2024

Uh oh!

sftim commented Dec 10, 2024

Uh oh!

richabanker commented Jan 27, 2025

Uh oh!

richabanker commented Jan 27, 2025

Uh oh!

Uh oh!

Uh oh!

Henrywu573 commented Feb 5, 2025

Uh oh!

aojea commented Feb 5, 2025

Uh oh!

k8s-ci-robot commented Feb 5, 2025

Uh oh!

k8s-ci-robot commented Feb 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Henrywu573 commented Nov 27, 2024 •

edited by k8s-ci-robot

Loading