feat: Add flagz endpoint for kubelet by zhifei92 · Pull Request #128857 · kubernetes/kubernetes

zhifei92 · 2024-11-19T12:46:46Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a /flagz endpoint for kubelet
part of kubernetes/enhancements#4828

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added a /flagz endpoint for kubelet endpoint

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

KEP : https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/4828-component-flagz/README.md

kubectl get --raw "/api/v1/nodes/{nodename}/proxy/flagz"

kubelet flags
Warning: This endpoint is not meant to be machine parseable, has no formatting compatibility guarantees and is for debugging purposes only.

address=0.0.0.0
allowed-unsafe-sysctls=[]
anonymous-auth=true
application-metrics-count-limit=100
authentication-token-webhook=false
authentication-token-webhook-cache-ttl=2m0s
authorization-mode=AlwaysAllow
authorization-webhook-cache-authorized-ttl=5m0s
authorization-webhook-cache-unauthorized-ttl=30s
boot-id-file=/proc/sys/kernel/random/boot_id
bootstrap-kubeconfig=/etc/kubernetes/bootstrap-kubelet.conf
cert-dir=/var/lib/kubelet/pki
cgroup-driver=cgroupfs
cgroup-root=
cgroups-per-qos=true
client-ca-file=
cloud-config=
cloud-provider=
cluster-dns=[]
cluster-domain=
config=/var/lib/kubelet/config.yaml
config-dir=
container-hints=/etc/cadvisor/container_hints.json
container-log-max-files=5
container-log-max-size=10Mi
container-runtime-endpoint=unix:///var/run/containerd/containerd.sock
containerd=/run/containerd/containerd.sock
containerd-namespace=k8s.io
contention-profiling=false
cpu-cfs-quota=true
cpu-cfs-quota-period=100ms
cpu-manager-policy=none
cpu-manager-policy-options=
cpu-manager-reconcile-period=10s
enable-controller-attach-detach=true
enable-debugging-handlers=true
enable-load-reader=false
enable-server=true
enforce-node-allocatable=[pods]
event-burst=100
event-qps=50

k8s-ci-robot · 2024-11-19T12:46:56Z

Hi @zhifei92. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

zhifei92 · 2024-11-19T13:38:33Z

/hold Waiting for PR #128811, which depends on the included componentKubelet.

yongruilin · 2024-11-22T04:50:46Z

/sig instrumentation
/cc @yongruilin

richabanker · 2024-11-27T14:46:18Z

Hello @zhifei92 is this PR still WIP?
(Also, thanks for picking this up!)

zhifei92 · 2024-11-29T09:39:51Z

Hello @zhifei92 is this PR still WIP?

@richabanker Hi, it is now ready for review.

richabanker · 2024-11-29T10:07:45Z

/ok-to-test

zhifei92 · 2025-02-11T02:13:01Z

/retest-required

zhifei92 · 2025-02-25T02:07:20Z

@tallclair @vinayakankugoyal Are there any other issues?

tallclair

/lgtm
/approve

tallclair · 2025-03-12T18:55:12Z

 	tp oteltrace.TracerProvider) {
 	klog.InfoS("Starting to listen read-only", "address", address, "port", port)
-	s := NewServer(host, resourceAnalyzer, checkers, nil, nil)
+	s := NewServer(host, resourceAnalyzer, checkers, flagz, nil, nil)


nit: you can just pass nil here and drop the function parameter since it's never served by the readonly server.

k8s-ci-robot · 2025-03-12T18:58:38Z

LGTM label has been added.

Details

Git tree hash: 4e194eeeda1296a4b23f6e46faf7eb6eb58404da

Fix: Move flagz to InstallDebuggingHandlers. Move flagz to the lower switch statemen Fix linter Drop the function parameter for the read-only server.

zhifei92 · 2025-03-13T02:19:44Z

/cc @haircommander @SergeyKanzhelev for approve. Please take a look. thx~

richabanker · 2025-03-13T04:13:32Z

/approve

k8s-ci-robot · 2025-03-13T04:13:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richabanker, tallclair, zhifei92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~cmd/kubelet/OWNERS~~ [tallclair]
~~pkg/kubelet/OWNERS~~ [tallclair]
~~staging/src/k8s.io/component-base/zpages/OWNERS~~ [richabanker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

zhifei92 · 2025-03-13T05:06:48Z

@richabanker @tallclair Need lgtm again.

richabanker · 2025-03-13T05:08:27Z

/lgtm

k8s-ci-robot · 2025-03-13T05:08:33Z

LGTM label has been added.

Details

Git tree hash: 1115cbcfaa33fc1bf19f9e2d8cac97e73b18bf37

zhifei92 · 2025-03-13T08:44:56Z

/unhold

k8s-triage-robot · 2025-03-13T09:06:02Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

k8s-ci-robot · 2025-03-13T09:14:55Z

@zhifei92: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-e2e-kind-ipv6	`2db729c`	link	unknown	`/test pull-kubernetes-e2e-kind-ipv6`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

zhifei92 · 2025-03-13T09:44:03Z

/test pull-kubernetes-e2e-kind-ipv6

k8s-ci-robot requested review from liggitt and mtaufen November 19, 2024 12:47

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2024

k8s-ci-robot requested a review from yongruilin November 22, 2024 04:50

k8s-ci-robot added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Nov 22, 2024

zhifei92 force-pushed the flagz-kubelet branch from 9e0d199 to b9fc3df Compare November 28, 2024 12:42

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2024

zhifei92 changed the title ~~[WIP]feat: Add flagz endpoint for kubelet~~ feat: Add flagz endpoint for kubelet Nov 28, 2024

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2024

richabanker reviewed Nov 29, 2024

View reviewed changes

Comment thread cmd/kubelet/app/server.go Outdated

zhifei92 force-pushed the flagz-kubelet branch 2 times, most recently from 9d01d37 to 92ae41a Compare February 23, 2025 13:32

tallclair reviewed Mar 12, 2025

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2025

Add flatz to kubelet auth.

2db729c

Fix: Move flagz to InstallDebuggingHandlers. Move flagz to the lower switch statemen Fix linter Drop the function parameter for the read-only server.

zhifei92 force-pushed the flagz-kubelet branch from 92ae41a to 2db729c Compare March 13, 2025 02:12

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2025

k8s-ci-robot requested a review from tallclair March 13, 2025 02:12

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2025

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2025

k8s-ci-robot merged commit 953b40b into kubernetes:master Mar 13, 2025

k8s-ci-robot added this to the v1.33 milestone Mar 13, 2025

github-project-automation Bot moved this from Work in progress to Done in SIG Node: code and documentation PRs Mar 13, 2025

github-actions Bot mentioned this pull request Oct 21, 2025

claude jjchange10/googlecloud#3

Merged

liggitt added this to API Reviews Dec 3, 2025

liggitt moved this to API review completed, 1.33 in API Reviews Dec 3, 2025

Conversation

zhifei92 commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Nov 19, 2024

Uh oh!

zhifei92 commented Nov 19, 2024

Uh oh!

yongruilin commented Nov 22, 2024

Uh oh!

richabanker commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhifei92 commented Nov 29, 2024

Uh oh!

Uh oh!

richabanker commented Nov 29, 2024

Uh oh!

zhifei92 commented Feb 11, 2025

Uh oh!

zhifei92 commented Feb 25, 2025

Uh oh!

tallclair left a comment

Choose a reason for hiding this comment

Uh oh!

tallclair Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Mar 12, 2025

Uh oh!

zhifei92 commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richabanker commented Mar 13, 2025

Uh oh!

k8s-ci-robot commented Mar 13, 2025

Uh oh!

zhifei92 commented Mar 13, 2025

Uh oh!

richabanker commented Mar 13, 2025

Uh oh!

k8s-ci-robot commented Mar 13, 2025

Uh oh!

zhifei92 commented Mar 13, 2025

Uh oh!

k8s-triage-robot commented Mar 13, 2025

Uh oh!

k8s-ci-robot commented Mar 13, 2025

Uh oh!

zhifei92 commented Mar 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

zhifei92 commented Nov 19, 2024 •

edited

Loading

richabanker commented Nov 27, 2024 •

edited

Loading

zhifei92 commented Mar 13, 2025 •

edited

Loading