Skip to content

test: Add integration test for apiserver flagz endpoint#128848

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
yongruilin:flagz-integration-test-apiserver
Dec 13, 2024
Merged

test: Add integration test for apiserver flagz endpoint#128848
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
yongruilin:flagz-integration-test-apiserver

Conversation

@yongruilin
Copy link
Copy Markdown
Contributor

@yongruilin yongruilin commented Nov 19, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Add the integration test for flagz endpoint of apiserver

Which issue(s) this PR fixes:

Fixes kubernetes/enhancements#4828

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/4828-component-flagz/README.md

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 19, 2024
@yongruilin
Copy link
Copy Markdown
Contributor Author

yongruilin commented Nov 19, 2024

/remove-sig architecture
/cc @richabanker

@k8s-ci-robot k8s-ci-robot removed the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Nov 19, 2024
@richabanker
Copy link
Copy Markdown
Contributor

richabanker commented Nov 19, 2024

/lgtm
Thanks for adding the test!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 19, 2024

LGTM label has been added.

DetailsGit tree hash: 03277603b0126e3fb642f2ef03d8ec0fdcd405fc

@yongruilin
Copy link
Copy Markdown
Contributor Author

yongruilin commented Dec 7, 2024

/cc @BenTheElder

BenTheElder
BenTheElder reviewed Dec 10, 2024
View reviewed changes
Comment thread staging/src/k8s.io/component-base/zpages/flagz/flagz.go Outdated
@yongruilin yongruilin force-pushed the flagz-integration-test-apiserver branch from a65de81 to 8836548 Compare December 11, 2024 17:23
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2024
@dgrisonnet
Copy link
Copy Markdown
Member

dgrisonnet commented Dec 12, 2024

/assign @BenTheElder

@dgrisonnet
Copy link
Copy Markdown
Member

dgrisonnet commented Dec 12, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 12, 2024
BenTheElder
BenTheElder reviewed Dec 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 12, 2024

LGTM label has been added.

DetailsGit tree hash: a95c777a26e423ba35266b1bd7f6178cd65dff94

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, yongruilin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2024
@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Dec 13, 2024

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit e933a30 into kubernetes:master Dec 13, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Dec 13, 2024
@yongruilin yongruilin mentioned this pull request Dec 18, 2024
Merged
@pacoxu pacoxu mentioned this pull request Dec 24, 2024
Open
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@mengjiao-liu mengjiao-liu Awaiting requested review from mengjiao-liu

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@richabanker richabanker Awaiting requested review from richabanker

Assignees

@BenTheElder BenTheElder

@richabanker richabanker

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.33

Development

Successfully merging this pull request may close these issues.

Flagz for Kubernetes Components

6 participants

@yongruilin @richabanker @k8s-ci-robot @dgrisonnet @k8s-triage-robot @BenTheElder