Skip to content

feat: Add flagz endpoint for kube-controller-manager#128824

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
yongruilin:flagz-controller-manager
Mar 12, 2025
Merged

feat: Add flagz endpoint for kube-controller-manager#128824
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
yongruilin:flagz-controller-manager

Conversation

@yongruilin
Copy link
Copy Markdown
Contributor

@yongruilin yongruilin commented Nov 16, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Added a /flagz HTTP endpoint for kube-controller-manager

Which issue(s) this PR fixes:

Fixes #128823 and kubernetes/enhancements#4828

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Adds a /flagz endpoint for kube-controller-manager endpoint

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Example response

curl -k --cert /etc/kubernetes/pki/apiserver-kubelet-client.crt --key /etc/kubernetes/pki/apiserver-kubelet-client.key https://localhost:10257/flagz

kube-controller-manager flags
Warning: This endpoint is not meant to be machine parseable, has no formatting compatibility guarantees and is for debugging purposes only.

allocate-node-cidrs=false
allow-metric-labels=[]
allow-metric-labels-manifest=
allow-untagged-cloud=false
attach-detach-reconcile-sync-period=1m0s
authentication-kubeconfig=/etc/kubernetes/controller-manager.conf
authentication-skip-lookup=false
authentication-token-webhook-cache-ttl=10s
authentication-tolerate-lookup-failure=false
authorization-always-allow-paths=[/healthz,/readyz,/livez]
authorization-kubeconfig=/etc/kubernetes/controller-manager.conf
authorization-webhook-cache-authorized-ttl=10s
authorization-webhook-cache-unauthorized-ttl=10s
bind-address=127.0.0.1
cert-dir=
cidr-allocator-type=RangeAllocator
client-ca-file=/etc/kubernetes/pki/ca.crt
cloud-config=
cloud-provider=
cluster-cidr=10.244.0.0/16
cluster-name=test-flagz-scheduelr
...
...

[KEP] https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/4828-component-flagz/README.md

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 16, 2024
@yongruilin
Copy link
Copy Markdown
Contributor Author

yongruilin commented Nov 16, 2024

/sig instrumentation

@k8s-ci-robot k8s-ci-robot added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Nov 16, 2024
@seans3
Copy link
Copy Markdown
Contributor

seans3 commented Nov 19, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 19, 2024
@richabanker
Copy link
Copy Markdown
Contributor

richabanker commented Nov 19, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 19, 2024

LGTM label has been added.

DetailsGit tree hash: bbafde6d5ba9137b9213e32c15634c96c00e3d72

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Nov 22, 2024

Changelog suggestion

-Adds a /flagz endpoint for kube-controller-manager endpoint
+Added a `/flagz` HTTP endpoint for kube-controller-manager

@richabanker
Copy link
Copy Markdown
Contributor

richabanker commented Dec 5, 2024

Realized this is missing tests, might be a good idea to have a consolidated test for z-pages, also incorporating the one added in #128991

@richabanker richabanker mentioned this pull request Jan 16, 2025
Open
30 tasks
@richabanker
Copy link
Copy Markdown
Contributor

richabanker commented Jan 16, 2025

/assign @jpbetz for review from KCM pov, thanks!

@yongruilin
Copy link
Copy Markdown
Contributor Author

yongruilin commented Feb 5, 2025

/hold This PR has similar problem as #129994

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2025
@yongruilin yongruilin force-pushed the flagz-controller-manager branch from f1cd6b0 to c2f484f Compare February 5, 2025 22:22
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2025
@yongruilin yongruilin force-pushed the flagz-controller-manager branch from c2f484f to 18919f5 Compare February 27, 2025 21:45
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2025
@yongruilin
Copy link
Copy Markdown
Contributor Author

yongruilin commented Feb 27, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2025
@yongruilin
Copy link
Copy Markdown
Contributor Author

yongruilin commented Feb 27, 2025

/assign @jpbetz for review from KCM pov, thanks!

/assign @jpbetz

@yongruilin yongruilin force-pushed the flagz-controller-manager branch from 18919f5 to 97db9a7 Compare March 5, 2025 22:41
@dgrisonnet
Copy link
Copy Markdown
Member

dgrisonnet commented Mar 6, 2025

cc @richabanker

@richabanker
Copy link
Copy Markdown
Contributor

richabanker commented Mar 12, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 12, 2025

LGTM label has been added.

DetailsGit tree hash: 9bbe5a9605d1abd16339922be2895e0a27562cf1

@jpbetz
Copy link
Copy Markdown
Contributor

jpbetz commented Mar 12, 2025

/approve
Leaning on @richabanker for flagz expertise. The wiring and gating looks sane.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, yongruilin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9693eea into kubernetes:master Mar 12, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@humblec humblec Awaiting requested review from humblec

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@richabanker richabanker Awaiting requested review from richabanker

Assignees

@jpbetz jpbetz

@richabanker richabanker

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.33

Development

Successfully merging this pull request may close these issues.

Add flagz endpoint for kube-controller-manager

7 participants

@yongruilin @seans3 @richabanker @k8s-ci-robot @sftim @dgrisonnet @jpbetz