[PodLevelResources] Pod Level Resources Feature Alpha#128407
Merged
k8s-ci-robot merged 15 commits intokubernetes:masterfrom Nov 8, 2024
Merged
[PodLevelResources] Pod Level Resources Feature Alpha#128407k8s-ci-robot merged 15 commits intokubernetes:masterfrom
k8s-ci-robot merged 15 commits intokubernetes:masterfrom
Conversation
Contributor
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
ndixita
force-pushed
the
pod-level-resources
branch
from
69592f0 to
7125ffa
Compare
Contributor
Contributor
Author
|
/test all |
ndixita
force-pushed
the
pod-level-resources
branch
from
7125ffa to
c4fcf81
Compare
Contributor
Author
|
Addressing the default test failures |
liggitt
reviewed
Oct 30, 2024
mrunalp
reviewed
Nov 8, 2024
Contributor
mrunalp
left a comment
mrunalp
left a comment
There was a problem hiding this comment.
Can we add a description to the commit: QOS changes for Pod Level resources?
Contributor
|
/lgtm Still need to wait for the tests to pass |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 0b1e70614e188256dbcc640d47a110d7a3363be5 |
Contributor
Author
|
/test pull-kubernetes-e2e-kind |
Contributor
Author
|
/test pull-kubernetes-verify |
Contributor
Author
|
/test pull-kubernetes-node-kubelet-serial-podresources |
1. Add Resources struct to PodSpec struct in both external and internal API packages 2. Adding feature gate and logic for dropping disabled fields for Pod Level Resources KEP: enhancements/keps/sig-node/2837-pod-level-resource-spec
Contributor
|
/lgtm |
Contributor
|
LGTM label has been added. DetailsGit tree hash: c2e9c9f2c0ca6fa70f05d4791e9aa2ef752a3bf1 |
1. Add support for pod level resources in kubectl 2. Reuse the existing method to describe container resources and generalize it to describe both pod and container level resources
1. If pod-level limit is set, pod-level request is unset and container-level request is set: derive pod-level request from container-level requests 2. If pod-level limit is set, pod-level request is unset and container-level request is unset: set pod-level request equal to pod-level limit
1. The effective container requests cannot be greater than pod-level requests 2. Inidividual container limits cannot be greater than pod-level limits 3. Only CPU & Memory are supported at pod-level 4. Inplace container resources updates are not supported if pod-level resources are set Note: effective container requests cannot be greater than pod-level limits is supported by transitivity. Effective container requests <= pod-level requests && pod-level requests <= pod-level limits; Therefore effective container requests <= pod-level limits Signed-off-by: ndixita <[email protected]>
1. Use pod-level resource when feature is enabled and resources are set at pod-level 2. Edge case handling: When a pod defines only CPU or memory limits at pod-level (but not both), and container-level requests/limits are unset, the pod-level requests stay empty for the resource without a pod-limit. The container's request for that resource is then set to the default request value from schedutil.
1. Pod cgrooup configured to use resources from pod spec if feature is enabled and resources are set at pod-level 2. Container cgroup limits defaulted to pod-level limits is container limits are not set
…urces into account Signed-off-by: ndixita <[email protected]>
Signed-off-by: ndixita <[email protected]>
…rces are not set Signed-off-by: ndixita <[email protected]>
Member
|
/lgtm |
Contributor
|
LGTM label has been added. DetailsGit tree hash: fc17af58370a99e0823cef19139b071bb4be00e7 |
Contributor
Author
|
/test pull-kubernetes-node-kubelet-serial-podresources |
Contributor
|
@ndixita: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
Author
|
/test pull-kubernetes-e2e-gce-cos-alpha-features |
Contributor
Author
|
The tests timing out in pull-kubernetes-e2e-gce-cos-alpha-features are not realated to this PR. They are related to InPlaceVerticalScaling feature
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR implements Pod Level Resources that require following changes:
Which issue(s) this PR fixes:
Fixes #
xref: kubernetes/enhancements#2837
Special notes for your reviewer:
API changes: 62c5355
Scheduler changes: cb4f2ea
Kubelet changes: inside pkg/kubelet
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: