Skip to content

Update prometheus client golang #127941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dashpole wants to merge 5 commits into from
Closed

Update prometheus client golang #127941

dashpole wants to merge 5 commits into from

Conversation

@dashpole
Copy link
Contributor

@dashpole dashpole commented Oct 8, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update prometheus/client_golang and adapt to behavioral change to the prometheus testutil library.

Special notes for your reviewer:

Changes to prometheus tests are is due to prometheus/client_golang#1424. Prior to that change, the metrics were used only as a filter. The test would not fail if a metric in the list was not present. After the change, including a metric that was not present in the exposition would fail the test.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 8, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 8, 2024

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 8, 2024
@k8s-ci-robot k8s-ci-robot requested review from a team, andrewsykim and andyzhangx October 8, 2024 20:19
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 8, 2024
@dashpole dashpole changed the title Update client golang Update prometheus client golang Oct 8, 2024
@dims
Copy link
Member

dims commented Oct 8, 2024

Sigh! on prometheus/client_golang@bccd682

@kakkoyun
Copy link

kakkoyun commented Oct 9, 2024

Sigh! on prometheus/client_golang@bccd682

@dims, what issues did this commit introduce? It's my mess, and I would like to know more to prevent it from happening again in the future.

@kakkoyun
Copy link

kakkoyun commented Oct 9, 2024

Sigh! on prometheus/client_golang@bccd682

@dims, what issues did this commit introduce? It's my mess, and I would like to know more to prevent it from happening again in the future.

Ok, I see the dependency changes. We will do a better job next time and maybe even remove dependencies.

@bwplotka
Copy link

bwplotka commented Oct 9, 2024

Yea, we can adjust and learn here (e.g. remove a dep)

bwplotka
bwplotka reviewed Oct 9, 2024
View reviewed changes
@dims
Copy link
Member

dims commented Oct 9, 2024

Ok, I see the dependency changes. We will do a better job next time and maybe even remove dependencies.

@kakkoyun thank you! you are right, it's the dependencies.

When k8s generates all the staging libraries and people use them in the wild, we are passing on these dependencies to them.

  • Direct dependencies we pass to those folks will increase their footprint
  • Indirect dependencies we pass may sometimes make it harder for them to upgrade/update their existing dependencies.

So we are very very conscious of what we pick up both for ourselves (things that end up in our binaries) but also our libraries that we pass along to our consumers.

@dims
Copy link
Member

dims commented Oct 9, 2024

Yea, we can adjust and learn here (e.g. remove a dep)

@bwplotka thank you! very much appreciate all the work you all do!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 10, 2024

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

logicalhan
logicalhan reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dashpole, logicalhan
Once this PR has been reviewed and has the lgtm label, please assign liggitt, sttts for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dashpole
Copy link
Contributor Author

dashpole commented Oct 10, 2024

/hold

Discussed at sig-instrumentation, and consensus was that we want to explore if a revert of the change in client_golang is possible. @logicalhan @dgrisonnet

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2024
@Jefftree
Copy link
Member

Jefftree commented Oct 10, 2024

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 10, 2024
@aramase
Copy link
Member

aramase commented Oct 14, 2024

/lgtm cancel

The changes to the SIG Auth tests (encryption at rest and authenticator) looks unexpected. Please tag @kubernetes/sig-auth-pr-reviews for review after resolving the merge conflicts and #127941 (comment) is resolved.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2024
@bwplotka bwplotka mentioned this pull request Oct 14, 2024
Merged
@bwplotka
Copy link

bwplotka commented Oct 14, 2024 •
edited
Loading

Proposed a revert, we will make a decision tomorrow: prometheus/client_golang#1645

Thanks and apologies for the pain here!

@bwplotka bwplotka mentioned this pull request Oct 15, 2024
Open
@bwplotka
Copy link

bwplotka commented Oct 15, 2024

The problematic change was reverted: https://github.com/prometheus/client_golang/releases/tag/v1.20.5

@dashpole
Copy link
Contributor Author

dashpole commented Oct 18, 2024

Closing for now. If needed, i'll open a new PR.

@dashpole dashpole closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@logicalhan logicalhan Awaiting requested review from logicalhan

1 more reviewer

@bwplotka bwplotka bwplotka left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@logicalhan logicalhan

@aramase aramase

Labels

area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

SIG Auth
Archived in project
SIG CLI
Archived in project
SIG Node: code and documentation PRs
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@dashpole @k8s-ci-robot @dims @kakkoyun @bwplotka @Jefftree @aramase @logicalhan