Skip to content

Automated cherry pick of #127417: bugfix: endpoints controller track resource version #127454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Sep 19, 2024
Merged

Automated cherry pick of #127417: bugfix: endpoints controller track resource version #127454

k8s-ci-robot merged 1 commit into from
Sep 19, 2024

Conversation

@swetharepakula
Copy link
Member

@swetharepakula swetharepakula commented Sep 18, 2024

Cherry pick of #127417 on release-1.28.

#127417: bugfix: endpoints controller track resource version

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Sep 18, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 18, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 18, 2024

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 18, 2024
@k8s-ci-robot k8s-ci-robot added area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 18, 2024
@aojea
Copy link
Member

aojea commented Sep 18, 2024

same as #127452 (comment)

@swetharepakula swetharepakula force-pushed the automated-cherry-pick-of-#127417-origin-release-1.28 branch 2 times, most recently from 9a181db to 753fe98 Compare September 18, 2024 20:38
@swetharepakula
Copy link
Member Author

swetharepakula commented Sep 18, 2024

Due to the diff between release-1.28 and master, the test was modified slightly to initialize the context and use the util functions that are available in release-1.28. There is no logical difference between the tests.

@M00nF1sh @swetharepakula
bugfix: endpoints controller track resource version conrrectly
6226e65 
The endpoints controller store the resource version of the previous
Endpoints objects to avoid issues related to stale information on the
cache.

However, there can be update operations that succeed without increasing
the resource version, causing the endpoints controller to declare stale
the existing Resource Version and stopping the Endpoints to be updated.

Co-Author-By: Quan Tian <[email protected]>
Co-Author-By: Yang Yang <[email protected]>
@swetharepakula swetharepakula force-pushed the automated-cherry-pick-of-#127417-origin-release-1.28 branch from 753fe98 to 6226e65 Compare September 18, 2024 23:49
@aojea
Copy link
Member

aojea commented Sep 19, 2024

/lgtm
/approve
/kind bug

Thanks

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 19, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 19, 2024

LGTM label has been added.

DetailsGit tree hash: f65b10784bd1457664fcf5ee22a097f96a938956

Verolop
Verolop reviewed Sep 19, 2024
View reviewed changes
Copy link

@Verolop Verolop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 19, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit f1a5de9 into kubernetes:release-1.28 Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Verolop Verolop Verolop left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@thockin thockin Awaiting requested review from thockin

Assignees

@Verolop Verolop

@aojea aojea

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG Apps
Archived in project

Milestone

v1.28

Development

Successfully merging this pull request may close these issues.

5 participants

@swetharepakula @k8s-ci-robot @aojea @Verolop @M00nF1sh