Skip to content

bugfix: endpoints controller track resource version conrrectly #127417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Sep 17, 2024
Merged

bugfix: endpoints controller track resource version conrrectly #127417

k8s-ci-robot merged 1 commit into from
Sep 17, 2024

Conversation

@aojea
Copy link
Member

@aojea aojea commented Sep 17, 2024 •
edited
Loading

The endpoints controller store the resource version of the previous Endpoints objects to avoid issues related to stale information on the cache since #125675

However, there can be update operations that succeed without increasing the resource version, causing the endpoints controller to declare stale the existing Resource Version and stopping the Endpoints to be updated.

Co-Author-By: Quan Tian [email protected]
Co-Author-By: Yang Yang [email protected]

/kind bug
/kind regression

Fixes #126578, #127370

Fix a bug on the endpoints controller that does not reconcile the Endpoint object after this is truncated (it gets more than 1000 endpoints addresses)

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 17, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 17, 2024

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 17, 2024
@aojea
Copy link
Member Author

aojea commented Sep 17, 2024

/assign @M00nF1sh @tnqn @liggitt @thockin @robscott
/cc @mbrancato

/sig network
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Sep 17, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 17, 2024

@aojea: GitHub didn't allow me to request PR reviews from the following users: mbrancato.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/assign @M00nF1sh @tnqn @liggitt @thockin @robscott
/cc @mbrancato

/sig network
/priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 17, 2024
@M00nF1sh @aojea
bugfix: endpoints controller track resource version conrrectly
dba4e42 
The endpoints controller store the resource version of the previous
Endpoints objects to avoid issues related to stale information on the
cache.

However, there can be update operations that succeed without increasing
the resource version, causing the endpoints controller to declare stale
the existing Resource Version and stopping the Endpoints to be updated.

Co-Author-By: Quan Tian <[email protected]>
Co-Author-By: Yang Yang <[email protected]>
@aojea aojea force-pushed the endpoints_updated_rv branch from 0c03ad7 to dba4e42 Compare September 17, 2024 11:01
@liggitt
Copy link
Member

liggitt commented Sep 17, 2024

I'm fuzzy on the things that can trigger a no-op write, but the resourceVersion comparison looks right to me

@M00nF1sh
Copy link
Member

M00nF1sh commented Sep 17, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 17, 2024

LGTM label has been added.

DetailsGit tree hash: 6cde9035b13ab0b9ea6aaf0ecf7f4255a514f6a3

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8e17456 into kubernetes:master Sep 17, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 17, 2024
@aojea aojea mentioned this pull request Sep 18, 2024
Closed
This was referenced Sep 18, 2024
Merged
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Sep 19, 2024
@k8s-ci-robot
Merge pull request #127454 from swetharepakula/automated-cherry-pick-…
f1a5de9 
…of-#127417-origin-release-1.28

Automated cherry pick of #127417: bugfix: endpoints controller track resource version
k8s-ci-robot added a commit that referenced this pull request Sep 19, 2024
@k8s-ci-robot
Merge pull request #127453 from swetharepakula/automated-cherry-pick-…
7419fe4 
…of-#127417-origin-release-1.29

Automated cherry pick of #127417: bugfix: endpoints controller track resource version
k8s-ci-robot added a commit that referenced this pull request Sep 19, 2024
@k8s-ci-robot
Merge pull request #127452 from swetharepakula/automated-cherry-pick-…
f877211 
…of-#127417-origin-release-1.30

Automated cherry pick of #127417: bugfix: endpoints controller track resource version
k8s-ci-robot added a commit that referenced this pull request Sep 19, 2024
@k8s-ci-robot
Merge pull request #127451 from swetharepakula/automated-cherry-pick-…
e3be752 
…of-#127417-origin-release-1.31

Automated cherry pick of #127417: bugfix: endpoints controller track resource version
@mbrancato mbrancato mentioned this pull request Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@robscott robscott

@liggitt liggitt

@tnqn tnqn

@thockin thockin

@M00nF1sh M00nF1sh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG Apps
Archived in project

Milestone

v1.32

Development

Successfully merging this pull request may close these issues.

Still seeing the issue for endpoints staying out of sync

7 participants

@aojea @k8s-ci-robot @liggitt @M00nF1sh @robscott @tnqn @thockin