Skip to content

add OWNERS and README for zpages under component-base#127206

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
richabanker:zpages-owners
Sep 18, 2024
Merged

add OWNERS and README for zpages under component-base#127206
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
richabanker:zpages-owners

Conversation

@richabanker
Copy link
Copy Markdown
Contributor

@richabanker richabanker commented Sep 6, 2024 •
edited
Loading

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Adds a separate directory for z-pages under component-base.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 6, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 6, 2024

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 6, 2024
@richabanker
Copy link
Copy Markdown
Contributor Author

richabanker commented Sep 6, 2024

/assign @sttts
/cc @logicalhan

logicalhan
logicalhan approved these changes Sep 6, 2024
View reviewed changes
Copy link
Copy Markdown

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 6, 2024

LGTM label has been added.

DetailsGit tree hash: 0ef8a9a6b62a46723b08c965ffa9a77deaede166

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2024
@sttts
Copy link
Copy Markdown
Contributor

sttts commented Sep 11, 2024

@jpbetz seeing you as approver in https://github.com/kubernetes/enhancements/pull/4830/files, but no comments yet. Waiting for your lgtm. Am happy to approve afterwards.

@jpbetz
Copy link
Copy Markdown
Contributor

jpbetz commented Sep 11, 2024

@jpbetz seeing you as approver in https://github.com/kubernetes/enhancements/pull/4830/files, but no comments yet. Waiting for your lgtm. Am happy to approve afterwards.

Thanks, I've approved PRR for the KEP. @logicalhan I think final approval-to-merge of the KEP is in your hands now?

logicalhan
logicalhan approved these changes Sep 11, 2024
View reviewed changes
Copy link
Copy Markdown

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 11, 2024

LGTM label has been added.

DetailsGit tree hash: dc146b9ab34c77b33051d16a9abef56199881ee8

@sttts
Copy link
Copy Markdown
Contributor

sttts commented Sep 12, 2024

/approve

@johnbelamaric
Copy link
Copy Markdown
Member

johnbelamaric commented Sep 16, 2024

/approve
/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, logicalhan, richabanker, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@pacoxu
Copy link
Copy Markdown
Member

pacoxu commented Sep 18, 2024

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit 16b1a49 into kubernetes:master Sep 18, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 18, 2024
This was referenced Oct 16, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims Awaiting requested review from dims

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@sttts sttts Awaiting requested review from sttts

1 more reviewer

@logicalhan logicalhan logicalhan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@logicalhan logicalhan

@sttts sttts

@johnbelamaric johnbelamaric

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.32

Development

Successfully merging this pull request may close these issues.

7 participants

@richabanker @k8s-ci-robot @sttts @jpbetz @johnbelamaric @pacoxu @logicalhan