Skip to content

Automated cherry pick of #125675: Fix endpoints status out-of-sync when the pod state changes #125859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jul 11, 2024
Merged

Automated cherry pick of #125675: Fix endpoints status out-of-sync when the pod state changes #125859

k8s-ci-robot merged 1 commit into from
Jul 11, 2024

Conversation

@tnqn
Copy link
Member

@tnqn tnqn commented Jul 3, 2024

Cherry pick of #125675 on release-1.28.

#125675: Fix endpoints status out-of-sync when the pod state changes

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 3, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 3, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 3, 2024

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 3, 2024
@k8s-ci-robot k8s-ci-robot added area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 3, 2024
chymy
chymy reviewed Jul 3, 2024
View reviewed changes
chymy
chymy reviewed Jul 3, 2024
View reviewed changes
@tnqn tnqn force-pushed the automated-cherry-pick-of-#125675-upstream-release-1.28 branch from ecdb76d to c2a9dc8 Compare July 3, 2024 09:19
@tnqn
Fix endpoints status out-of-sync when the pod state changes rapidly
98d8d98 
When Pod state changes rapidly, endpoints controller may use outdated
informer cache to sync Service. If the outdated endpoints appear to be
expected by the controller, it skips updating it.

The commit fixes it by checking if endpoints informer cache is outdated
when processing a service. If the endpoints is stale, it returns an
error and retries later.

Signed-off-by: Quan Tian <[email protected]>
@tnqn tnqn force-pushed the automated-cherry-pick-of-#125675-upstream-release-1.28 branch from c2a9dc8 to 98d8d98 Compare July 3, 2024 09:26
@tnqn
Copy link
Member Author

tnqn commented Jul 3, 2024

@chymy thanks for reviewing. I have fixed all code conflicts.

@tnqn
Copy link
Member Author

tnqn commented Jul 3, 2024

/assign @aojea

@aojea
Copy link
Member

aojea commented Jul 5, 2024

/kind bug
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 5, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 5, 2024

LGTM label has been added.

DetailsGit tree hash: e8e9747d3a7e2205a791bfb99136387dd404bc83

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2024
@tnqn
Copy link
Member Author

tnqn commented Jul 8, 2024

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jul 11, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, saschagrunert, tnqn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 11, 2024

@tnqn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-integration-go-compatibility 98d8d98 link unknown /test pull-kubernetes-integration-go-compatibility

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-triage-robot
Copy link

k8s-triage-robot commented Jul 11, 2024

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit f529a46 into kubernetes:release-1.28 Jul 11, 2024
@tnqn tnqn deleted the automated-cherry-pick-of-#125675-upstream-release-1.28 branch July 11, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@danwinship danwinship Awaiting requested review from danwinship

@thockin thockin Awaiting requested review from thockin

+1 more reviewer

@chymy chymy chymy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@aojea aojea

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG Apps
Archived in project

Milestone

v1.28

Development

Successfully merging this pull request may close these issues.

6 participants

@tnqn @k8s-ci-robot @aojea @k8s-triage-robot @saschagrunert @chymy