Skip to content

KEP-4033: fulfill beta criteria#125828

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
haircommander:4033-beta
Jul 15, 2024
Merged

KEP-4033: fulfill beta criteria#125828
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
haircommander:4033-beta

Conversation

@haircommander
Copy link
Copy Markdown
Contributor

@haircommander haircommander commented Jul 1, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

bump the feature gate to beta, and remove fallback, as described in the KEP

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Promoted CRI communication of cgroup driver mechanism, to beta.
The `KubeletCgroupDriverFromCRI` feature gate is now beta and enabled by default. This means that the kubelet queries the container runtime using CRI to discover the mechanism for cgroup management that the kubelet will use; if the container runtime doesn't support this, the kubelet falls back to loading this from its configuration file (you can also use the deprecated `--cgroup-driver` command line argument).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/4033-group-driver-detection-over-cri/README.md

@haircommander
KEP-4033: bump to beta
1816cc7 
Signed-off-by: Peter Hunt <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 1, 2024
@haircommander haircommander mentioned this pull request Jul 1, 2024
Closed
13 tasks
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 1, 2024
@k8s-ci-robot k8s-ci-robot requested review from kannon92 and wojtek-t July 1, 2024 19:28
@haircommander
Copy link
Copy Markdown
Contributor Author

haircommander commented Jul 1, 2024

hm it seems containerd 2.0 isn't prevelant enough to do the second commit https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/125828/pull-kubernetes-node-e2e-containerd/1807858650790760448/artifacts/tmp-node-e2e-036c16d4-ubuntu-gke-2204-1-29-v20240627/kubelet.log
@mikebrow do you think there's a chance to backport RuntimeStatus to 1.7 or is that not possible?

@ffromani
Copy link
Copy Markdown
Contributor

ffromani commented Jul 2, 2024

/triage accepted
/priority important-soon

AFAIR we want this work in 1.31, setting priority accordingly

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 2, 2024
@bart0sh
Copy link
Copy Markdown
Contributor

bart0sh commented Jul 3, 2024

/retest

@haircommander
Copy link
Copy Markdown
Contributor Author

haircommander commented Jul 3, 2024

I think we're not ready to remove the fallback, maybe we should retarget that to GA

@mrunalp
Copy link
Copy Markdown
Contributor

mrunalp commented Jul 15, 2024

@haircommander Can we update the user facing change note if we aren't dropping the fallback?

@haircommander
Copy link
Copy Markdown
Contributor Author

haircommander commented Jul 15, 2024

good point, updated

mrunalp
mrunalp approved these changes Jul 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 15, 2024

LGTM label has been added.

DetailsGit tree hash: 67b48543a0c0276705ea41092f0fa5d69f830a15

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2024
@haircommander
Copy link
Copy Markdown
Contributor Author

haircommander commented Jul 15, 2024

/retest

@k8s-ci-robot k8s-ci-robot merged commit e785ef8 into kubernetes:master Jul 15, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jul 15, 2024
@neolit123 neolit123 mentioned this pull request Jul 23, 2024
Open
@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jul 25, 2024 •
edited
Loading

Changelog suggestion

-Bump the KubeletCgroupDriverFromCRI feature gate to beta and true by default. The kubelet will continue to use its KubeletConfiguration field as a fallback if the CRI implementation doesn't support this feature. 
+Promoted CRI communication of cgroup driver mechanism, to beta.
+The `KubeletCgroupDriverFromCRI` feature gate is now beta and enabled by default. This means that the kubelet
+queries the container runtime using CRI to discover the mechanism for cgroup management that the kubelet
+will use; if the container runtime doesn't support this, the kubelet falls back to loading this from its configuration
+file (you can also use the deprecated `--cgroup-driver` command line argument).

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jul 25, 2024

Also, make sure to update https://kubernetes.io/docs/tasks/administer-cluster/kubeadm/configure-cgroup-driver/; the text

In Kubernetes v1.28, you can enable automatic detection of the cgroup driver as an alpha feature. See systemd cgroup driver for more details.

has become stale.

@npolshakova npolshakova mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kannon92 kannon92 Awaiting requested review from kannon92

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

1 more reviewer

@mrunalp mrunalp mrunalp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mrunalp mrunalp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG Node: code and documentation PRs
Archived in project

Milestone

v1.31

Development

Successfully merging this pull request may close these issues.

6 participants

@haircommander @ffromani @bart0sh @mrunalp @k8s-ci-robot @sftim