Skip to content

[KEP-4639] Add OCI VolumeSource CRI API #125659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jul 3, 2024
Merged

[KEP-4639] Add OCI VolumeSource CRI API #125659

k8s-ci-robot merged 1 commit into from
Jul 3, 2024
+562 −483

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jun 24, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adding the required container runtime interface API so that runtimes and consumers can start using it.

Which issue(s) this PR fixes:

Refers to kubernetes/enhancements#4639

Special notes for your reviewer:

The PullImageFullResponse service API extension is required to be able to use the mountpoint field through the API.

Does this PR introduce a user-facing change?

Added OCI VolumeSource Container Runtime Interface API fields and types.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

KEP: https://github.com/kubernetes/enhancements/issues/4639

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 24, 2024
@k8s-ci-robot k8s-ci-robot requested a review from dims June 24, 2024 07:48
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/node Categorizes an issue or PR as relevant to SIG Node. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 24, 2024
saschagrunert
saschagrunert commented Jun 24, 2024
View reviewed changes
@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 24, 2024

/test pull-kubernetes-e2e-kind-ipv6

This was referenced Jun 24, 2024
Open
Merged
Merged
Merged
@ffromani
Copy link
Contributor

ffromani commented Jun 24, 2024

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 24, 2024
mikebrow
mikebrow reviewed Jun 24, 2024
View reviewed changes
mikebrow
mikebrow reviewed Jun 24, 2024
View reviewed changes
@saschagrunert saschagrunert force-pushed the oci-volumesource-cri-api branch from 560196b to 694f73e Compare June 25, 2024 07:20
mikebrow
mikebrow reviewed Jun 25, 2024
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good a couple nits..

@saschagrunert saschagrunert force-pushed the oci-volumesource-cri-api branch from 694f73e to aa83fbc Compare June 25, 2024 14:54
@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 25, 2024

@kubernetes/sig-node-pr-reviews PTAL as well

@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 25, 2024

/retest

@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 25, 2024

/test pull-kubernetes-unit

@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 25, 2024

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2024
@saschagrunert saschagrunert force-pushed the oci-volumesource-cri-api branch 4 times, most recently from 2ba4842 to b305685 Compare July 1, 2024 16:32
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 1, 2024
mikebrow
mikebrow approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mrunalp
mrunalp reviewed Jul 3, 2024
View reviewed changes
AkihiroSuda
AkihiroSuda reviewed Jul 3, 2024
View reviewed changes
@saschagrunert
Add OCI VolumeSource CRI API
4484307 
Adding the required container runtime interface API so that runtimes and
consumers can start using it.

Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert saschagrunert force-pushed the oci-volumesource-cri-api branch from b305685 to 4484307 Compare July 3, 2024 07:07
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 3, 2024
mrunalp
mrunalp approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 3, 2024

LGTM label has been added.

DetailsGit tree hash: b5c0189bbd3432a0eee8d045501145a66a370362

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikebrow, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d95de06 into kubernetes:master Jul 3, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jul 3, 2024
@saschagrunert saschagrunert deleted the oci-volumesource-cri-api branch July 4, 2024 06:48
saschagrunert added a commit to saschagrunert/kubernetes-enhancements that referenced this pull request Jul 4, 2024
@saschagrunert
KEP-4639: Update CRI API and workflow
0c770bc 
Updating the KEP after the merge of:
kubernetes/kubernetes#125659

This reflects the current state of the enhancement.

Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert saschagrunert mentioned this pull request Jul 4, 2024
Merged
saschagrunert added a commit to saschagrunert/kubernetes-enhancements that referenced this pull request Jul 4, 2024
@saschagrunert
KEP-4639: Update CRI API and workflow
2305ba6 
Updating the KEP after the merge of:
kubernetes/kubernetes#125659

This reflects the current state of the enhancement.

Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert added a commit to saschagrunert/kubernetes-enhancements that referenced this pull request Jul 10, 2024
@saschagrunert
KEP-4639: Update CRI API and workflow
11ea92b 
Updating the KEP after the merge of:
kubernetes/kubernetes#125659

This reflects the current state of the enhancement.

Signed-off-by: Sascha Grunert <[email protected]>
@samuelkarp samuelkarp mentioned this pull request Jul 25, 2024
Closed
@fuweid fuweid mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims Awaiting requested review from dims

@haircommander haircommander Awaiting requested review from haircommander

5 more reviewers

@everpeace everpeace everpeace left review comments

@AkihiroSuda AkihiroSuda AkihiroSuda left review comments

@sallyom sallyom sallyom left review comments

@mrunalp mrunalp mrunalp approved these changes

@mikebrow mikebrow mikebrow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mrunalp mrunalp

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG Node: code and documentation PRs
Archived in project

Milestone

v1.31

Development

Successfully merging this pull request may close these issues.

9 participants

@saschagrunert @ffromani @mrunalp @haircommander @k8s-ci-robot @everpeace @AkihiroSuda @sallyom @mikebrow