k8s.io/apiserver: wire --disable-http2 flag to existing logic #116762

enj · 2023-03-20T15:36:10Z

This change simply wires the existing DisableHTTP2 boolean to a CLI flag so that it can be set without code level changes (and thus makes it available to the Kubernetes API server).

/kind feature
/milestone v1.28

The --disable-http2 flag can be set to prevent the use of HTTP/2.

This change simply wires the existing DisableHTTP2 boolean to a CLI flag so that it can be set without code level changes (and thus makes it available to the Kubernetes API server). Signed-off-by: Monis Khan <[email protected]>

k8s-ci-robot · 2023-03-20T15:52:03Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: enj
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2023-03-20T18:08:35Z

@enj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-integration	`04d0cf8`	link	true	`/test pull-kubernetes-integration`
pull-kubernetes-node-e2e-containerd	`04d0cf8`	link	true	`/test pull-kubernetes-node-e2e-containerd`
pull-kubernetes-e2e-kind	`04d0cf8`	link	true	`/test pull-kubernetes-e2e-kind`
pull-kubernetes-e2e-kind-ipv6	`04d0cf8`	link	true	`/test pull-kubernetes-e2e-kind-ipv6`
pull-kubernetes-conformance-kind-ga-only-parallel	`04d0cf8`	link	true	`/test pull-kubernetes-conformance-kind-ga-only-parallel`
pull-kubernetes-unit	`04d0cf8`	link	true	`/test pull-kubernetes-unit`
pull-kubernetes-e2e-gce	`04d0cf8`	link	true	`/test pull-kubernetes-e2e-gce`
pull-kubernetes-verify	`04d0cf8`	link	true	`/test pull-kubernetes-verify`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cici37 · 2023-03-21T20:07:27Z

/triage accepted

aojea · 2023-03-22T10:22:09Z

panics

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x70 pc=0x303af4d]

goroutine 1 [running]:
k8s.io/apiserver/pkg/server/options.(*ServerRunOptions).ApplyTo(0xc000393b20?, 0x503f500?)
	vendor/k8s.io/apiserver/pkg/server/options/server_run_options.go:123 +0xed
k8s.io/kubernetes/cmd/kube-apiserver/app.buildGenericConfig(0xc0007f4240, 0x0?)
	cmd/kube-apiserver/app/server.go:357 +0xc5
k8s.io/kubernetes/cmd/kube-apiserver/app.CreateKubeAPIServerConfig({0x0?})
	cmd/kube-apiserver/app/server.go:247 +0x4e
k8s.io/kubernetes/cmd/kube-apiserver/app.CreateServerChain({0xc000b05b60?})
	cmd/kube-apiserver/app/server.go:184 +0x36
k8s.io/kubernetes/cmd/kube-apiserver/app.Run({0xc000428000?}, 0x0?)
	cmd/kube-apiserver/app/server.go:169 +0x326
k8s.io/kubernetes/cmd/kube-apiserver/app.NewAPIServerCommand.func2(0xc000b76900?, {0xc000b76f00?, 0x0?, 0x2f?})
	cmd/kube-apiserver/app/server.go:135 +0xe5
github.com/spf13/cobra.(*Command).execute(0xc000b76900, {0xc000004610, 0x2f, 0x2f})
	vendor/github.com/spf13/cobra/command.go:916 +0x862
github.com/spf13/cobra.(*Command).ExecuteC(0xc000b76900)
	vendor/github.com/spf13/cobra/command.go:1040 +0x3bd
github.com/spf13/cobra.(*Command).Execute(...)
	vendor/github.com/spf13/cobra/command.go:968
k8s.io/component-base/cli.run(0xc000b76900)
	vendor/k8s.io/component-base/cli/run.go:146 +0x317
k8s.io/component-base/cli.Run(0xc0000061a0?)
	vendor/k8s.io/component-base/cli/run.go:46 +0x1d
main.main()
	cmd/kube-apiserver/apiserver.go:34 +0x1e

furkatgofurov7 · 2023-06-15T08:49:08Z

@enj hi 👋🏼, v1.28 Bug Triage Lead here.

Just checking-in on this PR and pinging if this is still on track for the 1.28 release?

k8s-ci-robot · 2023-06-27T06:36:29Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

furkatgofurov7 · 2023-06-30T07:15:49Z

@enj hey!

This PR has not been updated for a long time, so I'd like to check what's the status. Gentle reminder that the code freeze is starting 01:00 UTC Wednesday 19th July 2023 / 18:00 PDT Tuesday 18th July 2023 (about 3 weeks from now) and we want to ensure that each PR has a chance to be merged on time.

As the PR is tagged for 1.28, is it still planned for this release?

furkatgofurov7 · 2023-07-12T08:14:52Z

@enj hi!

This PR has not been updated for a long time now (needs: rebase, fixing CI checks and addressing a comment from @aojea) and I'd like to check what's the status with you once again.
FYI, as I informed about it already 2 weeks ago, we are in week 9 currently and the code freeze is starting next week (week 10) at 01:00 UTC Wednesday 19th July 2023 / 18:00 PDT Tuesday 18th July 2023.

Please remove the milestone if this not currently tracked for v1.28 release or if it is still, please make sure that it is in before the code freeze date above, thanks!

liggitt · 2023-07-12T18:52:49Z

cmd/kube-apiserver/app/options/options_test.go

 		"--cloud-provider=azure",
 		"--cors-allowed-origins=10.10.10.100,10.10.10.200",
 		"--contention-profiling=true",
+		"--disable-http2",


it's not clear whether this flag controls http2 serving or http2 in the various clients the API server creates/uses ... can we disambiguate this?

enj · 2023-07-19T13:34:36Z

/milestone next-candidate

enj · 2023-08-08T21:53:58Z

/milestone v1.29

MaryamTavakkoli · 2023-10-15T06:49:30Z

Hello!
I am checking in on behalf of the Bug Triage release team.

This PR has not been updated for a long time, so I'd like to check what's the status. The code freeze is starting (01:00 UTC Wednesday 1st November 2023 / 18:00 PDT Tuesday 31st October 2023) (about 2 weeks from now). Please ensure your PR goes in by then if you are targeting 1.29 release. (Also, please add the priority label)

Please let us know if we can be of any assistance and help :)

MaryamTavakkoli · 2023-10-27T08:52:25Z

Hello!
Bug triage for the 1.29 release cycle is here! I want to check the status and remind you that the code freeze is starting 01:00 UTC Wednesday 1st November 2023 / 18:00 PDT Tuesday 31st October 2023 (next week), as we want to ensure that each PR has a chance to be merged.
Are we still targeting the 1.29 release?

enj · 2023-10-27T21:57:29Z

/milestone clear

k8s-triage-robot · 2024-02-04T08:18:26Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-02-04T08:18:31Z

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 20, 2023

k8s-ci-robot added this to the v1.28 milestone Mar 20, 2023

k8s-ci-robot requested review from dims and liggitt March 20, 2023 15:37

enj force-pushed the enj/f/kas_disable_http2 branch from e5240ff to 04d0cf8 Compare March 20, 2023 15:51

k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 21, 2023

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2023

liggitt reviewed Jul 12, 2023

View reviewed changes

k8s-ci-robot modified the milestones: v1.28, next-candidate Jul 19, 2023

k8s-ci-robot modified the milestones: next-candidate, v1.29 Aug 8, 2023

dims added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 24, 2023

k8s-ci-robot removed this from the v1.29 milestone Oct 27, 2023

k8s-ci-robot closed this Feb 4, 2024

rexagod mentioned this pull request Feb 16, 2024

Expose DisableHTTP2 flag in SecureServingOptions #122176

Merged

k8s.io/apiserver: wire --disable-http2 flag to existing logic #116762

k8s.io/apiserver: wire --disable-http2 flag to existing logic #116762

Uh oh!

Conversation

enj commented Mar 20, 2023

Uh oh!

k8s-ci-robot commented Mar 20, 2023

Uh oh!

k8s-ci-robot commented Mar 20, 2023

Uh oh!

cici37 commented Mar 21, 2023

Uh oh!

aojea commented Mar 22, 2023

Uh oh!

furkatgofurov7 commented Jun 15, 2023

Uh oh!

k8s-ci-robot commented Jun 27, 2023

Uh oh!

furkatgofurov7 commented Jun 30, 2023

Uh oh!

furkatgofurov7 commented Jul 12, 2023

Uh oh!

liggitt Jul 12, 2023

Choose a reason for hiding this comment

Uh oh!

enj commented Jul 19, 2023

Uh oh!

enj commented Aug 8, 2023

Uh oh!

MaryamTavakkoli commented Oct 15, 2023

Uh oh!

MaryamTavakkoli commented Oct 27, 2023

Uh oh!

enj commented Oct 27, 2023

Uh oh!

k8s-triage-robot commented Feb 4, 2024

Uh oh!

k8s-ci-robot commented Feb 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants