Skip to content

Include head and tail of clipped test messages#114954

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
liggitt:head-prune
Jan 10, 2023
Merged

Include head and tail of clipped test messages#114954
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
liggitt:head-prune

Conversation

@liggitt
Copy link
Copy Markdown
Member

@liggitt liggitt commented Jan 10, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates test message clipping to include both the start and end of clipped messages. Sometimes the important bit is at the top (like a data race or panic or test failure), sometimes it's at the end. This helps us see both ends of the message.

NONE

/assign @dims

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 10, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 10, 2023

@liggitt: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 10, 2023
@liggitt liggitt mentioned this pull request Jan 10, 2023
Merged
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2023
@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Jan 10, 2023

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 10, 2023
@dims
Copy link
Copy Markdown
Member

dims commented Jan 10, 2023

/approve
/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 10, 2023

LGTM label has been added.

DetailsGit tree hash: 0103410ef5c1ad563e7ed6fde4f0ed419a115bc6

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d4faca5 into kubernetes:master Jan 10, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 10, 2023
@liggitt liggitt deleted the head-prune branch May 9, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@dims dims

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.27

Development

Successfully merging this pull request may close these issues.

3 participants

@liggitt @k8s-ci-robot @dims