Skip to content

use etcd 3.5.6-0 after etcd image is promoted#114093

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
pacoxu:etcd-3.5.6
Nov 24, 2022
Merged

use etcd 3.5.6-0 after etcd image is promoted#114093
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
pacoxu:etcd-3.5.6

Conversation

@pacoxu
Copy link
Copy Markdown
Member

@pacoxu pacoxu commented Nov 24, 2022 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes None

Special notes for your reviewer:

Two possible data inconsistency issues in etcd v3.4.[20-21] and v3.5

Two issues below:
1 - etcd v3.5.[0-5] data inconsistency issue for a case when etcd crashes during processing defragmentation operation
2 - etcd v3.4.[20-21] and v3.5.5 data inconsistency issue for a case when auth is enabled and a new member added to the cluster

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 24, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 24, 2022

Please note that we're already in Test Freeze for the release-1.26 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.26.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Nov 23 21:33:10 UTC 2022.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm area/provider/gcp Issues or PRs related to gcp provider area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 24, 2022
@pacoxu pacoxu changed the title use etcd 3.5.6-0 after promotion use etcd 3.5.6-0 after etcd image is promoted Nov 24, 2022
@dims
Copy link
Copy Markdown
Member

dims commented Nov 24, 2022

/priority critical-urgent
/triage accepted
/approve
/lgtm

cc @kubernetes/release-managers - please add /milestone v1.26

please see https://groups.google.com/a/kubernetes.io/g/dev/c/sEVopPxKPDo/m/9ME3CzicBwAJ for context.

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 24, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2022
@palnabarun
Copy link
Copy Markdown
Member

palnabarun commented Nov 24, 2022

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4527965 into kubernetes:master Nov 24, 2022
@xmudrii
Copy link
Copy Markdown
Member

xmudrii commented Nov 24, 2022

I think this should also be cherry-picked to 1.25-1.23. @pacoxu Do you want to take care of that?

This was referenced Nov 24, 2022
Merged
Merged
Merged
Merged
@pacoxu
Copy link
Copy Markdown
Member Author

pacoxu commented Nov 24, 2022

I think this should also be cherry-picked to 1.25-1.23. @pacoxu Do you want to take care of that?

Cherry-Pick PRs are opened now.

@mzaian mzaian mentioned this pull request Nov 24, 2022
Merged
k8s-ci-robot added a commit that referenced this pull request Dec 2, 2022
@k8s-ci-robot
Merge pull request #114105 from pacoxu/automated-cherry-pick-of-#1140…
dd93f55 
…93-upstream-release-1.25

Automated cherry pick of #114093: use etcd 3.5.6-0 after promotion
k8s-ci-robot added a commit that referenced this pull request Dec 2, 2022
@k8s-ci-robot
Merge pull request #114108 from pacoxu/automated-cherry-pick-of-#1140…
4392de4 
…93-upstream-release-1.22

Automated cherry pick of #114093: use etcd 3.5.6-0 after promotion
k8s-ci-robot added a commit that referenced this pull request Dec 2, 2022
@k8s-ci-robot
Merge pull request #114106 from pacoxu/automated-cherry-pick-of-#1140…
d9d6649 
…93-upstream-release-1.24

Automated cherry pick of #114093: use etcd 3.5.6-0 after promotion
k8s-ci-robot added a commit that referenced this pull request Dec 2, 2022
@k8s-ci-robot
Merge pull request #114107 from pacoxu/automated-cherry-pick-of-#1140…
32ea17e 
…93-upstream-release-1.23

Automated cherry pick of #114093: use etcd 3.5.6-0 after promotion
This was referenced Dec 6, 2022
Merged
Merged
@dims dims mentioned this pull request Dec 11, 2022
Closed
@CecileRobertMichon CecileRobertMichon mentioned this pull request Dec 13, 2022
Merged
3 tasks
@pacoxu pacoxu mentioned this pull request Dec 23, 2022
Closed
6 tasks
@hakman hakman mentioned this pull request Jan 27, 2023
Merged
@pchan pchan mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bowei bowei Awaiting requested review from bowei

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@dims dims

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.26

Development

Successfully merging this pull request may close these issues.

5 participants

@pacoxu @k8s-ci-robot @dims @palnabarun @xmudrii