Skip to content

go1.19: change some atomic.Value to atomic.Bool #112258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Sep 30, 2022
Merged

go1.19: change some atomic.Value to atomic.Bool #112258

k8s-ci-robot merged 1 commit into from
Sep 30, 2022

Conversation

@Abirdcfly
Copy link
Member

@Abirdcfly Abirdcfly commented Sep 6, 2022

Signed-off-by: Abirdcfly [email protected]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

go 1.19 introduce https://pkg.go.dev/sync/atomic#Bool, with changing some atomic.Value to atomic.Bool make the code self-document and type safe.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 6, 2022
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 6, 2022
@leilajal
Copy link
Contributor

leilajal commented Sep 6, 2022

/assign @yliaog
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 6, 2022
@hzxuzhonghu
Copy link
Member

hzxuzhonghu commented Sep 7, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2022
@Abirdcfly
Copy link
Member Author

Abirdcfly commented Sep 7, 2022

/assign @deads2k, serathius

for approval

@yliaog
Copy link
Contributor

yliaog commented Sep 7, 2022

/lgtm

@Abirdcfly
Copy link
Member Author

Abirdcfly commented Sep 7, 2022

/assign @deads2k @serathius

for approval (I guess this assign syntax is correct, Let me try)

@0xff-dev 0xff-dev mentioned this pull request Sep 7, 2022
Merged
@serathius
Copy link
Contributor

serathius commented Sep 7, 2022

/approve

@Abirdcfly
Copy link
Member Author

Abirdcfly commented Sep 18, 2022

/assign @liggitt
for approval.

@liggitt
Copy link
Member

liggitt commented Sep 19, 2022

/assign @deads2k
/unassign

routing to @deads2k to load-balance per #112258 (comment)

@deads2k
Copy link
Contributor

deads2k commented Sep 30, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Abirdcfly, deads2k, hzxuzhonghu, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Sep 30, 2022

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit f8bb82c into kubernetes:master Sep 30, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 30, 2022
@thaJeztah thaJeztah mentioned this pull request Dec 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

1 more reviewer

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@serathius serathius

@deads2k deads2k

@hzxuzhonghu hzxuzhonghu

@yliaog yliaog

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.26

Development

Successfully merging this pull request may close these issues.

9 participants

@Abirdcfly @leilajal @hzxuzhonghu @yliaog @serathius @liggitt @deads2k @k8s-ci-robot @k8s-triage-robot