Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PodSecurity: promote config and feature gate to GA #110459

Merged
merged 1 commit into from
Jun 15, 2022
Merged

PodSecurity: promote config and feature gate to GA #110459

merged 1 commit into from
Jun 15, 2022

Conversation

wangyysde
Copy link
Member

@wangyysde wangyysde commented Jun 8, 2022 •
edited by liggitt
Loading

Signed-off-by: wangyysde [email protected]

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Promotes PodSecurity to GA

Which issue(s) this PR fixes:

Fixes #110437
xref kubernetes/enhancements#2579
/sig auth

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The PodSecurity admission plugin has graduated to GA and is enabled by default. The admission configuration version has been promoted to `pod-security.admission.config.k8s.io/v1`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]:  [https://github.com/kubernetes/enhancements/pull/3310](https://github.com/kubernetes/enhancements/pull/3310)
- [Usage]: https://kubernetes.io/docs/concepts/security/pod-security-admission/

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 8, 2022
@wangyysde
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 8, 2022
@k8s-ci-robot k8s-ci-robot requested review from hwdef and krmayankk June 8, 2022 15:26
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 8, 2022
@wangyysde
Copy link
Member Author

/label api-review

tallclair
tallclair reviewed Jun 10, 2022
View reviewed changes
Copy link
Member

@tallclair tallclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

modules.txt Outdated
@@ -0,0 +1,2893 @@
# bitbucket.org/bertimus9/systemstat v0.0.0-20180207000608-0eeff89b0690 => bitbucket.org/bertimus9/systemstat v0.0.0-20180207000608-0eeff89b0690
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file looks unrelated to this PR. Remove?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. I have removed it.

@wangyysde wangyysde requested a review from tallclair June 11, 2022 08:19
@wangyysde
Copy link
Member Author

@liggitt @tallclair I have modified this PR. Could you review it again? Thanks.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 14, 2022
@wangyysde wangyysde requested a review from liggitt June 14, 2022 09:02
@wangyysde
Copy link
Member Author

@liggitt @tallclair I have modified this PR. Could you review it again? Thanks.

@liggitt
Copy link
Member

liggitt commented Jun 14, 2022

a couple final changes, squash to a single commit, then lgtm

@wangyysde wangyysde requested a review from liggitt June 15, 2022 05:58
@wangyysde
Copy link
Member Author

@liggitt @tallclair I have modified this PR. Could you review it again? Thanks.

@liggitt
Copy link
Member

liggitt commented Jun 15, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, wangyysde

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2022
@liggitt liggitt mentioned this pull request Jun 15, 2022
Closed
12 tasks
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 4b024fc into kubernetes:master Jun 15, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 15, 2022
@sftim
Copy link
Contributor

sftim commented Jun 25, 2022

Can I suggest a changelog tweak?

-The PodSecurity admission plugin has graduated to ga and is locked to enable. The admission configuration version has been promoted to pod-security.admission.config.k8s.io/v1. See https://kubernetes.io/docs/concepts/security/pod-security-admission/ for usage guidelines.
+The PodSecurity admission plugin has graduated to GA and is enabled by default. The admission configuration version has been promoted to `pod-security.admission.config.k8s.io/v1`.

and move

See https://kubernetes.io/docs/concepts/security/pod-security-admission/ for usage guidelines.

to the extra docs section, before the KEP link.

Unless I'm wrong, you can disable the PodSecurity admission plugin, just like any other: kube-apiserver --disable-admission-plugins=PodSecurity.

@liggitt
Copy link
Member

liggitt commented Jun 25, 2022

That's correct. So tweaked.

@sftim sftim mentioned this pull request Jun 25, 2022
Closed
@sftim
Copy link
Contributor

sftim commented Jun 25, 2022

🏎️

@liggitt
Copy link
Member

liggitt commented Jun 25, 2022 •
edited
Loading

(to be clear, the feature gate is GA and locked, so setting --feature-gates=PodSecurity=false no longer works, but the normal mechanism for disabling an admission plug-in remains available and functional)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@krmayankk krmayankk Awaiting requested review from krmayankk

@tallclair tallclair Awaiting requested review from tallclair

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@tallclair tallclair

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.25
SIG Auth
Archived in project
SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

[PodSecurity] Add v1 config API (pod-security.admission.config.k8s.io)
7 participants
@wangyysde @k8s-triage-robot @hwdef @liggitt @k8s-ci-robot @sftim @tallclair